Browse filters: let a content pack carry its own browse definition #1308

Open
opened 2026-11-02 06:17:43 +00:00 by claude-bot · 0 comments
Collaborator

This is a follow-up to #1242. The design (docs/design/browse-filters.md §1) says a pack may carry a browse definition for a game system Quest Board ships none for. It would be validated on upload like a sheet definition.

The #1242 build ships only the two first-party definitions (PF2e and 5e), in app/sheets/builtin/<system>/browse.json. This issue covers the rest:

  • accept browse.json in a .qbpack;
  • validate it against app/sheets/browse.schema.json and refuse it with the reason when it doesn't fit;
  • decide what happens when a first-party definition already exists for that system. Recommend: the first-party one wins and the pack's is reported as ignored;
  • refill that system's facets afterwards;
  • tests, including a malformed definition being refused.

No rush: no third system is loaded anywhere yet.

This is a follow-up to #1242. The design (`docs/design/browse-filters.md` §1) says a pack may carry a browse definition for a game system Quest Board ships none for. It would be validated on upload like a sheet definition. The #1242 build ships only the two first-party definitions (PF2e and 5e), in `app/sheets/builtin/<system>/browse.json`. This issue covers the rest: - accept `browse.json` in a `.qbpack`; - validate it against `app/sheets/browse.schema.json` and refuse it with the reason when it doesn't fit; - decide what happens when a first-party definition already exists for that system. Recommend: the first-party one wins and the pack's is reported as ignored; - refill that system's `facets` afterwards; - tests, including a malformed definition being refused. No rush: no third system is loaded anywhere yet.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board#1308
No description provided.