feat(webapp): browse the rules, stage 3 — each system's own filters (#1242) #1312

Merged

claude-bot merged 13 commits from feat/1242-system-filters into main 2026-11-02 17:36:16 +00:00

Conversation 3 Commits 13 Files changed 36 +5194 -47

claude-bot commented 2026-11-02 07:19:09 +00:00

Collaborator

Copy link

Closes #1242. It includes the design from #1307 (the note, lane 6g, and D310–D313), which this replaces.

What it adds

• Browse definitions, data in app/sheets/builtin/{pf2e,dnd5e}/browse.json with a schema. They declare each kind's filters and sorts, as D310 sets out.
• reference_entries.facets:
  • migration b1242c0d1e2f: the column plus a GIN jsonb_path_ops index, with a real downgrade;
  • filled at import;
  • refilled by a Celery task at worker start whenever a definition's version changes, so existing installs fill themselves and the deploy needs no manual step;
  • python -m app.cli refill_facets does the same by hand.
• API:
  • f_<key> and sort on the page routes (campaign, library and admin pack);
  • GET /api/game-systems/{key}/reference/filters and GET /api/admin/content-packs/{id}/browse/filters, which return the filters with counts computed exclude-self (D311) and the sorts (D313);
  • a filter that no record can fill is left out.
• The page:
  • the filter row as drawn: ranges with units, pressed choices with counts, a type-ahead for long multis (traits), and "Only" checkboxes;
  • a range that replaces level takes its place;
  • "· N set" and "Clear them", and the Sort select;
  • every filter is in the address, and "Copy a link to it" carries them;
  • on a phone, "Filters (N)" folds the system's filters (D312).
• The same row appears in a campaign, in the library and in Admin's Browse.

Checked so far

• Backend: lint is clean, and the checks pass.
  • The 63 new facet tests pass.
  • The reference, content-pack, CLI and sheets modules gave 1313 passed and 1 failed. That failure was the sheet-definition test reading browse.json as a sheet; it was fixed and that test file re-run green.
  • Migration upgrade, downgrade and re-upgrade all ran on Postgres 18.
  • Every path was checked against all 6,155 records of the real starter packs.
• Frontend: lint has 0 errors.
  • The affected set gave 359 passed, and the 2 failures there (AppFrame, Party) passed when re-run alone.
  • The 4 new tests that failed on "Occult211" are fixed in d80f883d, but those three new files weren't re-run on their own after the fix.
  • The full vitest run didn't finish on the loaded host, at a load average of about 30.
• Not yet: the full suites, which CI runs, and the render check, which is running.

Out of scope: packs carrying their own browse definition, #1308.

New wording goes on the Wording Review page before this merges.

🤖 Generated with Claude Code

Closes #1242. It includes the design from #1307 (the note, lane 6g, and D310–D313), which this replaces. **What it adds** - **Browse definitions**, data in `app/sheets/builtin/{pf2e,dnd5e}/browse.json` with a schema. They declare each kind's filters and sorts, as D310 sets out. - **`reference_entries.facets`**: - migration `b1242c0d1e2f`: the column plus a GIN `jsonb_path_ops` index, with a real downgrade; - filled at import; - refilled by a Celery task at worker start whenever a definition's version changes, so existing installs fill themselves and the deploy needs no manual step; - `python -m app.cli refill_facets` does the same by hand. - **API:** - `f_<key>` and `sort` on the page routes (campaign, library and admin pack); - `GET /api/game-systems/{key}/reference/filters` and `GET /api/admin/content-packs/{id}/browse/filters`, which return the filters with counts computed exclude-self (D311) and the sorts (D313); - a filter that no record can fill is left out. - **The page:** - the filter row as drawn: ranges with units, pressed choices with counts, a type-ahead for long multis (traits), and "Only" checkboxes; - a range that `replaces` level takes its place; - "· N set" and "Clear them", and the Sort select; - every filter is in the address, and "Copy a link to it" carries them; - on a phone, "Filters (N)" folds the system's filters (D312). - The same row appears in a campaign, in the library and in Admin's Browse. **Checked so far** - Backend: lint is clean, and the checks pass. - The 63 new facet tests pass. - The reference, content-pack, CLI and sheets modules gave 1313 passed and 1 failed. That failure was the sheet-definition test reading `browse.json` as a sheet; it was fixed and that test file re-run green. - Migration upgrade, downgrade and re-upgrade all ran on Postgres 18. - Every path was checked against all 6,155 records of the real starter packs. - Frontend: lint has 0 errors. - The affected set gave 359 passed, and the 2 failures there (AppFrame, Party) passed when re-run alone. - The 4 new tests that failed on "Occult211" are fixed in d80f883d, but those three new files weren't re-run on their own after the fix. - The full vitest run didn't finish on the loaded host, at a load average of about 30. - **Not yet:** the full suites, which CI runs, and the render check, which is running. **Out of scope:** packs carrying their own browse definition, #1308. New wording goes on the Wording Review page before this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 11 commits 2026-11-02 07:19:09 +00:00

design: browse the rules, stage 3 -- each system's filters (#1242) ... 42474120bb

docs/design/browse-filters.md: filters declared per system in a browse
definition (data, as D76), their values copied at import into a facets
column with one GIN index (PG18: the slowest filter 102 ms -> 5 ms), and
what the page shows. Lane 6g draws it: PF2e spells, creatures and
equipment, 5e spells and equipment, a phone; four questions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

design: system filters decided, D310-D313 (#1242) ... 9745ea1d35

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into feat/1242-system-filters 9b71b71acf

feat(webapp): each game system's own filters in Browse the Rules (#1242) ... 3a4f76eba1

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

wip: browse definitions, facets column, filters routes (#1242) b93190f2ec

wip: tests, schema 0dbb29c81a

wip: docs, changelog, fixes 1d2950a630

wip: feat categories d4231214c7

fix(webapp): a choice's count is a word apart in its name (#1242) ... d80f883db9

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

feat(webapp): browse filters for each game system, backend (#1242) ... f6cb585804

Browse definitions as data per system, a facets column filled at import and
refilled at worker start, f_* and sort on the reference page, and the filters
route with D311 counts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge branch 'feat/1242-frontend' into feat/1242-system-filters 6398ed341a

claude-bot referenced this pull request 2026-11-02 07:19:26 +00:00

design: browse the rules, stage 3 — each system's filters (#1242) #1307

claude-bot commented 2026-11-02 07:54:19 +00:00

Author

Collaborator

Copy link

Render check (journeys stack, both starters loaded)

The run: 30 shots at 1280×800 and 390×844, in light and dark, as Dana and Priya. Every shot returned HTTP 200, with 0 console errors and no overflow on a phone. Axe found no violations on the spells row, the creatures row, or the open phone fold.

What renders:

• PF2e spells: Rank in place of Level, Tradition chips with counts, "Only" (Cantrips, Focus spells), Rarity, "· 2 set / Clear them", and Sort.
• PF2e creatures: Size chips, with Small 0 kept in the row, and the trait type-ahead with an "Undead ×" chip.
• PF2e equipment: Price "0 to 5 gp".
• 5e spells: School, Class (Wizard), and Ritual and Concentration.
• 5e creatures: CR 0 to 30 in place of Level.
• The phone, folded and open.
• A campaign's Rules page, which adds its Pack row.
• Admin's pack Browse page.

The API agrees with the page:

• filters?kind=spell gives tradition arcane 607, divine 369, occult 548 and primal 450.
• With f_rank=1..3 those drop to 333, 192, 299 and 264 (exclude-self, as D311 sets out).
• The page total for occult with rank 1–3 is 299, the same as the chip.

Found and fixed in this PR:

• A PF2e cantrip read "Spell 7" (Allegro heightens to 7). It now reads "Cantrip 7".
• A row's one-line summary showed markdown ("Area 1 cubic foot"). It's now plain words.

Two notes, not defects:

• "Filters (1)" counts only the folded system filters. "· 2 set" also counts Rank, which stays in view.
• A campaign's counts include its own pack, so Arcane reads 613 there and 607 in the library.

## Render check (journeys stack, both starters loaded) The run: 30 shots at 1280×800 and 390×844, in light and dark, as Dana and Priya. Every shot returned HTTP 200, with 0 console errors and no overflow on a phone. Axe found no violations on the spells row, the creatures row, or the open phone fold. **What renders:** - PF2e spells: Rank in place of Level, Tradition chips with counts, "Only" (Cantrips, Focus spells), Rarity, "· 2 set / Clear them", and Sort. - PF2e creatures: Size chips, with Small 0 kept in the row, and the trait type-ahead with an "Undead ×" chip. - PF2e equipment: Price "0 to 5 gp". - 5e spells: School, Class (Wizard), and Ritual and Concentration. - 5e creatures: CR 0 to 30 in place of Level. - The phone, folded and open. - A campaign's Rules page, which adds its Pack row. - Admin's pack Browse page. **The API agrees with the page:** - `filters?kind=spell` gives tradition arcane 607, divine 369, occult 548 and primal 450. - With `f_rank=1..3` those drop to 333, 192, 299 and 264 (exclude-self, as D311 sets out). - The page total for occult with rank 1–3 is 299, the same as the chip. **Found and fixed in this PR:** - A PF2e cantrip read "Spell 7" (Allegro heightens to 7). It now reads "Cantrip 7". - A row's one-line summary showed markdown ("**Area** 1 cubic foot"). It's now plain words. Two notes, not defects: - "Filters (1)" counts only the folded system filters. "· 2 set" also counts Rank, which stays in view. - A campaign's counts include its own pack, so Arcane reads 613 there and 607 in the library.

rbrooks added 1 commit 2026-11-02 07:56:45 +00:00

fix(webapp): cantrips read Cantrip N, and a row's summary drops its markdown (#1242) ... 9511b34bc4

Found by the render check: Allegro (a cantrip heightened to 7) read
"Spell 7", and Approximate's summary read "**Area** 1 cubic foot".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-11-02 07:56:48 +00:00

Author

Collaborator

Copy link

A correction to my last comment: the cantrip and summary fixes (9511b34b) were not verified when I called them fixed.

On docker-test, the 8 affected files gave 76 passed and 7 failed, at a load average of 40–45. My filter kept the failing test names but not their errors, so I can't yet say whether those 7 are host timeouts or real. They're spread across files the change doesn't touch (RulesLibrary, Rules, RulesBrowse, RulesFilters, RulesOpen), which looks like load, but that's a guess. I'm pushing so CI's runners decide. If CI fails, I'll pull the log.

A correction to my last comment: the cantrip and summary fixes (9511b34b) were not verified when I called them fixed. On docker-test, the 8 affected files gave 76 passed and 7 failed, at a load average of 40–45. My filter kept the failing test names but not their errors, so I can't yet say whether those 7 are host timeouts or real. They're spread across files the change doesn't touch (RulesLibrary, Rules, RulesBrowse, RulesFilters, RulesOpen), which looks like load, but that's a guess. I'm pushing so CI's runners decide. If CI fails, I'll pull the log.

rbrooks added 1 commit 2026-11-02 16:44:23 +00:00

test: the one-head pin follows the facets migration (#1242) ... 8decefb8ac

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-11-02 17:24:55 +00:00

claude-bot commented 2026-11-02 17:34:16 +00:00

Author

Collaborator

Copy link

CI's first backend run stopped on one real failure: the one-head pin in tests/export/test_import_jobs_migration.py still named a1269b0c1d2e. It now names b1242c0d1e2f, and it's the only test that pins the head.

Both frontend jobs passed on that same CI run, so the 7 failures I saw earlier on docker-test were host load (load average 40–45), not this change.

The full backend suite on postgres:18, run on docker-test against the branch with the fix: 10500 passed, 14 skipped, 0 failed, in 47 minutes.

This PR is set to merge when CI is green. The owner approved its wording (part m) on 2 Nov.

CI's first backend run stopped on one real failure: the one-head pin in `tests/export/test_import_jobs_migration.py` still named `a1269b0c1d2e`. It now names `b1242c0d1e2f`, and it's the only test that pins the head. Both frontend jobs passed on that same CI run, so the 7 failures I saw earlier on docker-test were host load (load average 40–45), not this change. **The full backend suite** on postgres:18, run on docker-test against the branch with the fix: **10500 passed, 14 skipped, 0 failed**, in 47 minutes. This PR is set to merge when CI is green. The owner approved its wording (part m) on 2 Nov.

claude-bot merged commit 3a831feb7d into main 2026-11-02 17:36:16 +00:00

claude-bot referenced this pull request from a commit 2026-11-02 17:36:18 +00:00

Merge pull request 'feat(webapp): browse the rules, stage 3 — each system's own filters (#1242)' (#1312) from feat/1242-system-filters into main

claude-bot referenced this pull request 2026-11-02 18:49:47 +00:00

Browse the rules, stage 3: filters for each game system (spell tradition and rank, creature traits and size, item price and bulk…) #1242

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1312

No description provided.