feat(feedback): ten more kinds of name to score, and a flow check (#1257)

claude-bot commented

2026-11-02 16:36:51 +00:00

Collaborator

The owner asked for more kinds of name on the feedback site's Names page, so the scoring can cover the rest of #1257's plan. This changes only the feedback site, not the app. It's already live on the dev feedback site (data backed up first).

New kinds (15 in all), with every list written for Quest Board:

People:
- Human: Sunreach (warm southern, "Casiro da Valrossi");
- Human: Northmarch (Norse-flavoured but invented, "Sigrik Frost-Brow", "Gunnir Sigasson");
- Halfling ("Kitwick Honeyfoot");
- Gnomish ("Fizlin Thimblepocket");
- Orcish ("Hurgash Blackfist");
- Goblin ("Gabnik Spoonpoker").
Places:
- Landscape ("the Whispering Fen", "Hepmouth Gorge", "Mount Brede");
- Countries & realms ("Velmark", "the Free Cities of Ilthara").
Other:
- Organisations ("the Order of the Silent Key", "the Guild of Lamplighters");
- Ships ("the Restless Petrel", "Marrow's Revenge", "Perseverance").
The style buttons are grouped: people first (the humans together), then places, then other things.

A flow check for people's names. The owner's 👎 on "Godgyth" was about saying it aloud. Every person style now rejects, within a word:

a hard stop next to a hard stop (d|g);
a doubled h;
four consonants in a row;
three in a row, unless they hold th/sh/ch/ng/ck/st or are an easy run (ndr, mbl…).

The orc and Northmarch names also reject two vowels together. The check also applies to the three existing person styles, so Hearthland, Elvish and Dwarvish draws now skip awkward joins too. Their 👍 and 👎 marks so far are kept.

Fixes to existing styles:

tavern plurals: "The Four Hopses", "Calfs", "Oxes" and "Gooses" now come out right;
famous names are filtered: Frodo, Bilbo, Samwise, Pippin, Gandalf, Aragorn, Tinkerbell, Baggins and others.

Server side: NAME_STYLES accepts the new ids, the admin page labels them, and a new test saves marks on every new style.

Checked:

the page loads with 15 styles and no console errors (Playwright);
28,000 draws sampled by script with no bad plurals or famous names;
feedback-site tests: 159 passed.

🤖 Generated with Claude Code

The owner asked for more kinds of name on the feedback site's Names page, so the scoring can cover the rest of #1257's plan. This changes only the feedback site, not the app. It's already live on the dev feedback site (data backed up first). **New kinds (15 in all)**, with every list written for Quest Board: - **People:** - Human: Sunreach (warm southern, "Casiro da Valrossi"); - Human: Northmarch (Norse-flavoured but invented, "Sigrik Frost-Brow", "Gunnir Sigasson"); - Halfling ("Kitwick Honeyfoot"); - Gnomish ("Fizlin Thimblepocket"); - Orcish ("Hurgash Blackfist"); - Goblin ("Gabnik Spoonpoker"). - **Places:** - Landscape ("the Whispering Fen", "Hepmouth Gorge", "Mount Brede"); - Countries & realms ("Velmark", "the Free Cities of Ilthara"). - **Other:** - Organisations ("the Order of the Silent Key", "the Guild of Lamplighters"); - Ships ("the Restless Petrel", "Marrow's Revenge", "Perseverance"). - The style buttons are grouped: people first (the humans together), then places, then other things. **A flow check for people's names.** The owner's 👎 on "Godgyth" was about saying it aloud. Every person style now rejects, within a word: - a hard stop next to a hard stop (d|g); - a doubled h; - four consonants in a row; - three in a row, unless they hold th/sh/ch/ng/ck/st or are an easy run (ndr, mbl…). The orc and Northmarch names also reject two vowels together. The check also applies to the three existing person styles, so Hearthland, Elvish and Dwarvish draws now skip awkward joins too. Their 👍 and 👎 marks so far are kept. **Fixes to existing styles:** - tavern plurals: "The Four Hopses", "Calfs", "Oxes" and "Gooses" now come out right; - famous names are filtered: Frodo, Bilbo, Samwise, Pippin, Gandalf, Aragorn, Tinkerbell, Baggins and others. **Server side:** `NAME_STYLES` accepts the new ids, the admin page labels them, and a new test saves marks on every new style. **Checked:** - the page loads with 15 styles and no console errors (Playwright); - 28,000 draws sampled by script with no bad plurals or famous names; - feedback-site tests: 159 passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit

2026-11-02 16:36:51 +00:00

feat(feedback): ten more kinds of name to score, and a flow check (#1257 )

CI / Bot/backend version sync (pull_request) Successful in 23s

Details

CI / Backend lint (ruff) (pull_request) Successful in 32s

Details

CI / Does this change touch the recording path? (pull_request) Successful in 19s

Details

CI / Which journeys does this change need? (pull_request) Successful in 19s

Details

CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped

Details

CI / Feedback site tests (pull_request) Successful in 47s

Details

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 57s

Details

CI / Bot tests and audit (pull_request) Successful in 2m5s

Details

CI / Docker image build (pull_request) Successful in 4m37s

Details

CI / End-to-end journeys (desktop) (pull_request) Has been skipped

Details

CI / Frontend (shard 2/2) (pull_request) Successful in 8m41s

Details

CI / Frontend (shard 1/2) (pull_request) Successful in 9m56s

Details

CI / Backend migration, tests, and audit (pull_request) Successful in 32m54s

Details

631579ea84

Sunreach and Northmarch humans, halfling, gnome, orc and goblin people;
landscape and countries; organisations and ships. Lists written for
Quest Board. Person names are checked at their joins (no hard stop next
to a hard stop, no four-consonant runs) so they can be said aloud, after
the owner's note that "Godgyth" tripped. Also: Hops, Ox, Calf and
Goose plurals on tavern signs; famous names filtered (Tinkerbell,
Baggins). The server accepts the new style ids; the admin page names them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request

2026-11-02 16:36:53 +00:00

Names without the AI: a built-in name generator with extensive lists (hybrid) #1257

claude-bot scheduled this pull request to auto merge when all checks succeed

2026-11-02 16:43:41 +00:00

claude-bot merged commit 1995d7a890 into main

2026-11-02 17:09:51 +00:00

claude-bot referenced this pull request from a commit

2026-11-02 17:09:52 +00:00

Merge pull request 'feat(feedback): ten more kinds of name to score, and a flow check (#1257)' (#1314) from feat/1257-more-name-styles into main

Rows
Columns

feat(feedback): ten more kinds of name to score, and a flow check (#1257) #1314