rbrooks/Quest-Board

Watch

Fork 0

Fill it in, slice 1: the recipes, to rate on the feedback site (#1328) #1354

Merged

claude-bot merged 4 commits from feat/1328-recipes into main

2026-11-06 21:03:46 +00:00

claude-bot commented

2026-11-06 08:02:23 +00:00

Collaborator

Slice 1 of #1328 "Fill it in": the reviewed recipe data and a rating page, the way the name generator was done (#1257). Nothing in webapp/ or bot/ changes.

static/fill-data.js: jobs first (141 jobs, each with its trades, a title per trade, lowest size, traits, relative chance); 23 trades (the 22 from Q227 plus Magic & enchantments, flagged magic) with sizes, headcount, who runs it, required jobs, name patterns on the rolled owner's name, what-it-does lines, place needs; general traits, secrets, wants, fears, rumours; value tables for the suggested facts (generic, pf2e, dnd5e).
static/fill-engine.js and static/companies.html: roll a company (trade or Surprise me, size or any, magic switch, name style), rate the trade up or down with a note.
Names engine split out of names.html into name-engine.js (a mechanical move) so both pages draw from the same generators.
app.py: companies store (PUT /api/responses/companies/<id>, strict document, same share keys and source labels), admin tab, GET /api/export-companies.csv.
Tests: tests/test_companies.py (store) and tests/fill_engine_check.js, run through node: every trade at every size it comes in is rolled 2,000 times and checked.

Not deployed. Needs a changelog-free review of the data by the owner.

🤖 Generated with Claude Code

Slice 1 of #1328 "Fill it in": the reviewed recipe data and a rating page, the way the name generator was done (#1257). Nothing in `webapp/` or `bot/` changes. - `static/fill-data.js`: jobs first (141 jobs, each with its trades, a title per trade, lowest size, traits, relative chance); 23 trades (the 22 from Q227 plus Magic & enchantments, flagged `magic`) with sizes, headcount, who runs it, required jobs, name patterns on the rolled owner's name, what-it-does lines, place needs; general traits, secrets, wants, fears, rumours; value tables for the suggested facts (generic, pf2e, dnd5e). - `static/fill-engine.js` and `static/companies.html`: roll a company (trade or Surprise me, size or any, magic switch, name style), rate the trade up or down with a note. - Names engine split out of `names.html` into `name-engine.js` (a mechanical move) so both pages draw from the same generators. - `app.py`: `companies` store (`PUT /api/responses/companies/<id>`, strict document, same share keys and source labels), admin tab, `GET /api/export-companies.csv`. - Tests: `tests/test_companies.py` (store) and `tests/fill_engine_check.js`, run through node: every trade at every size it comes in is rolled 2,000 times and checked. Not deployed. Needs a changelog-free review of the data by the owner. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 4 commits

2026-11-06 08:02:23 +00:00

refactor(feedback): split the names engine out of names.html so companies can reuse it 5b18837d5b

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

wip(feedback): the company recipes, their engine and the engine check (#1328 ) 0c13f128a9

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

wip(feedback): companies page, store, engine tests (#1328 ) 462a70c908

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

feat(feedback): Fill it in, slice 1: the recipes, to rate on the feedback site (#1328 )

CI / Backend lint (ruff) (pull_request) Successful in 35s

Details

CI / Does this change touch the recording path? (pull_request) Successful in 22s

Details

CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped

Details

CI / Bot/backend version sync (pull_request) Successful in 1m6s

Details

CI / Bot tests and audit (pull_request) Successful in 2m9s

Details

CI / Which journeys does this change need? (pull_request) Successful in 26s

Details

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 2m41s

Details

CI / Docker image build (pull_request) Successful in 2m23s

Details

CI / End-to-end journeys (desktop) (pull_request) Has been skipped

Details

CI / Frontend (shard 2/2) (pull_request) Successful in 9m33s

Details

CI / Feedback site tests (pull_request) Successful in 4m12s

Details

CI / Frontend (shard 1/2) (pull_request) Successful in 11m27s

Details

CI / Backend migration, tests, and audit (pull_request) Successful in 45m31s

Details

8916cb2321

Jobs-first recipe data (23 trades), a company roller page at /companies, a
companies rating store with admin readout and CSV, and an engine check that
rolls every trade and size 2,000 times. The names engine moves to
name-engine.js so both pages share it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request

2026-11-06 08:02:24 +00:00

Fill it in: roll a page's facts, and the people and places they point to, offline (generalises "a whole company") #1328

claude-bot commented

2026-11-06 08:28:41 +00:00

Author

Collaborator

Review notes (orchestrator), for the next round. Neither is blocking the owner's rating:

In-laws share the owner's surname. In a large Carter & shipper roll, "Herwin Todwell, Factor at the coast, the owner's in-law" has the owner's surname. An in-law would usually have their own family name. Relatives by marriage (in-law, spouse's sibling) should draw their own surname, and blood relatives (cousin, sibling's child) keep the shared one. The engine check's "kin share the surname" rule needs the same split.
The two what-it-does lines can say the same thing twice. "Barrel-staves along the coast… by cart and coaster" is followed by "Carries barrel-staves by road… and iron bars by water". Draw the second line from a different template group (who they serve, or how they're known) so the pair reads as two facts.

Not deployed. The feedback site gets this only on the owner's say.

**Review notes (orchestrator), for the next round. Neither is blocking the owner's rating:** 1. **In-laws share the owner's surname.** In a large Carter & shipper roll, "Herwin Todwell, Factor at the coast, the owner's in-law" has the owner's surname. An in-law would usually have their own family name. Relatives by marriage (in-law, spouse's sibling) should draw their own surname, and blood relatives (cousin, sibling's child) keep the shared one. The engine check's "kin share the surname" rule needs the same split. 2. **The two what-it-does lines can say the same thing twice.** "Barrel-staves along the coast… by cart and coaster" is followed by "Carries barrel-staves by road… and iron bars by water". Draw the second line from a different template group (who they serve, or how they're known) so the pair reads as two facts. Not deployed. The feedback site gets this only on the owner's say.

claude-bot merged commit 16d007aa03 into main

2026-11-06 21:03:46 +00:00

claude-bot referenced this pull request from a commit

2026-11-06 21:03:49 +00:00

Merge pull request 'Fill it in, slice 1: the recipes, to rate on the feedback site (#1328)' (#1354) from feat/1328-recipes into main

claude-bot referenced this pull request

2026-11-06 21:05:35 +00:00

Fill it in: roll a page's facts, and the people and places they point to, offline (generalises "a whole company") #1328