Settings → Notifications skips a heading level ("Per campaign" is an h3 under the h1) #1360

New issue

Closed

opened 2026-11-06 16:30:19 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-11-06 16:30:19 +00:00

Collaborator

Found by axe (heading-order, moderate) in the 2026-11-06 render checks of #1358. It's on main, not caused by that PR. webapp/frontend/src/pages/Notifications.jsx:318 renders <h3>Per campaign</h3> straight after the page's h1 ("Notifications"), skipping h2.

Fix: make it an h2, keeping its current look. Check whether the page's CSS or the design system styles h3 specifically, and carry that style over with a class if so. Then re-run axe on /profile/notifications at 390 and 1280 px; it should report no violations. While there, check the other Settings pages for the same skip.

Small, so v4.8.0.

Found by axe (`heading-order`, moderate) in the 2026-11-06 render checks of #1358. It's on main, not caused by that PR. `webapp/frontend/src/pages/Notifications.jsx:318` renders `<h3>Per campaign</h3>` straight after the page's `h1` ("Notifications"), skipping h2. Fix: make it an `h2`, keeping its current look. Check whether the page's CSS or the design system styles `h3` specifically, and carry that style over with a class if so. Then re-run axe on `/profile/notifications` at 390 and 1280 px; it should report no violations. While there, check the other Settings pages for the same skip. Small, so v4.8.0.

claude-bot added this to the v4.8.0 - A Living World Fills In milestone

2026-11-06 16:30:23 +00:00

claude-bot referenced this issue

2026-11-06 16:30:27 +00:00

The weekly email digest (#11) #1358

claude-bot referenced this issue from a pull request that will close it,

2026-11-07 00:56:09 +00:00

Settings → Notifications: "Per campaign" is an h2 (#1360) #1362

rbrooks referenced this issue from a commit

2026-11-07 00:56:11 +00:00

fix(webapp): Notifications' "Per campaign" is an h2, not an h3 under the h1 (#1360)

claude-bot closed this issue

2026-11-07 01:50:52 +00:00

claude-bot referenced this issue from a commit

2026-11-07 01:50:53 +00:00

Merge pull request 'Settings → Notifications: "Per campaign" is an h2 (#1360)' (#1362) from fix/1360-heading-order into main

claude-bot commented

2026-11-07 01:51:04 +00:00

Author

Collaborator

Done in #1362 (merged 2026-11-07, owner's approval). "Per campaign" is an h2 now and looks the same (render-checked), and axe is clean on /profile/notifications and /profile. Closing.

**Done in #1362 (merged 2026-11-07, owner's approval).** "Per campaign" is an h2 now and looks the same (render-checked), and axe is clean on `/profile/notifications` and `/profile`. Closing.