Settings → Notifications: "Per campaign" is an h2 (#1360) #1362

Merged

claude-bot merged 1 commit from fix/1360-heading-order into main 2026-11-07 01:50:52 +00:00

Conversation 1 Commits 1 Files changed 3 +6 -2

claude-bot commented 2026-11-07 00:56:09 +00:00

Collaborator

Copy link

Closes #1360. axe reported heading-order (moderate) on /profile/notifications: the page went from its h1 ("Notifications") straight to an h3 ("Per campaign").

• Notifications.jsx: <h3>Per campaign</h3> becomes <h2>.
• It looks the same:
  • ui/Doc/Doc.css's .sec > h2 already sets font-size: var(--step-2) (the h3 size) and margin-bottom: var(--sp-3) (as You.css gave the h3);
  • You.css now gives .nbox + h2 the same top space as .nbox + h3.
• Changelog: changelog.d/1360-notifications-heading.fixed.md.

Checks (docker-test, committed code):

• eslint is clean, and Notifications.test.jsx plus ui/NotifyGrid pass (24).
• Not done yet: a render check, to confirm the look is unchanged and axe is clean. I'll do it after the Pathbuilder frontend's render run, so the two don't share the journeys stack.

Profile also has h3s (Away, Other accounts, Download your data first), but axe didn't flag those pages in the earlier runs, and they may sit under section headings that render as h2. The render check will look there too.

🤖 Generated with Claude Code

Closes #1360. axe reported `heading-order` (moderate) on `/profile/notifications`: the page went from its `h1` ("Notifications") straight to an `h3` ("Per campaign"). - `Notifications.jsx`: `<h3>Per campaign</h3>` becomes `<h2>`. - **It looks the same:** - `ui/Doc/Doc.css`'s `.sec > h2` already sets `font-size: var(--step-2)` (the h3 size) and `margin-bottom: var(--sp-3)` (as `You.css` gave the h3); - `You.css` now gives `.nbox + h2` the same top space as `.nbox + h3`. - **Changelog:** `changelog.d/1360-notifications-heading.fixed.md`. **Checks (docker-test, committed code):** - eslint is clean, and `Notifications.test.jsx` plus `ui/NotifyGrid` pass (24). - **Not done yet:** a render check, to confirm the look is unchanged and axe is clean. I'll do it after the Pathbuilder frontend's render run, so the two don't share the journeys stack. Profile also has `h3`s (Away, Other accounts, Download your data first), but axe didn't flag those pages in the earlier runs, and they may sit under section headings that render as `h2`. The render check will look there too. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-11-07 00:56:09 +00:00

fix(webapp): Notifications' "Per campaign" is an h2, not an h3 under the h1 (#1360) ... b4fc2736ee

axe heading-order (moderate) on /profile/notifications: the page went
from its h1 straight to an h3. `.sec > h2` already gives an h2 the same
size as the h3 had, and You.css now gives it the same space above.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-11-07 01:49:37 +00:00

Author

Collaborator

Copy link

Render check (journeys stack, Priya, 2026-11-07):

• axe: no violations on /profile/notifications (390 light and dark, 1280 light) or /profile (390, 1280). heading-order is gone.
• Outline: notifications is now h1 Notifications → h2 Per campaign. Profile was already in order (h1 Profile → h2 sections → h3 Away, Other accounts, Download your data first). The other h3s are closed dialogs.
• Looks the same: "Per campaign" (h2) computes to 22 px Unbounded 600, 32 px above and 12 px below, the same as the h3 "Away".
• No sideways overflow and 0 console errors.

"Download your data first" has 12 px above it on purpose: it opens its section straight under the h2 ("a section that opens on a sub-heading has the section's own air above it already", in You.css). Ready to merge.

**Render check (journeys stack, Priya, 2026-11-07):** - **axe:** no violations on `/profile/notifications` (390 light and dark, 1280 light) or `/profile` (390, 1280). `heading-order` is gone. - **Outline:** notifications is now h1 Notifications → h2 Per campaign. Profile was already in order (h1 Profile → h2 sections → h3 Away, Other accounts, Download your data first). The other h3s are closed dialogs. - **Looks the same:** "Per campaign" (h2) computes to 22 px Unbounded 600, 32 px above and 12 px below, the same as the h3 "Away". - **No sideways overflow** and **0 console errors**. "Download your data first" has 12 px above it on purpose: it opens its section straight under the h2 ("a section that opens on a sub-heading has the section's own air above it already", in `You.css`). Ready to merge.

claude-bot merged commit e4b44d7c48 into main 2026-11-07 01:50:52 +00:00

claude-bot referenced this pull request from a commit 2026-11-07 01:50:53 +00:00

Merge pull request 'Settings → Notifications: "Per campaign" is an h2 (#1360)' (#1362) from fix/1360-heading-order into main

claude-bot referenced this pull request 2026-11-07 01:51:04 +00:00

Settings → Notifications skips a heading level ("Per campaign" is an h3 under the h1) #1360

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1362

No description provided.