Pathbuilder import, frontend: by code, paste, file or sheet PDF (#958) #1363

Merged

claude-bot merged 4 commits from feat/958-pathbuilder-import-frontend into main 2026-11-07 02:31:03 +00:00

Conversation 0 Commits 4 Files changed 13 +1028 -7

claude-bot commented 2026-11-07 01:39:23 +00:00

Collaborator

Copy link

Frontend for the Pathbuilder import (#958, IS-429); the backend is #1361.

What it does

"Import from Pathbuilder…" opens one dialog with three ways in: Code (default; the browser fetches https://pathbuilder2e.com/json.php?id=<code>, 15 s timeout, digits-only check first), Paste or file (pasted JSON or a .json file), Character sheet PDF. A fetch that fails for any reason (network, CORS, challenge page, success:false) shows the link, switches to Paste and keeps the code as provenance. The preview saves nothing: name, class, level, what will happen (create / update / replace, the last behind a checkbox), Not read (always shown, with reasons), warnings, matched vs kept-as-text entries, numbers that differ from Pathbuilder's, and for update/replace the changes. Import saves with commit=1&expected_version=<previewed version>; a stale 409 hands the page the current sheet and previews again; 503 says busy with Try again; success closes the dialog and the sheet shows an "Imported from Pathbuilder" banner.

Entry points

• A Pathfinder 2e character's sheet: More menu, after Export and Print (only for someone who can edit that sheet).
• A player character's page with no sheet: a button beside Make a sheet (SheetPage.jsx, the no-sheet branch).

Where the drawing and the brief differ: the drawing (lane9.html pathbuilder()) shows only a paste box and a one-line summary; the code, PDF, report and confirm flow follow the brief. The server's warning about differing numbers is not repeated under Warnings, since "Numbers that differ" lists the same figures.

CSP

webapp/frontend/nginx.conf: connect-src 'self' becomes connect-src 'self' https://pathbuilder2e.com; nothing else changed. No test or e2e file asserts the header. docs/API.md said the origin must be allowed; its sentence now says it is. I built the frontend-prod image and ran it; curl -I returns
Content-Security-Policy: default-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'; img-src 'self'; connect-src 'self' https://pathbuilder2e.com; font-src 'self'; frame-ancestors 'none'.

Wording for review

• Import from Pathbuilder… (menu item, button); Import from Pathbuilder (dialog title); banner title "Imported from Pathbuilder"
• Tabs: Code · Paste or file · Character sheet PDF
• Pathbuilder code; hint: "In Pathbuilder: Menu, Export, Export JSON. It gives a code of six digits."
• Paste the JSON · Or choose a .json file · Character sheet PDF; hint: "The PDF Pathbuilder fills in for the official Pathfinder 2e sheet."
• Buttons: Read it · Cancel · Back · Import · Update the sheet · Replace the sheet · Dismiss
• Fallback: "Couldn’t fetch it from Pathbuilder. Open this link, then paste what it shows."
• Errors: "Enter the code as digits only, like 484225." · "Paste the JSON first." · "That isn't valid JSON. Paste all of it, from the first { to the last }." · "Choose the PDF first." · "Quest Board is busy reading other files. Try again in a moment." · other server messages shown as sent
• Preview: "This page has no sheet yet. Importing makes it from this build." · "This sheet came from this Pathbuilder character. Importing updates it; the earlier state stays in its history." · "This page’s sheet didn’t come from this Pathbuilder character. Importing replaces what the build covers; the earlier state stays in the sheet’s history." · checkbox "Replace this page’s sheet" · disabled reason "Confirm replacing the sheet first."
• Sections: Not read (n) · Warning / Warnings · Numbers that differ ("AC: Pathbuilder 23, Quest Board 21"; "Differences usually mean rules content Quest Board doesn’t have.") · What changes (n) ("Level: 5 → 6") · Feats, items and spells ("n matched to the loaded content, m kept as text.", "See all n") · "Read: n field(s)"
• "The sheet changed while you were looking. This is what the import would change now."
• Banner body: " is on this sheet now."
• Screen-reader status: "Reading…"; "What you typed is not saved yet. Save it first, then import."

Checks (docker-test, committed code via git archive)

• eslint: 0 errors (48 existing warnings, none in these files)
• vitest: new ImportPathbuilder.test.jsx (28 tests) plus 2 new and 1 updated in SheetPage.test.jsx; full suite with --maxWorkers=3: 294 files, 5792 passed, 1 skipped
• build suite: frontend-prod image built; CSP header checked as above
• Render check on the seeded journeys stack (desktop project, canned Pathbuilder and import responses through Playwright routes, so the browser fetch went through the built CSP): dark and light at 1280 and 390; code, bad code, fallback, preview and the Read list open. The preview heading took focus, and neither the page nor the dialog overflowed sideways. Screenshots are not attached; someone should look at them.

Not covered: a real Pathbuilder fetch (their server was mocked), a real PDF upload through the stack, and the replace flow on the built stack (unit-tested only).

Also: CATALOGUE IS-429 row extended; changelog fragment changelog.d/958-pathbuilder-import-frontend.added.md.

🤖 Generated with Claude Code

Frontend for the Pathbuilder import (#958, IS-429); the backend is #1361. ## What it does "Import from Pathbuilder…" opens one dialog with three ways in: **Code** (default; the browser fetches `https://pathbuilder2e.com/json.php?id=<code>`, 15 s timeout, digits-only check first), **Paste or file** (pasted JSON or a .json file), **Character sheet PDF**. A fetch that fails for any reason (network, CORS, challenge page, `success:false`) shows the link, switches to Paste and keeps the code as provenance. The preview saves nothing: name, class, level, what will happen (create / update / replace, the last behind a checkbox), Not read (always shown, with reasons), warnings, matched vs kept-as-text entries, numbers that differ from Pathbuilder's, and for update/replace the changes. Import saves with `commit=1&expected_version=<previewed version>`; a stale 409 hands the page the current sheet and previews again; 503 says busy with Try again; success closes the dialog and the sheet shows an "Imported from Pathbuilder" banner. ## Entry points - A Pathfinder 2e character's sheet: **More** menu, after Export and Print (only for someone who can edit that sheet). - A player character's page with no sheet: a button beside **Make a sheet** (`SheetPage.jsx`, the no-sheet branch). Where the drawing and the brief differ: the drawing (lane9.html `pathbuilder()`) shows only a paste box and a one-line summary; the code, PDF, report and confirm flow follow the brief. The server's warning about differing numbers is not repeated under Warnings, since "Numbers that differ" lists the same figures. ## CSP `webapp/frontend/nginx.conf`: `connect-src 'self'` becomes `connect-src 'self' https://pathbuilder2e.com`; nothing else changed. No test or e2e file asserts the header. `docs/API.md` said the origin must be allowed; its sentence now says it is. I built the `frontend-prod` image and ran it; `curl -I` returns `Content-Security-Policy: default-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'; img-src 'self'; connect-src 'self' https://pathbuilder2e.com; font-src 'self'; frame-ancestors 'none'`. ## Wording for review - Import from Pathbuilder… (menu item, button); Import from Pathbuilder (dialog title); banner title "Imported from Pathbuilder" - Tabs: Code · Paste or file · Character sheet PDF - Pathbuilder code; hint: "In Pathbuilder: Menu, Export, Export JSON. It gives a code of six digits." - Paste the JSON · Or choose a .json file · Character sheet PDF; hint: "The PDF Pathbuilder fills in for the official Pathfinder 2e sheet." - Buttons: Read it · Cancel · Back · Import · Update the sheet · Replace the sheet · Dismiss - Fallback: "Couldn’t fetch it from Pathbuilder. Open this link, then paste what it shows." - Errors: "Enter the code as digits only, like 484225." · "Paste the JSON first." · "That isn't valid JSON. Paste all of it, from the first { to the last }." · "Choose the PDF first." · "Quest Board is busy reading other files. Try again in a moment." · other server messages shown as sent - Preview: "This page has no sheet yet. Importing makes it from this build." · "This sheet came from this Pathbuilder character. Importing updates it; the earlier state stays in its history." · "This page’s sheet didn’t come from this Pathbuilder character. Importing replaces what the build covers; the earlier state stays in the sheet’s history." · checkbox "Replace this page’s sheet" · disabled reason "Confirm replacing the sheet first." - Sections: Not read (n) · Warning / Warnings · Numbers that differ ("AC: Pathbuilder 23, Quest Board 21"; "Differences usually mean rules content Quest Board doesn’t have.") · What changes (n) ("Level: 5 → 6") · Feats, items and spells ("n matched to the loaded content, m kept as text.", "See all n") · "Read: n field(s)" - "The sheet changed while you were looking. This is what the import would change now." - Banner body: "<name> is on this sheet now." - Screen-reader status: "Reading…"; "What you typed is not saved yet. Save it first, then import." ## Checks (docker-test, committed code via git archive) - eslint: 0 errors (48 existing warnings, none in these files) - vitest: new `ImportPathbuilder.test.jsx` (28 tests) plus 2 new and 1 updated in `SheetPage.test.jsx`; full suite with `--maxWorkers=3`: 294 files, 5792 passed, 1 skipped - `build` suite: frontend-prod image built; CSP header checked as above - Render check on the seeded journeys stack (desktop project, canned Pathbuilder and import responses through Playwright routes, so the browser fetch went through the built CSP): dark and light at 1280 and 390; code, bad code, fallback, preview and the Read list open. The preview heading took focus, and neither the page nor the dialog overflowed sideways. Screenshots are not attached; someone should look at them. Not covered: a real Pathbuilder fetch (their server was mocked), a real PDF upload through the stack, and the replace flow on the built stack (unit-tested only). Also: CATALOGUE `IS-429` row extended; changelog fragment `changelog.d/958-pathbuilder-import-frontend.added.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-11-07 01:39:23 +00:00

feat(webapp): Pathbuilder import, frontend (#958) ... f15279d8ce

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: fix entry list query (#958) f801a27d22

fix(webapp): a dash before each not-read reason (#958) ... 19a36786ff

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-11-07 01:43:30 +00:00

fix(webapp): the import preview doesn't list a value that reads the same as a change (#958) ... 7d036073ed

A value whose stored form differs but which shows the same (5 and "5",
None and "") appeared as "Rogue → Rogue". The Changes list now
compares what it prints.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 8546ca7065 into main 2026-11-07 02:31:03 +00:00

claude-bot referenced this pull request from a commit 2026-11-07 02:31:05 +00:00

Merge pull request 'Pathbuilder import, frontend: by code, paste, file or sheet PDF (#958)' (#1363) from feat/958-pathbuilder-import-frontend into main

claude-bot referenced this pull request 2026-11-07 02:31:11 +00:00

Character sheets phase 2: Foundry both ways, Pathbuilder in, conversion, Update to version n #958

rbrooks referenced this pull request from a commit 2026-11-07 05:14:21 +00:00

Merge main into feat/958-convert-sheet

claude-bot referenced this pull request 2026-11-07 08:22:38 +00:00

Character sheets phase 2: Foundry both ways, Pathbuilder in, conversion, Update to version n #958

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1363

No description provided.