[Workbench] Generated output is lost when switching tools or leaving the page, and "Re-open" from history doesn't restore it

claude-bot commented

2026-08-12 00:45:11 +00:00

Collaborator

Symptom

A generated Session Prep sheet disappears if you switch to another Workbench tool (or navigate away) and come back. Reported during real session prep — the sheet is gone and has to be regenerated, which costs another async LLM run.

Cause

Output lives only in GeneratorPanel component state (GeneratorPanel.jsx:177-183), and the panel is deliberately unmounted on every tool switch — CampaignPlanning renders only the active tool and keys the panel by toolId (CampaignPlanning.jsx:884-891), with a belt-and-braces reset effect at GeneratorPanel.jsx:186-196. activeToolId is page state, so a route change loses it too.

The result is persisted server-side — generation_results rows, surfaced in the history rail — so nothing is actually lost, but there's no way back to it. The "Re-open" action only switches the active tool; it never rehydrates the output (CampaignPlanning.jsx:858-863):

const handleReopen = useCallback((result) => {
  if (result?.tool_id && WORKBENCH_REOPEN_TOOL_IDS.has(result.tool_id)) {
    setActiveToolId(result.tool_id);   // ← switches tool, discards result.output
  }
}, []);

So "Re-open" lands the GM on an empty panel, which reads as the same bug.

Proposed fix

Smallest useful change: make handleReopen actually reopen — pass the history row's id/output into GeneratorPanel as an initial result (plus params to rehydrate the input values), so clicking "Re-open" restores the sheet. That alone recovers everything, since results are already persisted.

Optionally on top of that, restore the last run per tool on mount (GET the latest generation_results row for (campaign_id, tool_id)), so the panel repopulates on a plain tool switch without a trip through the history rail. Worth confirming that's desirable — an auto-restored stale result can be confusing if the target session has changed since; if so, gate it on the params still matching the current selection.

Same session-prep report as the session-picker default and beat-notes round-trip issues.

## Symptom A generated Session Prep sheet disappears if you switch to another Workbench tool (or navigate away) and come back. Reported during real session prep — the sheet is gone and has to be regenerated, which costs another async LLM run. ## Cause Output lives only in `GeneratorPanel` component state ([GeneratorPanel.jsx:177-183](webapp/frontend/src/components/GeneratorPanel.jsx#L177-L183)), and the panel is deliberately unmounted on every tool switch — `CampaignPlanning` renders only the active tool and keys the panel by `toolId` ([CampaignPlanning.jsx:884-891](webapp/frontend/src/pages/CampaignPlanning.jsx#L884-L891)), with a belt-and-braces reset effect at [GeneratorPanel.jsx:186-196](webapp/frontend/src/components/GeneratorPanel.jsx#L186-L196). `activeToolId` is page state, so a route change loses it too. The result *is* persisted server-side — `generation_results` rows, surfaced in the history rail — so nothing is actually lost, but there's no way back to it. The "Re-open" action only switches the active tool; it never rehydrates the output ([CampaignPlanning.jsx:858-863](webapp/frontend/src/pages/CampaignPlanning.jsx#L858-L863)): ```js const handleReopen = useCallback((result) => { if (result?.tool_id && WORKBENCH_REOPEN_TOOL_IDS.has(result.tool_id)) { setActiveToolId(result.tool_id); // ← switches tool, discards result.output } }, []); ``` So "Re-open" lands the GM on an empty panel, which reads as the same bug. ## Proposed fix Smallest useful change: make `handleReopen` actually reopen — pass the history row's `id`/`output` into `GeneratorPanel` as an initial result (plus `params` to rehydrate the input `values`), so clicking "Re-open" restores the sheet. That alone recovers everything, since results are already persisted. Optionally on top of that, restore the last run per tool on mount (`GET` the latest `generation_results` row for `(campaign_id, tool_id)`), so the panel repopulates on a plain tool switch without a trip through the history rail. Worth confirming that's desirable — an auto-restored stale result can be confusing if the target session has changed since; if so, gate it on the params still matching the current selection. ## Related Same session-prep report as the session-picker default and beat-notes round-trip issues.

claude-bot referenced this issue

2026-08-12 00:45:45 +00:00

[Workbench] Session pickers default to the furthest-out session, not the next one #302

claude-bot referenced this issue

2026-08-12 00:45:48 +00:00

[Workbench] Beat notes never reach the frontend — "Append to beat notes" silently replaces, and Beat Planner can wipe saved notes #303

claude-bot commented

2026-08-12 00:45:50 +00:00

Author

Collaborator

Cluster cross-reference — all four came out of the same session-prep run on 2026-08-11:

#302 — session pickers default to the furthest-out session
#303 — beat notes round-trip / append-is-really-replace / Beat Planner wipe
#304 (this) — generated output lost on tool switch; "Re-open" doesn't restore it
#305 — prep sheet regurgitates last session; no working channel for GM intent

This one is independent of the other three and can land on its own.

Cluster cross-reference — all four came out of the same session-prep run on 2026-08-11: - **#302** — session pickers default to the furthest-out session - **#303** — beat notes round-trip / append-is-really-replace / Beat Planner wipe - **#304** (this) — generated output lost on tool switch; "Re-open" doesn't restore it - **#305** — prep sheet regurgitates last session; no working channel for GM intent This one is independent of the other three and can land on its own.

claude-bot referenced this issue

2026-08-12 00:45:53 +00:00

[Workbench] Session Prep sheet regurgitates the last session — no working channel for GM intent about the upcoming one #305

claude-bot referenced this issue

2026-08-25 19:18:25 +00:00

[Review] Full audit of the session lifecycle: prep, recording, transcription, summarization, lore — scoping v4.0.0 #319

claude-bot added this to the v4.3.0 - Product Surface: Navigation, Attention & Feedback milestone

2026-08-25 20:39:59 +00:00

claude-bot referenced this issue

2026-08-25 20:42:14 +00:00

[Frontend] Fix the GM Workbench: buried entry point, wrong default tool, unreadable session picker, and dead-end outputs #374

claude-bot referenced this issue

2026-09-06 00:34:01 +00:00

v4.3.0 build order: Product Surface in eight phases #514

claude-bot referenced this issue

2026-09-06 04:05:41 +00:00

[Workbench] Session pickers default to the furthest-out session, not the next one #302

claude-bot commented

2026-09-06 04:05:45 +00:00

Author

Collaborator

Picking this up as v4.3.0 phase 3 (#514). "Re-open" will pass the stored row's output and params into the panel so it actually restores the sheet, and the last run per tool is restored on mount only when its params still match the current selection, so a stale sheet for a different session never appears.

rbrooks referenced this issue from a commit

2026-09-06 05:49:49 +00:00

fix(frontend): Re-open actually re-opens, and a run survives a tool switch (#304)

claude-bot referenced this issue from a pull request that will close it,

2026-09-06 05:50:12 +00:00

feat(webapp): the Prep lane: pickers, notes, re-open, a steerable sheet, a front door, and clocks (phase 3 of v4.3.0) #528

claude-bot commented

2026-09-06 05:50:29 +00:00

Author

Collaborator

Done in the phase 3 PR (auto-merging on green); ships with v4.3.0.

Configs gain restore: { toValues, matches }, because only the tool knows how to invert its own buildParams. "Re-open" now hands the row to the panel as initialRun, keyed by run id so a second Re-open remounts and re-seeds rather than leaving the first sheet on screen. On mount, a panel asks history for its tool's newest ready run and restores it only if matches says it is still about what the panel is pointed at.

Two judgement calls: matches is declared only for the session-keyed tools, since for a free-text tool there is no "current selection" to compare against and any predicate would either never fire or resurrect a stale sheet; and session_prep / series_titles return null from toValues when the run's session is no longer one the picker offers, because every action on a prep sheet writes to the session it names, so a sheet shown against the wrong one is worse than no sheet.

Known limitation, documented at the top of workbenchTools.jsx: wiki-article grounding is not restored. A run records entry_id / entry_ids; a picker's value is the entry object it renders the title from, and there is nothing to hydrate that from at mount. A grounded run reopens with its output intact and the grounding cleared.

Done in the phase 3 PR (auto-merging on green); ships with v4.3.0. Configs gain `restore: { toValues, matches }`, because only the tool knows how to invert its own `buildParams`. "Re-open" now hands the row to the panel as `initialRun`, keyed by run id so a second Re-open remounts and re-seeds rather than leaving the first sheet on screen. On mount, a panel asks history for its tool's newest ready run and restores it **only if `matches` says it is still about what the panel is pointed at**. Two judgement calls: `matches` is declared only for the session-keyed tools, since for a free-text tool there is no "current selection" to compare against and any predicate would either never fire or resurrect a stale sheet; and `session_prep` / `series_titles` return `null` from `toValues` when the run's session is no longer one the picker offers, because every action on a prep sheet writes to the session it names, so a sheet shown against the wrong one is worse than no sheet. Known limitation, documented at the top of `workbenchTools.jsx`: **wiki-article grounding is not restored.** A run records `entry_id` / `entry_ids`; a picker's value is the entry *object* it renders the title from, and there is nothing to hydrate that from at mount. A grounded run reopens with its output intact and the grounding cleared.

claude-bot closed this issue

2026-09-06 06:05:18 +00:00

claude-bot referenced this issue

2026-09-06 09:30:26 +00:00

chore(release): v4.3.0 #533

Rows
Columns

[Workbench] Generated output is lost when switching tools or leaving the page, and "Re-open" from history doesn't restore it #304

Symptom

Cause

Proposed fix

Related