feat(webapp): the server's owner, offers, About, the campaigns' and audit log's names, and Admin's overview (lane 9 A) #855

Merged

claude-bot merged 3 commits from build/lane9-a-owner-overview into main 2026-09-26 22:50:33 +00:00

Conversation 0 Commits 3 Files changed 25 +3008 -33

claude-bot commented 2026-09-26 19:10:08 +00:00

Collaborator

Copy link

Lane 9 (#735), server PR A: the owner's D140–D142 (A3, A4 and A5) and D148 (A11). No pages; those are 4a–4d.

The server's owner (D68, D140, D141)

Migration f1a3c5e7b9d2 (on c4e6a8b0d2f1) adds:

• users.is_server_owner, with a partial unique index so there's at most one owner;
• a server_ownership_offers table (one open offer at a time);
• the notification kinds server_ownership_offer and campaign_handed_on.

Backfill (A3): the owner is whoever finished setup, if they're still an admin. Failing that, it's the earliest admin, and failing that, nobody.

Guards:

• An admin can't remove the owner's admin status: 409, "Hand the server on first".
• The owner can't be deleted, either by an admin or through /me. This comes on top of #837's last-admin guard.

Offers (A4):

• Endpoints: offer, accept, decline and cancel, plus GET /admin/server-owner.
• Offers lapse after 7 days, checked lazily, and the owner hears the outcome.
• The offer rings the bell. The "Needs you" item is deferred to page 4a, because AttentionItem needs a server-level kind first.

Vanished owner: CLI python -m app.cli set_owner --email|--oidc-sub/--oidc-issuer, documented in docs/OPERATIONS.md.

UserResponse.is_server_owner is added.

Also

• D56: PUT /admin/settings/member-search-scope.
• About: GET|PUT /admin/settings/about.
  • The contact is split into an email and a link, by shape.
  • Saving resets the public numbers cache.
  • Changes are audited.
• Campaigns:
  • the list gains delivery_failing_since, owner_last_seen_at and uses_own_ai;
  • new GET /admin/campaigns/{id}/members;
  • a hand-on notifies both owners.
• Audit log:
  • filters by actor and campaign name, and by category;
  • responses carry actor_name (with "The system" for events no user triggered), campaign_name and target_label, resolved with two queries per page.
• GET /admin/overview (A5, D142): a single request with cheap reads only, including the skipped setup steps with their section keys. The bot status is cached for 60 s, with a 2 s timeout.

Tests

• New tests: test_server_owner.py and test_server_owner_migration.py, the latter covering the backfill cases, the CHECKs, and up, down and up.
• 115 targeted tests pass, plus a wider regression pass (447 in total).
• Migration: up, down and up on real Postgres 16.
• ruff: clean.

Merge notes

• B2 (another in-flight PR) also adds a migration on c4e6. Whichever merges second gets re-chained.
• After #854, the new Depends(get_db) uses here are converted to scope="function" at merge.

🤖 Generated with Claude Code

Lane 9 (#735), server PR A: the owner's D140–D142 (A3, A4 and A5) and D148 (A11). No pages; those are 4a–4d. ## The server's owner (D68, D140, D141) **Migration `f1a3c5e7b9d2`** (on `c4e6a8b0d2f1`) adds: - `users.is_server_owner`, with a partial unique index so there's at most one owner; - a `server_ownership_offers` table (one open offer at a time); - the notification kinds `server_ownership_offer` and `campaign_handed_on`. **Backfill (A3):** the owner is whoever finished setup, if they're still an admin. Failing that, it's the earliest admin, and failing that, nobody. **Guards:** - An admin can't remove the owner's admin status: 409, "Hand the server on first". - The owner can't be deleted, either by an admin or through `/me`. This comes on top of #837's last-admin guard. **Offers (A4):** - Endpoints: offer, accept, decline and cancel, plus `GET /admin/server-owner`. - Offers lapse after 7 days, checked lazily, and the owner hears the outcome. - The offer rings the bell. The "Needs you" item is **deferred to page 4a**, because `AttentionItem` needs a server-level kind first. **Vanished owner:** CLI `python -m app.cli set_owner --email|--oidc-sub/--oidc-issuer`, documented in `docs/OPERATIONS.md`. **`UserResponse.is_server_owner`** is added. ## Also - **D56:** `PUT /admin/settings/member-search-scope`. - **About:** `GET|PUT /admin/settings/about`. - The contact is split into an email and a link, by shape. - Saving resets the public numbers cache. - Changes are audited. - **Campaigns:** - the list gains `delivery_failing_since`, `owner_last_seen_at` and `uses_own_ai`; - new `GET /admin/campaigns/{id}/members`; - a hand-on notifies both owners. - **Audit log:** - filters by `actor` and `campaign` name, and by `category`; - responses carry `actor_name` (with "The system" for events no user triggered), `campaign_name` and `target_label`, resolved with two queries per page. - **`GET /admin/overview` (A5, D142):** a single request with cheap reads only, including the skipped setup steps with their section keys. The bot status is cached for 60 s, with a 2 s timeout. ## Tests - **New tests:** `test_server_owner.py` and `test_server_owner_migration.py`, the latter covering the backfill cases, the CHECKs, and up, down and up. - **115 targeted tests pass,** plus a wider regression pass (447 in total). - **Migration:** up, down and up on real Postgres 16. - **ruff:** clean. ## Merge notes - **B2** (another in-flight PR) also adds a migration on `c4e6`. Whichever merges second gets re-chained. - **After #854,** the new `Depends(get_db)` uses here are converted to `scope="function"` at merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-09-26 19:10:08 +00:00

feat(webapp): the server has an owner (D68, IS-397, lane 9 A) ... b2293c526d

Migration f1a3c5e7b9d2 adds users.is_server_owner (partial unique index)
and server_ownership_offers, backfilled from the earliest
admin.setup.finished actor if still an admin, otherwise the
earliest-created admin, otherwise nobody. The owner cannot be demoted,
deleted, or delete their own account without handing the server on
first; the offer flow mirrors a campaign's own (offer/accept/decline/
cancel, a bell notification, the outcome told to the previous owner);
the CLI set_owner moves ownership without an offer for a vanished
owner.

Also in this PR: D56's member-search-scope write, About this server's
GET/PUT, the admin campaign list's delivery_failing_since/
owner_last_seen_at/uses_own_ai fields plus a members read for the
hand-on picker, notifying both owners on an admin's campaign
reassignment (campaign_handed_on), the audit log's name filters
(actor/campaign/category) and per-page name resolution, and one cheap
GET /admin/overview for the future Admin index.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-09-26 20:00:13 +00:00

feat(webapp): no Discord token in Admin, Tests on typed values, prices, images in the backup, the cap preview, a queue verdict (lane 9 B2) #859

rbrooks referenced this pull request from a commit 2026-09-26 20:50:00 +00:00

Merge origin/main into lane 9 A (#855): scope="function" for the branch's get_db, and the inventory's metadata keys

rbrooks added 1 commit 2026-09-26 20:50:00 +00:00

Merge origin/main into lane 9 A (#855): scope="function" for the branch's get_db, and the inventory's metadata keys ... 41bbc62c51

- CHANGELOG: kept lane 9 A's entry and main's D131-D178 line.
- Every Depends(get_db) the branch adds in admin.py and users.py is now
  scope="function" (#854), so test_commit_before_response's walk passes.
- test_admin_campaign_inventory: EXPECTED_KEYS gains delivery_failing_since,
  owner_last_seen_at and uses_own_ai, each commented as metadata rather
  than campaign content.

f1a3c5e7b9d2 already sat on c4e6a8b0d2f1; one head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks referenced this pull request from a commit 2026-09-26 21:46:32 +00:00

fix(webapp): a server handover clears the old owner before setting the new (#855)

rbrooks added 1 commit 2026-09-26 21:46:33 +00:00

fix(webapp): a server handover clears the old owner before setting the new (#855) ... 7d12eb3be0

uq_users_one_server_owner is a partial unique index, checked row by row and
not deferrable, and one flush writes both rows in primary-key order - so the
handover failed whenever the new owner's id sorted first (CI hit it; local runs
happened not to). The CLI's set_owner no longer clears its own target either.
A parametrized test forces both id orders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 130936d215 into main 2026-09-26 22:50:33 +00:00

claude-bot referenced this pull request from a commit 2026-09-26 22:50:35 +00:00

Merge PR #855: the server's owner, offers, About, names in the audit log, and Admin's overview (lane 9 A)

rbrooks referenced this pull request from a commit 2026-09-26 23:11:16 +00:00

feat(webapp): Admin's frame, index, About, Users and Campaigns (D21, lane 9 page 4a, #735)

rbrooks referenced this pull request from a commit 2026-09-26 23:18:57 +00:00

fix(webapp): the bell knows lane 9's two ownership kinds (#846)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!855

No description provided.