A handout revealed to a player can't be listed or opened by her (lane 8 PR 5 server gap) #916

New issue

Closed

opened 2026-09-28 17:09:24 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-09-28 17:09:24 +00:00

Collaborator

Found building lane 8 P6 (Handouts, WIKI-14, #734).

The problem. A GM's handout is a document page that starts at audience gm (prep). Revealing it (shelf_reveals, with an audience of table, party or chosen) lets the player download the file through /api/campaigns/{cid}/files/{id}, but:

the reveal doesn't widen what she can read of the page, so GET /lore/{id} is a 404 for her, and it doesn't show in search or the wiki lists;
there is no "handouts I'm inside" collection (survey §3.8), so her Handouts page can only list document pages whose own audience includes her.

So as built, a player can't see the handouts shown to her, which is their whole purpose.

What's needed (server):

Reading a page: a live (not taken back) reveal whose audience covers the viewer grants read of that handout page, rendered for her audience, so GM blocks stay hidden. Taking the reveal back removes it again.
GET /api/campaigns/{cid}/handouts for a player, listing the handouts revealed to her grouped by session (null session means "between sessions", per W8), with piece labels.
A player creating a handout sets the page's audience to herself plus the GMs (§3.8). Today it's table-visible.
Optionally, add source_reference_entry_id to LoreEntryResponse (IS-123, "Based on rules entry …").

Tests (as Priya): revealed to her, she can read the page and it's listed; taken back, it's a 404 again and gone from the list; revealed to someone else, it's a 404; a GM block inside is never sent to her.

Part of #734.

Found building lane 8 P6 (Handouts, WIKI-14, #734). **The problem.** A GM's handout is a `document` page that starts at audience `gm` (prep). Revealing it (`shelf_reveals`, with an audience of table, party or chosen) lets the player **download** the file through `/api/campaigns/{cid}/files/{id}`, but: - the reveal doesn't widen what she can read of the **page**, so `GET /lore/{id}` is a 404 for her, and it doesn't show in search or the wiki lists; - there is no **"handouts I'm inside"** collection (survey §3.8), so her Handouts page can only list `document` pages whose own audience includes her. So as built, a player can't see the handouts shown to her, which is their whole purpose. **What's needed (server):** 1. Reading a page: a live (not taken back) reveal whose audience covers the viewer grants read of that handout page, rendered for her audience, so GM blocks stay hidden. Taking the reveal back removes it again. 2. `GET /api/campaigns/{cid}/handouts` for a player, listing the handouts revealed to her grouped by session (null session means "between sessions", per W8), with piece labels. 3. A player creating a handout sets the page's audience to herself plus the GMs (§3.8). Today it's table-visible. 4. Optionally, add `source_reference_entry_id` to `LoreEntryResponse` (IS-123, "Based on rules entry …"). **Tests (as Priya):** revealed to her, she can read the page and it's listed; taken back, it's a 404 again and gone from the list; revealed to someone else, it's a 404; a GM block inside is never sent to her. Part of #734.

claude-bot referenced this issue from a pull request that will close it,

2026-09-29 02:21:56 +00:00

Lane 8 page P6: Handouts and Rules & bestiary; a reveal opens a handout to read (WIKI-14, WIKI-15, #916) #920

claude-bot closed this issue

2026-09-29 06:08:28 +00:00

claude-bot referenced this issue from a commit

2026-09-29 06:08:29 +00:00

feat(webapp): a handout reveal opens the page to read; GET /handouts (#916)

claude-bot referenced this issue from a commit

2026-09-29 06:08:29 +00:00

Merge PR #920: lane 8 page P6, Handouts and Rules & bestiary; a reveal opens a handout to read (#916)

claude-bot referenced this issue