Lane 8 page P6: Handouts and Rules & bestiary; a reveal opens a handout to read (WIKI-14, WIKI-15, #916) #920

Merged

claude-bot merged 8 commits from build/lane8-p6-handouts-rules into main 2026-09-29 06:08:27 +00:00

Conversation 0 Commits 8 Files changed 18 +2653 -12

claude-bot commented 2026-09-29 02:21:55 +00:00

Collaborator

Copy link

Lane 8 page P6 (#734), plus the server gap it found (#916).

Pages

• Handouts (/wiki/handouts): the GM's handouts by session with who each went to, unshown ones first as prep, and reveals outside play under "Between sessions". Show it picks the audience (characters first), posts to Discord unless switched off (D61), says when, and names the piece of a letter shown in parts. Take it back uses the server's revoke route. A player sees what was shown to her, by session, from GET /handouts.
• A handout's page shows its file (image, PDF with Download, or text), always through the authorised files route, never /media/.
• Rules & bestiary (/wiki/rules): search the loaded packs; rules open with their source, creatures as a stat block; a GM can Make it ours. Licence lines at the foot; an empty state when no pack is loaded.

Server (#916). A live reveal covering a player opens that handout's page to read and its file list, and nothing else: no lists, search, feeds or writes. It's rendered for her, so GM blocks never reach her, and can_edit is forced off. Taking the reveal back closes it on the next request. GET /api/campaigns/{cid}/handouts lists what was shown to the reader, grouped by session. A player's own handout may use audience mine (hers and the GMs'); no other page may. LoreEntryResponse gains source_reference_entry_id (IS-123). No migration.

Checked

• Frontend lint, 2712 tests and the build pass. Ruff is clean. Backend full suite: 5826 passed, 1 failed, which is test_needs_you_asks_again_after_a_move. That test fails on every Tuesday on main too and is fixed in #919.
• Render check, real 390×844 and 1440×900 in the e2e stack, light and dark, as Dana and Priya: 48 of 48 shots have no sideways scroll. The phone Show it dialog keeps Cancel and Show it in view while scrolled, and a real submit from a phone works. I looked at the shots myself.
• File gates: GM prep gives Priya a 404; revealed to her character, 200 with private, no-store; taken back, 404; /media/private/* and /internal-files/* are 404.
• Found in passing, not P6's: #918 (the audience menu swallows the next click).

Closes #916. Part of #734.

🤖 Generated with Claude Code

Lane 8 page P6 (#734), plus the server gap it found (#916). **Pages** - **Handouts** (`/wiki/handouts`): the GM's handouts by session with who each went to, unshown ones first as prep, and reveals outside play under "Between sessions". **Show it** picks the audience (characters first), posts to Discord unless switched off (D61), says when, and names the piece of a letter shown in parts. **Take it back** uses the server's revoke route. A player sees what was shown to her, by session, from `GET /handouts`. - **A handout's page** shows its file (image, PDF with Download, or text), always through the authorised files route, never `/media/`. - **Rules & bestiary** (`/wiki/rules`): search the loaded packs; rules open with their source, creatures as a stat block; a GM can **Make it ours**. Licence lines at the foot; an empty state when no pack is loaded. **Server (#916).** A live reveal covering a player opens that handout's page to read and its file list, and nothing else: no lists, search, feeds or writes. It's rendered for her, so GM blocks never reach her, and `can_edit` is forced off. Taking the reveal back closes it on the next request. `GET /api/campaigns/{cid}/handouts` lists what was shown to the reader, grouped by session. A player's own handout may use audience `mine` (hers and the GMs'); no other page may. `LoreEntryResponse` gains `source_reference_entry_id` (IS-123). No migration. **Checked** - Frontend lint, 2712 tests and the build pass. Ruff is clean. Backend full suite: 5826 passed, 1 failed, which is `test_needs_you_asks_again_after_a_move`. That test fails on every Tuesday on main too and is fixed in #919. - Render check, real 390×844 and 1440×900 in the e2e stack, light and dark, as Dana and Priya: 48 of 48 shots have no sideways scroll. The phone Show it dialog keeps Cancel and Show it in view while scrolled, and a real submit from a phone works. I looked at the shots myself. - File gates: GM prep gives Priya a 404; revealed to her character, 200 with `private, no-store`; taken back, 404; `/media/private/*` and `/internal-files/*` are 404. - Found in passing, not P6's: #918 (the audience menu swallows the next click). Closes #916. Part of #734. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-09-29 02:21:56 +00:00

feat(wiki): Handouts and Rules & bestiary pages (lane 8 P6, WIKI-14, WIKI-15, #734) ... 6fc6d4d7a8

Handouts by session with who each went to, GM prep first and W8's between
sessions; Show it (To picker, Discord on by default) and Take it back through
the existing revoke route; a handout's file on its own page through the
authorised files route only. Rules & bestiary: search, rule with source,
creature stat block, Make it ours, house rules, the licence line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(wiki): P6 render-check fixes; attachment helpers shared with P3 ... 7c971d4dfe

The reveal picker opens in the dialog's flow (a dialog clips a floating
menu), dialog titles quote the handout's name, the PDF frame is capped to a
page's height, a creature's stats read the stat envelope's values, and the
no-rules line links Settings → Content packs for a GM. Upload and file
addresses use uploadLoreAttachment/loreFileUrl in api/campaigns.js, the
names lane 8 P3 adds. Changelog fragment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into build/lane8-p6-handouts-rules ... 741192222d

Keeps both sides: P5's Quests and The party, then Handouts and Rules &
bestiary in the drawing's order, on P5's id scheme (w-handouts, w-rules
take their icons from CONTENTS_ICONS).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): a handout reveal opens the page to read; GET /handouts (#916) ... 3ac4c0660d

A live reveal whose audience covers a player opens that handout's page to
read (rendered for her, so GM blocks never reach her; read-only) and its
file list. Nothing else widens: the wiki list, search, feeds and every write
keep the page's own audience. Taking the reveal back closes it again.

GET /api/campaigns/{cid}/handouts lists the handouts shown to the reader,
grouped by session (null = between sessions, W8), with piece labels and
files. A player's new document page may be audience "mine" (hers and the
GMs'); no other page. LoreEntryResponse carries source_reference_entry_id
(IS-123). No migration.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(wiki): Priya's Handouts from GET /handouts; sticky actions in Show it; Based on rules entry ... 2b8f61434a

A player's Handouts page lists what was shown to her by session from the
server's own list (pieces on their own lines, Just you), then the ones she
added (just her and the GMs). The reveal dialog keeps Cancel / Show it at
its foot while it scrolls on a phone. A page made with Make it ours says
which rules entry it came from (IS-123).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into build/lane8-p6-handouts-rules ... f1ec4718e0

P3's editor and name routes beside P6's Handouts and Rules routes;
campaigns.js keeps P3's section, by-name and name-target reads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(wiki): drop the Handouts test's unused NOTE fixture (#734) ... ff280a8e51

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-09-29 05:17:27 +00:00

Merge remote-tracking branch 'origin/main' into build/lane8-p6-handouts-rules 58243cac6a

claude-bot merged commit 1f527b7753 into main 2026-09-29 06:08:27 +00:00

claude-bot referenced this pull request from a commit 2026-09-29 06:08:29 +00:00

Merge PR #920: lane 8 page P6, Handouts and Rules & bestiary; a reveal opens a handout to read (#916)

claude-bot referenced this pull request 2026-09-29 07:05:32 +00:00

docs(design): record D239–D242, the owner's answers to P3a, P3b, P5a and P5b #926

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!920

No description provided.