The GM who confirms a session isn't told they did (#887) #942

Merged

claude-bot merged 2 commits from fix/887-gm-own-confirmation into main 2026-09-29 21:06:22 +00:00

Conversation 0 Commits 2 Files changed 5 +79 -7

claude-bot commented 2026-09-29 19:19:53 +00:00

Collaborator

Copy link

Fixes item 1 of #887. Item 2, the J2 bell-paging check, comes with lane 10's journeys PR.

• Server: _send_confirmation_notice takes actor_id and passes it to notify_campaign, which already drops the actor. The bell row is also what the email is delivered from, so the GM now gets neither.
  • It's threaded from the manual confirm (POST /sessions/{id}/confirm, which now reads current_user), a direct booking (the creator) and a move (update_session_with_plan's existing actor_id).
  • Auto-close and the bot's vote-driven confirm pass none, so the whole table is still told.
  • The opt-in calendar invite is unchanged.
• Tests: two route tests in test_notifications.py (confirm, direct booking). Both fail on main and pass here.
  • Six session and notification modules pass locally: 228 tests.
  • ruff 0.4.4 is clean.
• Changelog: changelog.d/887-gm-own-confirmation.fixed.md.

🤖 Generated with Claude Code

Fixes item 1 of #887. Item 2, the J2 bell-paging check, comes with lane 10's journeys PR. - **Server:** `_send_confirmation_notice` takes `actor_id` and passes it to `notify_campaign`, which already drops the actor. The bell row is also what the email is delivered from, so the GM now gets neither. - It's threaded from the manual confirm (`POST /sessions/{id}/confirm`, which now reads `current_user`), a direct booking (the creator) and a move (`update_session_with_plan`'s existing `actor_id`). - Auto-close and the bot's vote-driven confirm pass none, so the whole table is still told. - The opt-in calendar invite is unchanged. - **Tests:** two route tests in `test_notifications.py` (confirm, direct booking). Both fail on main and pass here. - Six session and notification modules pass locally: 228 tests. - ruff 0.4.4 is clean. - **Changelog:** `changelog.d/887-gm-own-confirmation.fixed.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-09-29 19:19:53 +00:00

fix(sessions): the GM who confirms isn't told they did (#887) ... 1d4795be71

The confirming GM got a session_confirmed bell row, and since #865 an
email, about their own click. Thread the acting GM through as actor_id
from the manual confirm, the direct booking and the move; auto-close and
the bot's vote-driven confirm keep telling everyone.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-09-29 19:37:58 +00:00

test(sessions): the stalled-publish test's confirm tells the player only (#887) ... 5d7d2603f2

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit 0804cbaf8f into main 2026-09-29 21:06:22 +00:00

claude-bot referenced this pull request from a commit 2026-09-29 21:06:24 +00:00

Merge PR #942: the GM who confirms a session isn't told they did (#887)

claude-bot referenced this pull request 2026-09-29 21:06:37 +00:00

A GM is notified of their own session confirmation; J2's bell check depends on the first 20 rows #887

claude-bot referenced this pull request 2026-09-29 21:07:08 +00:00

Lane 10 PR 8: J2 and J4 walk outside the app; a mail app's Unsubscribe works (#736) #945

claude-bot referenced this pull request 2026-09-30 04:58:21 +00:00

A GM is notified of their own session confirmation; J2's bell check depends on the first 20 rows #887

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!942

No description provided.