A GM is notified of their own session confirmation; J2's bell check depends on the first 20 rows #887

New issue

Closed

opened 2026-09-27 06:23:43 +00:00 by claude-bot · 2 comments

claude-bot commented

2026-09-27 06:23:43 +00:00

Collaborator

These came out of fixing #865's journeys (lane 10 PR 2).

The confirming GM is notified of their own confirmation.
- Where: session_service._send_confirmation_notice calls notification_service.notify_campaign(kind=session_confirmed, …) without actor_id.
- Effect: the GM who confirmed gets a bell row, and since #865 an email, saying the session is on.
- Why it's a bug: every other notify path drops the actor (member_joined, reveal_taken_back). This one predates #865; #865's per-person email just makes it visible.
- Fix: thread the confirming user through as actor_id from the manual confirm routes. Auto-close and the bot's vote-driven confirm have no human actor, so they stay as they are.
- Test: add one asserting the actor gets neither a bell row nor an email.
J2:36 (keyboard) depends on the bell's first page.
- It looks for the seeded "Session 3 is on" row among the bell's first 20 rows.
- Any J2 retry in the desktop or phone project adds newer rows and pushes it off the page, so a flake in one project fails another.
- Fix: make the check independent of paging, e.g. by filtering to the campaign or scrolling or paging the bell.

These came out of fixing #865's journeys (lane 10 PR 2). 1. **The confirming GM is notified of their own confirmation.** - **Where:** `session_service._send_confirmation_notice` calls `notification_service.notify_campaign(kind=session_confirmed, …)` without `actor_id`. - **Effect:** the GM who confirmed gets a bell row, and since #865 an email, saying the session is on. - **Why it's a bug:** every other notify path drops the actor (`member_joined`, `reveal_taken_back`). This one predates #865; #865's per-person email just makes it visible. - **Fix:** thread the confirming user through as `actor_id` from the manual confirm routes. Auto-close and the bot's vote-driven confirm have no human actor, so they stay as they are. - **Test:** add one asserting the actor gets neither a bell row nor an email. 2. **J2:36 (keyboard) depends on the bell's first page.** - It looks for the seeded "Session 3 is on" row among the bell's first 20 rows. - Any J2 retry in the desktop or phone project adds newer rows and pushes it off the page, so a flake in one project fails another. - **Fix:** make the check independent of paging, e.g. by filtering to the campaign or scrolling or paging the bell.

claude-bot referenced this issue

2026-09-27 06:25:12 +00:00

feat(bot,webapp): notifications out — DMs, the GM's warnings, email that reaches people (lane 10 PR 2) #865

rbrooks referenced this issue from a commit

2026-09-29 19:19:37 +00:00

fix(sessions): the GM who confirms isn't told they did (#887)

claude-bot referenced this issue

2026-09-29 19:19:53 +00:00

The GM who confirms a session isn't told they did (#887) #942

rbrooks referenced this issue from a commit

2026-09-29 19:37:58 +00:00

test(sessions): the stalled-publish test's confirm tells the player only (#887)

claude-bot referenced this issue from a commit

2026-09-29 21:06:24 +00:00

Merge PR #942: the GM who confirms a session isn't told they did (#887)

claude-bot commented

2026-09-29 21:06:37 +00:00

Author

Collaborator

Item 1 was merged as #942 (2026-09-29, green CI).

The GM who confirms, books directly or moves a session is passed as actor_id, and gets no bell row and no email about it.
Auto-close and the bot's vote-driven confirm still tell everyone.
test_enqueue_off_loop's stalled-publish test now expects one publish, for the player.

Item 2, J2's bell check and paging, is fixed on build/lane10-8-journeys: it pages /api/me/notifications rather than trusting the first 20 rows. It lands with lane 10's journeys PR, and this closes then.

**Item 1 was merged as #942 (2026-09-29, green CI).** - The GM who confirms, books directly or moves a session is passed as `actor_id`, and gets no bell row and no email about it. - Auto-close and the bot's vote-driven confirm still tell everyone. - `test_enqueue_off_loop`'s stalled-publish test now expects one publish, for the player. **Item 2**, J2's bell check and paging, is fixed on `build/lane10-8-journeys`: it pages `/api/me/notifications` rather than trusting the first 20 rows. It lands with lane 10's journeys PR, and this closes then.

claude-bot referenced this issue from a pull request that will close it,

2026-09-29 21:07:08 +00:00

Lane 10 PR 8: J2 and J4 walk outside the app; a mail app's Unsubscribe works (#736) #945

claude-bot closed this issue

2026-09-30 04:57:49 +00:00

claude-bot commented

2026-09-30 04:58:21 +00:00

Author

Collaborator

Both items are done.

Item 1, the confirming GM being notified: #942 (merged 2026-09-29).
Item 2, J2's bell check: #945 (merged 2026-09-30, b9a6072a). The check now pages /api/me/notifications, so it no longer depends on the bell's first 20 rows.

Both items are done. - **Item 1**, the confirming GM being notified: #942 (merged 2026-09-29). - **Item 2**, J2's bell check: #945 (merged 2026-09-30, `b9a6072a`). The check now pages `/api/me/notifications`, so it no longer depends on the bell's first 20 rows.

claude-bot referenced this issue

2026-09-30 04:58:24 +00:00

Build lane 10: outside the app (EXT-1 to EXT-8) #736