Lane 10 PR 8: J2 and J4 walk outside the app; a mail app's Unsubscribe works (#736) #945

Merged

claude-bot merged 6 commits from build/lane10-8-journeys into main 2026-09-30 04:57:48 +00:00

Conversation 0 Commits 6 Files changed 14 +1243 -33

claude-bot commented 2026-09-29 21:07:07 +00:00

Collaborator

Copy link

Lane 10 PR 8 (#736). It also fixes #887 item 2. The journeys assert what reaches the fake bot and Mailpit; how it looks in Discord is the bot's golden tests' job (test_faces.py).

App bug found and fixed: one-click unsubscribe never worked. List-Unsubscribe pointed at the SPA page /email/stop?t=. nginx answers a POST there with 405, so a mail app's own Unsubscribe (RFC 8058) stopped nothing, silently.

• The header now names POST /api/email/stop/one-click?t= (the token is the credential, rate-limited to 10/min). The footer link is still the page.
• A GET on that address 303s to the page and stops nothing.
• Unit tests: test_email_templates.py, and two in test_email_routes.py. They fail on main.
• J2 POSTs List-Unsubscribe=One-Click to the header's address and sees the grid turn off.

J2 (a J2-only player, Ines, with a verified Discord link, so Priya's grid is never touched):

• Discord group:
  • session_proposed carries number and closes_at;
  • session_confirmed carries number and confirmed_time;
  • a notification_dm goes to Ines's Discord id, and its line matches her bell row;
  • a ❔ "maybe" through the bot API shows on Priya's session page;
  • session_cancelled carries the reason.
• Email, no Discord:
  • To is only Ines's address;
  • the time shows BST/GMT;
  • both List-Unsubscribe headers are there;
  • I'm in → Confirm → "You're in for Session N", and the session page agrees;
  • Stop → Undo → Stop, then the run-out page, then the grid has Email off while DM stays on.
• axe on the answer page, the stop page (and its states), and the grid with the DM column.
• #887 item 2: the bell check pages /api/me/notifications, so no longer depends on the first 20 rows.
• Not asserted: the survey expected session_confirmed to carry rsvp, but on main only reminders do, and e2e runs no beat.

J4: Start's /record/start carries the campaign's real channel_id, and the reply's announced_in is "channel".

J4b, new (j4b-test-the-bot.spec.js):

• Test the bot from Session 3's link (D149): launch, running ("Hears Priya… · someone not linked"), four stages Done, a Priya line, the summary, and audio_deleted.
• Nothing else happens: no other bot request, no /record/start, Priya's bell unchanged, and the session is still confirmed.
• Close deletes the test. A kept run appears in the list and deletes through its confirm, with axe.
• D171: a campaign with a guild and no channel, where the announcement lands nowhere. Start is 200 with announced_in: null, the panel says "Recording — but I couldn't post the announcement", and Stop completes it.

Harness:

• fake_bot writes runtime-generated near-silent WAVs (−44 dBFS, since pure silence is dropped as "Nobody was heard", #348) into audio_temp/tests/{id}/ and hands off. No audio is committed.
• announced_in in the status, and POST /__e2e/announce-fails.
• fakebot mounts audio_temp.
• J2's and J4b's campaigns are made once per stack, because of the 20/hour create limit.

Checks:

• Local journeys: J0b, J1, J2, J4, J4b and J5 pass in all three projects (94 passed; a J1 flake before this code passed 12/12 on a re-run).
• ruff 0.4.4 and eslint are clean.
• The email and notification pytest modules pass (97).
• Main (with #942 and #944) is merged in cleanly.

Noticed, not changed:

• the answer-buttons email has no link to the session page;
• the email's <h2> repeats "Quest Board";
• session_record_start's docstring still says the bot "refuses" (stale since D171).

🤖 Generated with Claude Code

Lane 10 PR 8 (#736). It also fixes #887 item 2. The journeys assert what reaches the fake bot and Mailpit; how it looks in Discord is the bot's golden tests' job (`test_faces.py`). **App bug found and fixed: one-click unsubscribe never worked.** `List-Unsubscribe` pointed at the SPA page `/email/stop?t=`. nginx answers a POST there with 405, so a mail app's own Unsubscribe (RFC 8058) stopped nothing, silently. - The header now names `POST /api/email/stop/one-click?t=` (the token is the credential, rate-limited to 10/min). The footer link is still the page. - A GET on that address 303s to the page and stops nothing. - Unit tests: `test_email_templates.py`, and two in `test_email_routes.py`. They fail on main. - J2 POSTs `List-Unsubscribe=One-Click` to the header's address and sees the grid turn off. **J2** (a J2-only player, Ines, with a verified Discord link, so Priya's grid is never touched): - **Discord group:** - `session_proposed` carries `number` and `closes_at`; - `session_confirmed` carries `number` and `confirmed_time`; - a `notification_dm` goes to Ines's Discord id, and its `line` matches her bell row; - a ❔ "maybe" through the bot API shows on Priya's session page; - `session_cancelled` carries the reason. - **Email, no Discord:** - To is only Ines's address; - the time shows BST/GMT; - both `List-Unsubscribe` headers are there; - I'm in → Confirm → "You're in for Session N", and the session page agrees; - Stop → Undo → Stop, then the run-out page, then the grid has Email off while DM stays on. - axe on the answer page, the stop page (and its states), and the grid with the DM column. - **#887 item 2:** the bell check pages `/api/me/notifications`, so no longer depends on the first 20 rows. - **Not asserted:** the survey expected `session_confirmed` to carry `rsvp`, but on main only reminders do, and e2e runs no beat. **J4:** Start's `/record/start` carries the campaign's real `channel_id`, and the reply's `announced_in` is `"channel"`. **J4b, new (`j4b-test-the-bot.spec.js`):** - Test the bot from Session 3's link (D149): launch, running ("Hears Priya… · someone not linked"), four stages Done, a Priya line, the summary, and `audio_deleted`. - Nothing else happens: no other bot request, no `/record/start`, Priya's bell unchanged, and the session is still confirmed. - Close deletes the test. A kept run appears in the list and deletes through its confirm, with axe. - **D171:** a campaign with a guild and no channel, where the announcement lands nowhere. Start is 200 with `announced_in: null`, the panel says "Recording — but I couldn't post the announcement", and Stop completes it. **Harness:** - `fake_bot` writes runtime-generated near-silent WAVs (−44 dBFS, since pure silence is dropped as "Nobody was heard", #348) into `audio_temp/tests/{id}/` and hands off. No audio is committed. - `announced_in` in the status, and `POST /__e2e/announce-fails`. - `fakebot` mounts `audio_temp`. - J2's and J4b's campaigns are made once per stack, because of the 20/hour create limit. **Checks:** - Local journeys: J0b, J1, J2, J4, J4b and J5 pass in all three projects (94 passed; a J1 flake before this code passed 12/12 on a re-run). - ruff 0.4.4 and eslint are clean. - The email and notification pytest modules pass (97). - Main (with #942 and #944) is merged in cleanly. **Noticed, not changed:** - the answer-buttons email has no link to the session page; - the email's `<h2>` repeats "Quest Board"; - `session_record_start`'s docstring still says the bot "refuses" (stale since D171). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-09-29 21:07:08 +00:00

test(e2e): WIP lane 10 journeys — J2 Discord/email legs, J4b Test the bot, fake bot handoff (#736) ... 4cd0d52cae

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

fix(webapp): a mail app's one-click Unsubscribe reaches the backend; J2 email leg (#736) ... 5533988980

List-Unsubscribe named the /email/stop page, which nginx serves as static
files and answers a POST with 405, so RFC 8058's one-click POST stopped
nothing. The header now names POST /api/email/stop/one-click?t=, and a GET
of it redirects to the page. Found by J2.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

test(e2e): J4b's D171 leg waits for Stop to finish the evening (#736) ... 8fa82d33a3

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

docs(e2e): README and changelog for lane 10's journeys; ruff format (#736) ... b2d5f620db

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

test(e2e): J2 and J4b make their campaigns once per stack, under the 20/hour create limit (#736) ... da383b96fe

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane10-8-journeys 48521a9ab3

claude-bot merged commit b9a6072a86 into main 2026-09-30 04:57:48 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 04:57:49 +00:00

Merge PR #945: lane 10 PR 8 — J2/J4/J4b journeys; one-click unsubscribe works (#736)

claude-bot referenced this pull request 2026-09-30 04:58:21 +00:00

A GM is notified of their own session confirmation; J2's bell check depends on the first 20 rows #887

claude-bot referenced this pull request 2026-09-30 04:58:24 +00:00

Build lane 10: outside the app (EXT-1 to EXT-8) #736

rbrooks referenced this pull request from a commit 2026-09-30 05:07:17 +00:00

fix(email): no "Quest Board" heading under the brand line; D171 comment (#945 follow-ups)

claude-bot referenced this pull request 2026-09-30 05:07:23 +00:00

Emails open with the news, not a second "Quest Board"; the D171 record-start comment (#945 follow-ups) #949

claude-bot referenced this pull request from a commit 2026-09-30 06:39:05 +00:00

Merge PR #949: emails open with the news; the D171 record-start comment (#945 follow-ups)

claude-bot referenced this pull request 2026-09-30 06:39:24 +00:00

Build lane 10: outside the app (EXT-1 to EXT-8) #736

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!945

No description provided.