A model is shown an unidentified item's party name, and a proposal about one finds its page (#993) #1003
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/993-unidentified-prompts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #993. The two follow-ups from #877's audit.
1. Prompts a GM reviews no longer carry the true name
run_lore_entry_draft_generation: rephrase, expand, promote, stat block, convert, merge): the model is shown the table's name for an unidentified page.draft.current_titlekeeps the true title, so the GM's review and the approval's write-back are unchanged.Title:line uses the table's name. Ids are unchanged.The output of these waits for a GM, so this was never a leak by itself; it stops the model writing a true name into text meant for the table where a GM might miss it.
2. A proposal about an unidentified item updates its page
The model is shown "A tarnished silver ring", but proposals were matched to pages by true title and aliases only, so such a proposal arrived as a new page.
title_to_write()keeps the page's own title when the proposal is named by the party's name. A merge draft uses it too.Guard
tests/wiki/test_title_readers.py's entries are updated with true reasons for each read that moved (_entry_name_keys,title_to_write,start_merge_draft), and the relationship prompt's raw read is gone from the list.Checked
tests/wiki/test_unidentified_prompts.py(11 tests): each prompt shows the party's name and not the true one; an identified page is unchanged; approving leavestitle,player_titleandidentified_atalone; the ambiguous case; a true title wins over another page's party name.tests/exportandtests/wiki, 607 passed.securityfragment).🤖 Generated with Claude Code