The writing models are told people's pronouns, players' and characters' apart (#999) #1013

Merged

claude-bot merged 7 commits from fix/999-pronouns-in-prompts into main 2026-10-01 22:48:58 +00:00

Conversation 0 Commits 7 Files changed 16 +1903 -30

claude-bot commented 2026-10-01 21:57:23 +00:00

Collaborator

Copy link

Closes #999, the one unbuilt part of #653: a saved recap could misgender someone, because the prompts sent names and never pronouns.

What changes

• app/services/pronoun_context.py (new) builds a short note for the prompts that write about people: the players who have set pronouns, and the characters who have, kept apart ("played by …"), with an instruction not to guess for anyone not listed. Wiki pages the text names are listed too.
• It goes into the summary header, the event log, highlights, wiki suggestions, the generation tools, recompose, and the bot's /ask answer (routers/bot.py; additive, no contract change).
• Nothing is stored on a run. Pronouns are read when the prompt is built, so someone who changes theirs is written about as they are now, and a member who has left brings nothing back.
• Account deletion and the export are covered by tests (test_account_deletion_pronouns.py, test_export_pronouns.py).
• A transcript in the bin (#680) is read for nothing, this included: recompose's lookup of the pages a transcript names goes through readable_transcript. tests/test_transcript_bin_readers.py caught it after #1005 merged.

The Privacy page

It said nothing about what goes to a model. Two additions, in the wording the owner confirmed (Q141, D269):

• Under "Your account": "… your pronouns if you choose to add them …".
• Under "Who can see it": "The transcription and writing services this server is set up to use are sent the recordings and transcripts to work from. The writing service is also told the names in a campaign, and the pronouns that its members have added for themselves and their characters, so that what it writes refers to people correctly. Those services may be run by another company; whoever runs this server can tell you which."

On for every campaign, with no switch (D269).

Checked

• Full backend suite on the merged tree: 6726 passed, 14 skipped (ruff 0.4.4 clean, 877 files formatted).
• Full vitest: 3575 passed and 5 timed out in four files this branch does not touch (DesignReference, NextSheet, ReviewView, CardFace), while the machine was running several suites at once; those four files re-run alone: 78 passed. The run before main was merged in was clean (3571 passed). eslint 0 errors.
• No migration. No bot contract change (the /ask payload gains nothing; the note is built server-side).
• The only UI change is two sentences on the Privacy page, covered by Privacy.test.jsx; not re-rendered in a browser.

🤖 Generated with Claude Code

Closes #999, the one unbuilt part of #653: a saved recap could misgender someone, because the prompts sent names and never pronouns. ## What changes - **`app/services/pronoun_context.py` (new)** builds a short note for the prompts that write about people: the players who have set pronouns, and the characters who have, kept apart ("played by …"), with an instruction not to guess for anyone not listed. Wiki pages the text names are listed too. - It goes into the summary header, the event log, highlights, wiki suggestions, the generation tools, recompose, and the bot's `/ask` answer (`routers/bot.py`; additive, no contract change). - **Nothing is stored on a run.** Pronouns are read when the prompt is built, so someone who changes theirs is written about as they are now, and a member who has left brings nothing back. - Account deletion and the export are covered by tests (`test_account_deletion_pronouns.py`, `test_export_pronouns.py`). - **A transcript in the bin (#680) is read for nothing, this included:** recompose's lookup of the pages a transcript names goes through `readable_transcript`. `tests/test_transcript_bin_readers.py` caught it after #1005 merged. ## The Privacy page It said nothing about what goes to a model. Two additions, in the wording the owner confirmed (Q141, D269): - Under "Your account": "… your pronouns if you choose to add them …". - Under "Who can see it": "The transcription and writing services this server is set up to use are sent the recordings and transcripts to work from. The writing service is also told the names in a campaign, and the pronouns that its members have added for themselves and their characters, so that what it writes refers to people correctly. Those services may be run by another company; whoever runs this server can tell you which." On for every campaign, with no switch (D269). ## Checked - Full backend suite on the merged tree: **6726 passed, 14 skipped** (ruff 0.4.4 clean, 877 files formatted). - Full vitest: 3575 passed and 5 timed out in four files this branch does not touch (`DesignReference`, `NextSheet`, `ReviewView`, `CardFace`), while the machine was running several suites at once; those four files re-run alone: **78 passed**. The run before main was merged in was clean (3571 passed). eslint 0 errors. - No migration. No bot contract change (the `/ask` payload gains nothing; the note is built server-side). - The only UI change is two sentences on the Privacy page, covered by `Privacy.test.jsx`; not re-rendered in a browser. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-10-01 21:57:23 +00:00

WIP: the writing models are told people's pronouns (#999) ... 2d46934b7f

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: tests, privacy text and docs for pronouns in prompts (#999) ... 909649ea4a

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

The writing models are told people's pronouns, players' and characters' apart (#999) ... b5982c518f

The summary, its event log and key moments, the wiki suggestions, /ask, the
wiki's draft tools and page summaries, and the GM's prep tools are each given
the pronouns of the people they can name: players' (users.pronouns), their
characters' (campaign_characters) and those on wiki pages the table reads.
Each kind is labelled, someone with none set is not listed, and the model is
told to use a name or singular they rather than guess.

Read fresh for every prompt (app/services/pronoun_context.py) and stored
nowhere, so leaving a campaign or deleting an account takes them out of the
next one; a test looks in every column of every table after a deletion.
/privacy and docs/OPERATIONS.md now say pronouns are kept and are sent to the
configured model.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into fix/999-pronouns-in-prompts 8e331cabbe

Merge remote-tracking branch 'origin/main' into fix/999-pronouns-in-prompts 38b8b7ff2c

Recompose reads no binned transcript for its pronoun lookup (#999, #680) ... a2cb825a25

The pronoun notes look up the pages a transcript names. A transcript in the
bin is read for nothing, so the lookup goes through readable_transcript like
every other reader; people's own pronouns still go.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

rbrooks referenced this pull request from a commit 2026-10-01 22:26:56 +00:00

The journeys' fake AI finds the wiki run's prompts behind the pronouns note (#999)

rbrooks added 1 commit 2026-10-01 22:26:56 +00:00

The journeys' fake AI finds the wiki run's prompts behind the pronouns note (#999) ... e24a33b049

It recognised extract and match by how the prompt opens. With pronouns set in
the fiction the note now comes first, so the fake answered neither and J5's
"Suggested wiki updates" never finished (PR #1013, all three journey jobs).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit 92ddfd0ab6 into main 2026-10-01 22:48:58 +00:00

claude-bot referenced this pull request from a commit 2026-10-01 22:48:59 +00:00

Merge PR #1013: the writing models are told people's pronouns, players' and characters' apart (#999)

claude-bot referenced this pull request 2026-10-01 22:50:55 +00:00

The writing models are given nobody's pronouns #999

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1013

No description provided.