fix(webapp): a session cannot end before it starts (#1159) #1160

Merged

claude-bot merged 1 commit from fix/1159-session-end-before-start into main 2026-10-13 01:57:11 +00:00

Conversation 0 Commits 1 Files changed 10 +412 -15

claude-bot commented 2026-10-13 01:23:33 +00:00

Collaborator

Copy link

Closes #1159.

A session rescheduled under 4.4.1 kept its old end time, so it could end weeks before it started: the calendar item was wrong, and the poller would have marked the session completed a minute after it began.

• Repair migration (e1159a1b2c3d, data only): a series session with an end at or before its start gets start + the series length; any other gets its end cleared. Downgrade is a deliberate no-op.
• Pencilled sessions: moving a tentative session's one time now moves its end by the same amount (the confirmed path already did, since 4.5.0).
• Readers: the calendar feed, the invite, the in-app calendar link and the completion poller ignore an end that is not after the start.
• Writes: an explicit end at or before the start is refused with 422 {"detail": "A session has to end after it starts."}.

No bot contract change.

Verified

On docker-test from the committed tree: the new test module plus the sessions, series, scheduling, calendar feed/invite and migration-head modules (164 passed); the poller's completion tests; alembic upgrade head / downgrade -1 / upgrade head on a real Postgres; ruff format and check; version sync and changelog checks; eslint and vitest for src/components/session.

Not run locally: the full backend and frontend suites, build, synthetic (left to CI).

Note for merging

Two other 4.5.1 branches (#1156, #1158) also add a migration. Whichever merges after this one needs its down_revision re-pointed and the head pin in tests/export/test_import_jobs_migration.py moved.

Prod's one affected row (session 14 of A Merry Band of Thieves) was corrected by hand on 12 Oct on the owner's say, after a backup.

🤖 Generated with Claude Code

Closes #1159. A session rescheduled under 4.4.1 kept its old end time, so it could end weeks before it started: the calendar item was wrong, and the poller would have marked the session completed a minute after it began. - **Repair migration** (`e1159a1b2c3d`, data only): a series session with an end at or before its start gets start + the series length; any other gets its end cleared. Downgrade is a deliberate no-op. - **Pencilled sessions**: moving a tentative session's one time now moves its end by the same amount (the confirmed path already did, since 4.5.0). - **Readers**: the calendar feed, the invite, the in-app calendar link and the completion poller ignore an end that is not after the start. - **Writes**: an explicit end at or before the start is refused with 422 `{"detail": "A session has to end after it starts."}`. No bot contract change. ## Verified On `docker-test` from the committed tree: the new test module plus the sessions, series, scheduling, calendar feed/invite and migration-head modules (164 passed); the poller's completion tests; `alembic upgrade head` / `downgrade -1` / `upgrade head` on a real Postgres; ruff format and check; version sync and changelog checks; eslint and vitest for `src/components/session`. Not run locally: the full backend and frontend suites, `build`, `synthetic` (left to CI). ## Note for merging Two other 4.5.1 branches (#1156, #1158) also add a migration. Whichever merges after this one needs its `down_revision` re-pointed and the head pin in `tests/export/test_import_jobs_migration.py` moved. Prod's one affected row (session 14 of A Merry Band of Thieves) was corrected by hand on 12 Oct on the owner's say, after a backup. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-13 01:23:34 +00:00

fix(webapp): a session cannot end before it starts (#1159) ... f275e21251

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit f15acba53d into main 2026-10-13 01:57:11 +00:00

claude-bot deleted branch fix/1159-session-end-before-start 2026-10-13 01:57:11 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 01:57:12 +00:00

Merge PR #1160: a session cannot end before it starts (#1159)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1160

No description provided.