feat(webapp): delete an empty session, no two series sessions on one day, untitled sessions read "Session N" (#1156) #1162

Merged

claude-bot merged 12 commits from feat/1156-delete-empty-session-series-duplicates into main 2026-10-13 04:56:03 +00:00

Conversation 0 Commits 12 Files changed 46 +1482 -94

claude-bot commented 2026-10-13 01:57:59 +00:00

Collaborator

Copy link

Closes #1156 (D298, D299, D300).

• Delete an empty session (D298). POST /api/sessions/{id}/delete, GM only, audited, tells nobody. "Empty" is decided in one place (session_deletion.not_empty_reason) and errs toward not empty: any content on the row, any row in any table that points at the session (read from the schema, so later tables count), any vote, or any notification about it. Otherwise 409: "Something has happened on this session, so it can only be cancelled, which tells the table." DELETE /sessions/{id} still cancels.
• A deleted series occurrence stays gone (D299). New table session_series_skips (migration e5f6a7b8c9d1, after e1159a1b2c3d); the materialiser skips those dates and never makes a session on a day one of the series' sessions already stands on. The move form says when the target day is taken; the Sessions list shows "Also that day: Session 16".
• Untitled sessions read "Session N" (D300) in emails, calendar items, Discord posts, search and exports, through one helper per side (session_label.display_title, sessionLabel).

No change to /api/bot/* shapes; no contract bump.

Verified

On docker-test: the new test_delete_empty_session.py (37), the series, sessions, scheduling, notifications, calendar, bot, reminder, email, attention, home, this-week, votes and search modules, and tests/wiki plus test_admin.py (1651 passed). Alembic upgrade, downgrade -1, upgrade on a scratch database (before the re-point onto e1159a1b2c3d; not re-run since). Ruff, changelog and version checks. Frontend lint and full vitest (4019 passed).

Not run: the new journey e2e/j8-delete-an-empty-session.spec.js, a full backend suite, and anything after merging main (one conflict in quest_archive.py, resolved by hand). No render check yet of the Manage menu, the delete dialog, the Move form and the Sessions list at phone width; to do before merging.

🤖 Generated with Claude Code

Closes #1156 (D298, D299, D300). - **Delete an empty session** (D298). `POST /api/sessions/{id}/delete`, GM only, audited, tells nobody. "Empty" is decided in one place (`session_deletion.not_empty_reason`) and errs toward not empty: any content on the row, any row in any table that points at the session (read from the schema, so later tables count), any vote, or any notification about it. Otherwise 409: "Something has happened on this session, so it can only be cancelled, which tells the table." `DELETE /sessions/{id}` still cancels. - **A deleted series occurrence stays gone** (D299). New table `session_series_skips` (migration `e5f6a7b8c9d1`, after `e1159a1b2c3d`); the materialiser skips those dates and never makes a session on a day one of the series' sessions already stands on. The move form says when the target day is taken; the Sessions list shows "Also that day: Session 16". - **Untitled sessions read "Session N"** (D300) in emails, calendar items, Discord posts, search and exports, through one helper per side (`session_label.display_title`, `sessionLabel`). No change to `/api/bot/*` shapes; no contract bump. ## Verified On `docker-test`: the new `test_delete_empty_session.py` (37), the series, sessions, scheduling, notifications, calendar, bot, reminder, email, attention, home, this-week, votes and search modules, and `tests/wiki` plus `test_admin.py` (1651 passed). Alembic upgrade, downgrade -1, upgrade on a scratch database (before the re-point onto `e1159a1b2c3d`; not re-run since). Ruff, changelog and version checks. Frontend lint and full vitest (4019 passed). Not run: the new journey `e2e/j8-delete-an-empty-session.spec.js`, a full backend suite, and anything after merging main (one conflict in `quest_archive.py`, resolved by hand). No render check yet of the Manage menu, the delete dialog, the Move form and the Sessions list at phone width; to do before merging. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 9 commits 2026-10-13 01:58:00 +00:00

wip: delete an empty session, series skip table, same-day clash, untitled sessions read Session N (#1156) ... 9d63151a86

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: tests for delete, skip, same-day, untitled (#1156) ... 56620ad53c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: test fixes 98000a7f92

wip 3e135f9c2c

wip: frontend delete, clash line, same-day note, untitled labels (#1156) ... 47157c7891

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): delete an empty session, series same-day rule, untitled sessions read Session N (#1156) ... 6b3cc133e3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1156) ... 3daaa78c28

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: title reader lists follow the display_title change (#1156) ... 902b48224a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into feat/1156: series skips now follow the end-time repair migration ... c6242bed69

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-13 02:21:47 +00:00

test(e2e): J8 activates controls the way each project does (#1156) ... 4920632fbb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-13 03:49:21 +00:00

Merge main into feat/1156 ... 084ca420ba

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 03:49:25 +00:00

rbrooks added 1 commit 2026-10-13 04:09:57 +00:00

ci: re-run after the runner ran out of disk ... ca4074488d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 4ad055f810 into main 2026-10-13 04:56:03 +00:00

claude-bot deleted branch feat/1156-delete-empty-session-series-duplicates 2026-10-13 04:56:04 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 04:56:05 +00:00

Merge PR #1162: delete an empty session, no two series sessions on one day, untitled sessions read "Session N" (#1156)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1162

No description provided.