feat: nudge follow-ups: the button on This week, the setting in exports, and a reminder for people with no linked Discord (#1158) #1179

Merged

claude-bot merged 8 commits from feat/1158-nudge-follow-ups into main 2026-10-13 19:17:46 +00:00

Conversation 0 Commits 8 Files changed 23 +630 -42

claude-bot commented 2026-10-13 18:31:13 +00:00

Collaborator

Copy link

Follow-ups to #1158 (PR #1168), at the owner's request for 4.5.1.

1. The remind button is on This week too, for a GM, under the next confirmed session's "Are you in?". Same component and the same route. The This week payload's GM block gains rsvp_nudged_at and unanswered_players (additive; a player's payload has no GM block).
2. The nudge setting travels with a campaign. rsvp_nudge_minutes is written by the export and read by the import. A missing key imports as the default; a present null (turned off) stays off. The export schema version stays "20": it is an optional scalar in the campaign object, like timezone and reminder_offsets_minutes, which were not bumped for.
3. People with no linked Discord are reminded in Quest Board. On a Discord campaign they get a session_reminder in their bell instead of a ping; the Discord line ends with a count, never names: "2 others have not linked Discord: /link connects your account, so your reactions count." When nobody unanswered is linked, nothing is posted, everyone gets the bell reminder, and the button says "None of them has linked Discord, so they were reminded in Quest Board." "Reminded N people" counts both routes. Muted members are neither reminded nor counted. The bot-feature check now applies only when there is someone to ping, with #1176's two refusals.

Bot: rsvp_nudge appends the count line from extra.unlinked_count (a non-negative int; "99+" above 99); still no person-written text. Additive on the wire; no BOT_CONTRACT_VERSION bump. No migration.

Verified

On docker-test: test_rsvp_nudge.py, test_this_week.py, tests/export/test_export_nudge.py (59 passed); an earlier wider run with tests/export and the wiki guard tests; the bot suite (1185 passed, before the last backend-only commits); ruff; version and changelog checks; frontend lint; vitest for This week, the button and the session pages (545 passed). J2 run for real in the desktop project (7 passed).

Not run: anything after merging main (one conflict in rsvp_nudge_service.py, resolved by hand: the branch's "only when someone is linked" check with main's refusal sentences); the full suites. Not checked: whether the bell row shows the answer buttons or a plain line. Not checkable on dev: the Discord side.

🤖 Generated with Claude Code

Follow-ups to #1158 (PR #1168), at the owner's request for 4.5.1. 1. **The remind button is on This week too**, for a GM, under the next confirmed session's "Are you in?". Same component and the same route. The This week payload's GM block gains `rsvp_nudged_at` and `unanswered_players` (additive; a player's payload has no GM block). 2. **The nudge setting travels with a campaign.** `rsvp_nudge_minutes` is written by the export and read by the import. A missing key imports as the default; a present `null` (turned off) stays off. The export schema version stays "20": it is an optional scalar in the `campaign` object, like `timezone` and `reminder_offsets_minutes`, which were not bumped for. 3. **People with no linked Discord are reminded in Quest Board.** On a Discord campaign they get a `session_reminder` in their bell instead of a ping; the Discord line ends with a count, never names: "2 others have not linked Discord: `/link` connects your account, so your reactions count." When nobody unanswered is linked, nothing is posted, everyone gets the bell reminder, and the button says "None of them has linked Discord, so they were reminded in Quest Board." "Reminded N people" counts both routes. Muted members are neither reminded nor counted. The bot-feature check now applies only when there is someone to ping, with #1176's two refusals. Bot: `rsvp_nudge` appends the count line from `extra.unlinked_count` (a non-negative int; "99+" above 99); still no person-written text. Additive on the wire; no `BOT_CONTRACT_VERSION` bump. No migration. ## Verified On `docker-test`: `test_rsvp_nudge.py`, `test_this_week.py`, `tests/export/test_export_nudge.py` (59 passed); an earlier wider run with `tests/export` and the wiki guard tests; the bot suite (1185 passed, before the last backend-only commits); ruff; version and changelog checks; frontend lint; vitest for This week, the button and the session pages (545 passed). J2 run for real in the desktop project (7 passed). Not run: anything after merging main (one conflict in `rsvp_nudge_service.py`, resolved by hand: the branch's "only when someone is linked" check with main's refusal sentences); the full suites. Not checked: whether the bell row shows the answer buttons or a plain line. Not checkable on dev: the Discord side. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 8 commits 2026-10-13 18:31:14 +00:00

feat(webapp,bot): nudge follow-ups: This week button, export of the setting, unlinked count (#1158) ... d887ec1730

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1158) 25cb049e53

fix(webapp): a nudge turned off imports as off; two-client test split (#1158) ... 3c3eb5582e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format import_service (#1158) ... db46bb114a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): players who have not linked Discord are reminded in Quest Board (#1158) ... a2dc3182e5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: changelog wording (#1158) ... 8db648ab74

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1158) ... 652a9b421b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into feat/1158-nudge-follow-ups ... 522dabe494

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 18:31:19 +00:00

claude-bot merged commit 886fc14c83 into main 2026-10-13 19:17:46 +00:00

claude-bot deleted branch feat/1158-nudge-follow-ups 2026-10-13 19:17:47 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 19:17:48 +00:00

Merge PR #1179: nudge follow-ups: the button on This week, the setting in exports, a reminder for people with no linked Discord (#1158)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1179

No description provided.