fix(webapp): read-only routes no longer write (#1178) #1208

Merged

claude-bot merged 3 commits from fix/1178-get-routes-that-write into main 2026-10-17 07:44:53 +00:00

Conversation 0 Commits 3 Files changed 23 +296 -91

claude-bot commented 2026-10-17 07:15:34 +00:00

Collaborator

Copy link

Fixes most of #1178: read-only routes that still wrote.

• Planning names: GET /planning/names/{category} is now a pure read (options: [] on a cold cache). Generating moves to a POST on the same path, and the Names drawer uses the POST. Any outside script that generated names with the GET must now POST.
• GET /admin/settings/secrets-health only reports. The plaintext-secret upgrade still runs at startup.
• Ownership offers, for campaigns and the server: a stale offer is treated as gone on read without writing. A new Beat task, expire_ownership_offers, runs every 5 minutes and expires stale offers.
• The sheet-definition GETs no longer call ensure_builtin (it already runs at startup).
• Content-pack exports: the audit row per download stays, since the download is the event being recorded. The allow-list entry now gives that reason.
• The allow-list in test_get_routes_do_not_write.py is down to 5 entries, each with its real reason.

Left for later:

• download_lore_image's legacy-file move: moving files needs a startup sweep, not a migration.
• list_creations deletes character creations untouched for 30 days. The scan hadn't listed it. It needs a Beat task or a read-side filter, filed separately.

Tests on docker-test: 1382 backend tests passed across the areas touched. Frontend src/pages/prep passed when rerun alone, after load timeouts at a load average of 34. Ruff, version sync and the changelog check are clean.

🤖 Generated with Claude Code

Fixes most of #1178: read-only routes that still wrote. - **Planning names:** `GET /planning/names/{category}` is now a pure read (`options: []` on a cold cache). Generating moves to a `POST` on the same path, and the Names drawer uses the POST. Any outside script that generated names with the GET must now POST. - **`GET /admin/settings/secrets-health`** only reports. The plaintext-secret upgrade still runs at startup. - **Ownership offers, for campaigns and the server:** a stale offer is treated as gone on read without writing. A new Beat task, `expire_ownership_offers`, runs every 5 minutes and expires stale offers. - **The sheet-definition GETs** no longer call `ensure_builtin` (it already runs at startup). - **Content-pack exports:** the audit row per download stays, since the download is the event being recorded. The allow-list entry now gives that reason. - The allow-list in `test_get_routes_do_not_write.py` is down to 5 entries, each with its real reason. Left for later: - **`download_lore_image`'s legacy-file move:** moving files needs a startup sweep, not a migration. - **`list_creations` deletes character creations untouched for 30 days.** The scan hadn't listed it. It needs a Beat task or a read-side filter, filed separately. Tests on docker-test: 1382 backend tests passed across the areas touched. Frontend `src/pages/prep` passed when rerun alone, after load timeouts at a load average of 34. Ruff, version sync and the changelog check are clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-10-17 07:15:34 +00:00

wip: planning names POST, secrets-health pure read (#1178) ... 1accd948b6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: ownership expiry off the GETs, sheet GETs stop self-seeding, allow-list shrunk (#1178) ... 8be532d676

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): read-only routes stop writing (#1178) ... 4f700c7e3a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 07:15:37 +00:00

claude-bot merged commit 21c128f64c into main 2026-10-17 07:44:53 +00:00

claude-bot referenced this pull request from a commit 2026-10-17 07:44:58 +00:00

Merge PR #1208: read-only routes no longer write (#1178)

claude-bot referenced this pull request 2026-10-17 09:35:29 +00:00

Read-only routes that still write: the ones the scan found #1178

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1208

No description provided.