feat: the line of the night, picked by the GM or voted by the table (#1191) #1209

Merged

claude-bot merged 10 commits from feat/1191-line-of-the-night into main 2026-10-17 10:59:41 +00:00

Conversation 0 Commits 10 Files changed 43 +2056 -67

claude-bot commented 2026-10-17 07:48:39 +00:00

Collaborator

Copy link

Fixes #1191: the line of the night.

Owner's decisions (comments on #1191):

• The GM picks, or the table votes, set per campaign in Settings → General; the GM picks by default.
• Voting opens when the GM approves the summary and closes three days later. The GM can close it early, and a tie or no votes falls to the GM.

Server:

• Migration a1191b0e5701:
  • sessions.best_highlight_id and line_vote_closed_at;
  • campaigns.line_of_the_night_mode;
  • the line_of_the_night_votes table, unique per session and voter.
• GET/PUT /api/sessions/{id}/line-of-the-night, PUT/DELETE …/vote, and POST …/close.
• Highlights carry is_best, and the campaign highlights list takes ?best_only=true.
• A Beat sweep stores the winner after the three days. A GET works it out without writing.
• Counts are hidden from everyone, the GM included, until the vote closes, and the GM can pick only after it closes, so a GM can't override the table mid-vote.
• Export carries the mode and each session's line, additively.
• The bot labels the approved post's quote "Line of the night" when extra.top_quote.is_best. This is additive, with no contract bump.

Screens:

• the Settings radio;
• the Review tab's mark and move, the vote state and "Close voting now";
• the Read view's line shown first, the vote toggles, and the winner's count after close;
• the Highlights page's "Lines of the night" filter.

Tests:

• Backend on docker-test: test_line_of_the_night (25 new), export, highlights and bounds, 1031 passed, plus 147 on the rerun of the fixed pins.
• Bot faces: 583 passed.
• Vitest: 546 of 548 passed, then the fixed files reran clean (85 of 85).
• ruff and checks clean.
• Journey J6 timed out at a load average of about 35 on docker-test, so this PR's CI run is its real check.

Merge note: this is the first of four 4.6.0 migrations, all based on f1187a1b2c3d. The others are re-pointed after this merges.

🤖 Generated with Claude Code

Fixes #1191: the line of the night. **Owner's decisions** (comments on #1191): - The GM picks, or the table votes, set per campaign in Settings → General; the GM picks by default. - Voting opens when the GM approves the summary and closes three days later. The GM can close it early, and a tie or no votes falls to the GM. **Server:** - Migration `a1191b0e5701`: - `sessions.best_highlight_id` and `line_vote_closed_at`; - `campaigns.line_of_the_night_mode`; - the `line_of_the_night_votes` table, unique per session and voter. - `GET`/`PUT /api/sessions/{id}/line-of-the-night`, `PUT`/`DELETE …/vote`, and `POST …/close`. - Highlights carry `is_best`, and the campaign highlights list takes `?best_only=true`. - A Beat sweep stores the winner after the three days. A GET works it out without writing. - Counts are hidden from everyone, the GM included, until the vote closes, and the GM can pick only after it closes, so a GM can't override the table mid-vote. - Export carries the mode and each session's line, additively. - The bot labels the approved post's quote "Line of the night" when `extra.top_quote.is_best`. This is additive, with no contract bump. **Screens:** - the Settings radio; - the Review tab's mark and move, the vote state and "Close voting now"; - the Read view's line shown first, the vote toggles, and the winner's count after close; - the Highlights page's "Lines of the night" filter. **Tests:** - Backend on docker-test: `test_line_of_the_night` (25 new), export, highlights and bounds, 1031 passed, plus 147 on the rerun of the fixed pins. - Bot faces: 583 passed. - Vitest: 546 of 548 passed, then the fixed files reran clean (85 of 85). - ruff and checks clean. - Journey J6 timed out at a load average of about 35 on docker-test, so this PR's CI run is its real check. **Merge note:** this is the first of four 4.6.0 migrations, all based on `f1187a1b2c3d`. The others are re-pointed after this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-10-17 07:48:39 +00:00

wip: the line of the night (#1191) ... e7c12e7dc6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: import bound for the line of the night (#1191) ... c9bcdcd700

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format the line-of-the-night files (#1191) ... c2a02056de

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: the import-bounds fixture holds a line of the night; the one-head pin follows (#1191) ... 60f5352691

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: the line of the night screens (#1191) ... 34ad6ff6f5

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: the highlight mocks know the line of the night (#1191) ... d4a3168054

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

fix: no best_only when it is off (#1191) ... 510b31b627

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 07:48:40 +00:00

rbrooks added 2 commits 2026-10-17 09:37:52 +00:00

test: list_campaign_quotes reads a session's title (#1191) ... e15fe60341

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into feat/1191-line-of-the-night ... 749f6a7e8e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-17 10:32:07 +00:00

test: drop the stale Session row from the title-reader list (#1191) ... 1b3993c931

list_campaign_quotes now reads sess.title, so the Session row was a row nobody checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 8b9cb4c68f into main 2026-10-17 10:59:41 +00:00

claude-bot referenced this pull request from a commit 2026-10-17 10:59:41 +00:00

Merge PR #1209: the line of the night (#1191)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1209

No description provided.