rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

fix(a11y): axe 4.14 — accessible names contain the visible words (supersedes #1229) #1244

Closed
claude-bot wants to merge 0 commits from fix/1229-axe-4.14-name-mismatch into main
pull from: fix/1229-axe-4.14-name-mismatch
merge into: rbrooks:main
Conversation 1 Commits - Files changed -
claude-bot commented 2026-10-27 17:31:48 +00:00
Collaborator
Copy link

Supersedes Renovate's #1229 (@axe-core/playwright 4.14.0): the same bump, plus the markup fixes it needs.

axe-core 4.14 adds label-content-name-mismatch (serious). The keyboard journeys on #1229 failed it in 3 specs (a11y-wiki-pages, j3-a-gm-preps, j6-what-happened). The other journey failures on that run were runner ENOSPC.

What changed

  • pages/prep/ShelfSection.jsx: the scene button showed "File it" or "Move" but was named "File in a scene:
Supersedes Renovate's #1229 (`@axe-core/playwright` 4.14.0): the same bump, plus the markup fixes it needs. axe-core 4.14 adds `label-content-name-mismatch` (serious). The keyboard journeys on #1229 failed it in 3 specs (`a11y-wiki-pages`, `j3-a-gm-preps`, `j6-what-happened`). The other journey failures on that run were runner ENOSPC. **What changed** - `pages/prep/ShelfSection.jsx`: the scene button showed "File it" or "Move" but was named "File in a scene: <title>". Its name is now "File it in a scene: <title>" or "Move to a scene: <title>", depending on its state. - `pages/CampaignStoryline.jsx`: the chapter links had an `aria-label` over a visible number disc. "Chapter" and ":" are now `sr-only` text around the disc. The name stays "Chapter 2: The Accord" and now contains what is seen. - Tests updated (`PrepSheet.test.jsx`). Fragment `changelog.d/1229-axe-label-content-name.fixed.md`. **Checked locally:** vitest on `CampaignStoryline.test.jsx` and `PrepSheet.test.jsx` (83 passed), eslint clean on the changed files. **Not checked locally:** the journeys. This PR touches `package-lock.json`, so CI runs all three; it is the check that axe finds no other offender. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(a11y): accessible names contain the visible words (axe 4.14)
Some checks failed
CI / Backend lint (ruff) (pull_request) Successful in 34s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m13s
Details
CI / Feedback site tests (pull_request) Successful in 52s
Details
CI / Bot/backend version sync (pull_request) Successful in 31s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 18s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Which journeys does this change need? (pull_request) Successful in 14s
Details
CI / Bot tests and audit (pull_request) Successful in 2m23s
Details
CI / Docker image build (pull_request) Successful in 6m25s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 10m12s
Details
CI / Backend migration, tests, and audit (pull_request) Failing after 11m32s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 12m50s
Details
CI / End-to-end journeys (keyboard) (pull_request) Failing after 3m21s
Details
CI / End-to-end journeys (phone) (pull_request) Failing after 3m22s
Details
CI / End-to-end journeys (desktop) (pull_request) Failing after 4m15s
Details
eb794bf08a 
axe-core 4.14 adds label-content-name-mismatch, which the journeys'
WCAG checks fail on two places:

- Prep's shelf card scene button showed "File it" / "Move" but was
  named "File in a scene: <title>". It is now "File it in a scene:"
  or "Move to a scene:", per its state.
- The storyline's chapter links had an aria-label over a visible
  number disc. The "Chapter" and ":" words are now sr-only text
  around the disc, so the name is unchanged and contains what is seen.

Rides on Renovate's @axe-core/playwright 4.14.0 bump (#1229).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-27 17:32:00 +00:00
claude-bot commented 2026-11-05 20:35:16 +00:00
Author
Collaborator
Copy link

Landed through #1338 (merged 2026-11-05), which combined this with the open dependency updates for 4.7.0. Two more names the stricter check found are fixed there too: the wiki editor's numbered-list button, and the chapter links' name (back to "Chapter 2: The Accord"). Closing as landed.

Landed through #1338 (merged 2026-11-05), which combined this with the open dependency updates for 4.7.0. Two more names the stricter check found are fixed there too: the wiki editor's numbered-list button, and the chapter links' name (back to "Chapter 2: The Accord"). Closing as landed.
claude-bot closed this pull request 2026-11-05 20:35:17 +00:00
Some checks failed
CI / Backend lint (ruff) (pull_request) Successful in 34s
Required
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m13s
Required
Details
CI / Feedback site tests (pull_request) Successful in 52s
Required
Details
CI / Bot/backend version sync (pull_request) Successful in 31s
Required
Details
CI / Does this change touch the recording path? (pull_request) Successful in 18s
Required
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Required
Details
CI / Which journeys does this change need? (pull_request) Successful in 14s
Required
Details
CI / Bot tests and audit (pull_request) Successful in 2m23s
Required
Details
CI / Docker image build (pull_request) Successful in 6m25s
Required
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 10m12s
Required
Details
CI / Backend migration, tests, and audit (pull_request) Failing after 11m32s
Required
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 12m50s
Required
Details
CI / End-to-end journeys (keyboard) (pull_request) Failing after 3m21s
Required
Details
CI / End-to-end journeys (phone) (pull_request) Failing after 3m22s
Required
Details
CI / End-to-end journeys (desktop) (pull_request) Failing after 4m15s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1244
No description provided.