fix(webapp): the map stays visible while placing a marker (#1251) #1252

Merged

claude-bot merged 1 commit from fix/map-placing-blank into main 2026-10-28 04:19:22 +00:00

Conversation 0 Commits 1 Files changed 3 +33 -1

claude-bot commented 2026-10-28 00:17:25 +00:00

Collaborator

Copy link

Closes #1251.

Pressing Add a marker blanked the map. MapCanvas rendered the Leaflet container's className with the --placing modifier. When placing began, React rewrote that attribute and wiped the classes Leaflet adds to the same element. Without leaflet-container, the global img { max-width: 100% } shrank every tile to nothing.

• The rendered className is now constant. qmap__canvas--placing is toggled with classList in an effect.
• Regression test in MapCanvas.test.jsx, using the real Leaflet. It fails on the old code and passes now. MapCanvas.test.jsx and Map.test.jsx both pass (18 tests), and eslint is clean.
• Changelog fragment changelog.d/1251-map-placing-blank.fixed.md.

🤖 Generated with Claude Code

Closes #1251. Pressing **Add a marker** blanked the map. `MapCanvas` rendered the Leaflet container's `className` with the `--placing` modifier. When placing began, React rewrote that attribute and wiped the classes Leaflet adds to the same element. Without `leaflet-container`, the global `img { max-width: 100% }` shrank every tile to nothing. - The rendered `className` is now constant. `qmap__canvas--placing` is toggled with `classList` in an effect. - Regression test in `MapCanvas.test.jsx`, using the real Leaflet. It fails on the old code and passes now. `MapCanvas.test.jsx` and `Map.test.jsx` both pass (18 tests), and eslint is clean. - Changelog fragment `changelog.d/1251-map-placing-blank.fixed.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-28 00:17:26 +00:00

fix(webapp): the map stays visible while placing a marker (#1251) ... 1c296425b3

MapCanvas rendered the Leaflet container's className with the placing
modifier, so React rewrote the attribute when placing began and wiped
Leaflet's own classes. Without leaflet-container, the global
img { max-width: 100% } squashed every tile to nothing. The rendered
className is now constant and the modifier is toggled with classList.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit e26a0ad4fe into main 2026-10-28 04:19:22 +00:00

claude-bot deleted branch fix/map-placing-blank 2026-10-28 04:19:22 +00:00

claude-bot referenced this pull request from a commit 2026-10-28 04:19:23 +00:00

fix(webapp): the map stays visible while placing a marker (#1251) (#1252)

claude-bot referenced this pull request 2026-10-28 06:30:30 +00:00

The map goes blank when "Add a marker" is pressed #1251

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1252

No description provided.