fix(webapp): the [[ menu finds maps, and the preview draws a map embed (#1277) #1278

Merged

claude-bot merged 3 commits from fix/map-embed-link-menu into main 2026-10-29 20:00:39 +00:00

Conversation 0 Commits 3 Files changed 5 +100 -6

claude-bot commented 2026-10-29 17:09:57 +00:00

Collaborator

Copy link

Closes #1277.

• [[ menu: EditorPane loads the campaign's maps with the existing mapEmbedLoader, once, the first time the menu opens.
  • The new editorText.acMaps(query, maps) decides what to offer. After Map: it offers only maps whose name contains the rest (up to 6), with no "Create" option. Otherwise it offers up to 3 maps whose name starts with what's typed, after the pages.
  • Options read "Map: " with the type "Map", and the screen-reader live line counts maps as well as pages.
• Preview: the editor's preview passes campaignId to WikiText, so ![[Map: X]] draws the map instead of showing it as a page waiting to be written.
• Changelog fragment 1277-map-embed-link-menu.fixed.md.

Checked: vitest over src/pages/wiki and src/wiki (512 passed), with new tests for acMaps, for the menu after Map: and among pages, and for the preview drawing the embed. eslint reports 0 errors.
Not checked: not seen in a browser.

🤖 Generated with Claude Code

Closes #1277. - **`[[` menu:** `EditorPane` loads the campaign's maps with the existing `mapEmbedLoader`, once, the first time the menu opens. - The new `editorText.acMaps(query, maps)` decides what to offer. After `Map:` it offers only maps whose name contains the rest (up to 6), with no "Create" option. Otherwise it offers up to 3 maps whose name starts with what's typed, after the pages. - Options read "Map: <name>" with the type "Map", and the screen-reader live line counts maps as well as pages. - **Preview:** the editor's preview passes `campaignId` to `WikiText`, so `![[Map: X]]` draws the map instead of showing it as a page waiting to be written. - Changelog fragment `1277-map-embed-link-menu.fixed.md`. **Checked:** vitest over `src/pages/wiki` and `src/wiki` (512 passed), with new tests for `acMaps`, for the menu after `Map:` and among pages, and for the preview drawing the embed. eslint reports 0 errors. **Not checked:** not seen in a browser. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-29 17:09:57 +00:00

fix(webapp): the [[ menu finds maps, and the preview draws a map embed (#1277) ... 9de1014bda

The menu searched only pages, so ![[Map: … offered to create a page;
it now loads the campaign's maps once, on first opening, and after Map:
offers only maps. The editor's preview rendered WikiText without the
campaign id, which map embeds need, so it showed a wanted page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot added this to the v4.6.2 - The map, as planned milestone 2026-10-29 17:41:42 +00:00

rbrooks added 1 commit 2026-10-29 17:55:42 +00:00

Merge remote-tracking branch 'origin/main' into fix/map-embed-link-menu a0653a1236

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-29 17:56:00 +00:00

rbrooks added 1 commit 2026-10-29 18:50:56 +00:00

ci: re-run (the runner's disk was full building the e2e images) ... 0e8fe4312f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 15db1aad6e into main 2026-10-29 20:00:39 +00:00

claude-bot deleted branch fix/map-embed-link-menu 2026-10-29 20:00:40 +00:00

claude-bot referenced this pull request from a commit 2026-10-29 20:00:42 +00:00

Merge pull request 'fix(webapp): the [[ menu finds maps, and the preview draws a map embed (#1277)' (#1278) from fix/map-embed-link-menu into main

claude-bot referenced this pull request 2026-10-29 21:01:48 +00:00

chore(release): v4.6.2-rc2 #1281

claude-bot referenced this pull request 2026-10-30 18:32:59 +00:00

Map: what the plan has that the build lacks (audit, 2026-10-28) #1263

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

v4.6.2 - The map, as planned

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1278

No description provided.