feat(webapp): New campaign's "setup of one of yours" opens the full copy dialog (#1223) #1291

Merged

claude-bot merged 3 commits from feat/1223-new-campaign-full-copy into main 2026-10-30 23:40:59 +00:00

Conversation 0 Commits 3 Files changed 9 +83 -433

claude-bot commented 2026-10-30 19:32:59 +00:00

Collaborator

Copy link

Closes #1223, the owner's Q193 answer (a).

Frontend (NewCampaign.jsx):

• Choosing "The setup of one of yours" keeps the "Which of yours" picker (campaigns you GM, not archived), and the submit opens the existing StartFromThisDialog (mode="clone", unchanged) on the chosen campaign.
• The Name field and game picker are hidden for that choice, because the dialog asks for the name. Focus returns to the button on close (Modal, tested).

Backend: the old settings-only path is removed. Nothing else sent template: {from_campaign_id} (frontend, bot, e2e and tests grepped). Removed:

• CampaignFromCampaign, _settings_from_campaign, and TemplateCampaignNotFound / TemplateCampaignForbidden, with their router handling.
• About 15 tests of that path.

A template object naming from_campaign_id is now a 422. SETTINGS_COPIED_FROM_TEMPLATE and _clamp_copied_retention stay, because the clone (setup_archive.py) uses them.

Docs: docs/API.md points to POST /clone; there's a new CATALOGUE row (IS-537) and a changelog fragment.

Wording, held for the owner on the Wording Review page, part i. Don't merge until it's decided:

• The description becomes "Its scheduling and reminders, and whatever else you choose to take: pages, maps, people." It was "Settings only — scheduling, reminders, wiki kinds. Nothing from its story comes with it."
• New button label: "Choose what to take".

Note: the dialog ticks the world pages by default (the owner's Q189). So to get exactly what the old settings-only copy gave, untick everything in the dialog.

Checked:

• vitest: NewCampaign and StartFromThisDialog, 37/37 passed.
• eslint is clean, and ruff format and check pass.
• backend on docker-test: test_campaign_templates, test_campaign_setup_copy, wiki/test_title_readers and export/test_import_bounds, 198 passed.

Not run: the full suites (CI runs them), and no render check yet.

🤖 Generated with Claude Code

Closes #1223, the owner's Q193 answer (a). **Frontend (`NewCampaign.jsx`):** - Choosing "The setup of one of yours" keeps the "Which of yours" picker (campaigns you GM, not archived), and the submit opens the existing `StartFromThisDialog` (`mode="clone"`, unchanged) on the chosen campaign. - The Name field and game picker are hidden for that choice, because the dialog asks for the name. Focus returns to the button on close (`Modal`, tested). **Backend: the old settings-only path is removed.** Nothing else sent `template: {from_campaign_id}` (frontend, bot, e2e and tests grepped). Removed: - `CampaignFromCampaign`, `_settings_from_campaign`, and `TemplateCampaignNotFound` / `TemplateCampaignForbidden`, with their router handling. - About 15 tests of that path. A `template` object naming `from_campaign_id` is now a 422. `SETTINGS_COPIED_FROM_TEMPLATE` and `_clamp_copied_retention` stay, because the clone (`setup_archive.py`) uses them. **Docs:** `docs/API.md` points to `POST /clone`; there's a new CATALOGUE row (IS-537) and a changelog fragment. **Wording, held for the owner** on the Wording Review page, part i. **Don't merge until it's decided:** - The description becomes "Its scheduling and reminders, and whatever else you choose to take: pages, maps, people." It was "Settings only — scheduling, reminders, wiki kinds. Nothing from its story comes with it." - New button label: "Choose what to take". **Note:** the dialog ticks the world pages by default (the owner's Q189). So to get exactly what the old settings-only copy gave, untick everything in the dialog. **Checked:** - vitest: NewCampaign and StartFromThisDialog, 37/37 passed. - eslint is clean, and ruff format and check pass. - backend on docker-test: `test_campaign_templates`, `test_campaign_setup_copy`, `wiki/test_title_readers` and `export/test_import_bounds`, 198 passed. **Not run:** the full suites (CI runs them), and no render check yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-10-30 19:32:59 +00:00

feat(webapp): New campaign's "setup of one of yours" opens the full copy dialog (#1223) ... 1f0ea66493

Removes the settings-only template.from_campaign_id path from POST /api/campaigns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: unused imports in the template tests eb75888214

rbrooks added 1 commit 2026-10-30 23:02:08 +00:00

Merge remote-tracking branch 'origin/main' into feat/1223-new-campaign-full-copy eda59910e1

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-30 23:02:22 +00:00

claude-bot merged commit 9aca6da93d into main 2026-10-30 23:40:59 +00:00

claude-bot deleted branch feat/1223-new-campaign-full-copy 2026-10-30 23:41:00 +00:00

claude-bot referenced this pull request from a commit 2026-10-30 23:41:00 +00:00

Merge pull request 'feat(webapp): New campaign's "setup of one of yours" opens the full copy dialog (#1223)' (#1291) from feat/1223-new-campaign-full-copy into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1291

No description provided.