feat(webapp): browse the rules, stage 1: kinds with counts, a kind in numbered pages (#1240) #1295

Merged

claude-bot merged 5 commits from feat/1240-browse-rules into main 2026-10-31 00:21:35 +00:00

Conversation 1 Commits 5 Files changed 16 +1693 -25

claude-bot commented 2026-10-30 21:22:57 +00:00

Collaborator

Copy link

Closes #1240. Built to the owner-signed-off drawing (lane 6e, PR #1292), with their answers: the system's order, pack buttons, numbered pages, and search inside an open kind.

Server (content_packs.py, app/reference/browse.py, search_service.py):

• GET /api/game-systems/{key}/reference/kinds?campaign_id=&pack_id= returns the kinds in the display order (5e's ancestry is "Species"), with counts from one grouped COUNT. GM-only records are counted only for a GM, and gm_only / gm_only_total are given. The visible packs are listed (pack_id narrows the counts, not the pack list).
• GET …/reference/page?…&page=&per_page= returns {total, page, per_page, capped, level_range, items}.
  • Without a query: A–Z with a real SQL OFFSET and no 500 cap, so every page of a 1,486-spell kind is reachable. This was a bug waiting to happen: the search's offset was capped at CANDIDATES = 500.
  • With a query: ranked, with total = min(count, 500) and capped set.
• pack_id flows through _matching / count / search, so a count and its list always answer the same question. The existing /reference route is unchanged.

Page (Rules.jsx, new ui/Pager):

• An empty box shows the kinds grid with counts (two columns on a phone); a GM sees a GM-only note.
• An open kind shows: ‹ All kinds, the level range, pack buttons (more than one pack only), a search inside the kind, and rows as today's hits plus a "GMs only" chip.
• A numbered pager: a <nav aria-label="Pages"> with aria-current, 44 px targets on touch, and on /design.
• State lives in the URL (kind, page, lvlmin, lvlmax, pack, q), so Back returns to the same page. The empty, failed, capped and no-packs states are covered.

Fixed on integration review:

• The server sends level_range as {min: null, max: null} for a kind with no levels, never null, which built a bogus option. The test used null.
• A 5e challenge rating is fractional, so the selects run floor(min)…ceil(max), and "to N" asks for everything below N+1.

Wording for the owner: the Wording Review page, part j (j-001 to j-009). It includes making today's search chip say "GMs only" like the rest of the app. Don't merge until it's decided.

Checked:

• backend: test_reference_browse (24 new) and related modules, 51 passed on the merged branch. The full suite ran on the server half: 10,411 passed, and the one audit failure was fixed.
• frontend: 774 passed (wiki, ui, design reference). eslint: 0 errors.
• lint, version sync and the changelog check pass.
• A render check of the built page on the seeded stack (phone and desktop, light and dark, GM and player, axe) is running. Results follow as a comment.

🤖 Generated with Claude Code

Closes #1240. Built to the owner-signed-off drawing (lane 6e, PR #1292), with their answers: the system's order, pack buttons, **numbered pages**, and search inside an open kind. **Server (`content_packs.py`, `app/reference/browse.py`, `search_service.py`):** - `GET /api/game-systems/{key}/reference/kinds?campaign_id=&pack_id=` returns the kinds in the display order (5e's ancestry is "Species"), with counts from one grouped COUNT. GM-only records are counted only for a GM, and `gm_only` / `gm_only_total` are given. The visible packs are listed (`pack_id` narrows the counts, not the pack list). - `GET …/reference/page?…&page=&per_page=` returns `{total, page, per_page, capped, level_range, items}`. - **Without a query:** A–Z with a real SQL OFFSET and no 500 cap, so every page of a 1,486-spell kind is reachable. This was a bug waiting to happen: the search's offset was capped at `CANDIDATES` = 500. - **With a query:** ranked, with `total = min(count, 500)` and `capped` set. - `pack_id` flows through `_matching` / `count` / `search`, so a count and its list always answer the same question. The existing `/reference` route is unchanged. **Page (`Rules.jsx`, new `ui/Pager`):** - An empty box shows the kinds grid with counts (two columns on a phone); a GM sees a GM-only note. - An open kind shows: ‹ All kinds, the level range, pack buttons (more than one pack only), a search inside the kind, and rows as today's hits plus a "GMs only" chip. - A numbered pager: a `<nav aria-label="Pages">` with `aria-current`, 44 px targets on touch, and on `/design`. - State lives in the URL (`kind`, `page`, `lvlmin`, `lvlmax`, `pack`, `q`), so Back returns to the same page. The empty, failed, capped and no-packs states are covered. **Fixed on integration review:** - The server sends `level_range` as `{min: null, max: null}` for a kind with no levels, never `null`, which built a bogus option. The test used `null`. - A 5e challenge rating is fractional, so the selects run `floor(min)…ceil(max)`, and "to N" asks for everything below N+1. **Wording for the owner:** the Wording Review page, part j (j-001 to j-009). It includes making today's search chip say "GMs only" like the rest of the app. **Don't merge until it's decided.** **Checked:** - backend: `test_reference_browse` (24 new) and related modules, 51 passed on the merged branch. The full suite ran on the server half: 10,411 passed, and the one audit failure was fixed. - frontend: 774 passed (wiki, ui, design reference). eslint: 0 errors. - lint, version sync and the changelog check pass. - A render check of the built page on the seeded stack (phone and desktop, light and dark, GM and player, axe) is running. Results follow as a comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-10-30 21:22:58 +00:00

feat(webapp): browse the rules API, kinds with counts and numbered pages (#1240) ... ccb1ef3794

GET /api/game-systems/{key}/reference/kinds (kinds in the system's order
with counts, GM-only counted only for a GM, the visible packs) and
GET .../reference/page (A-Z without a query and with no 500-record cap on
the offset, so every page of a large kind is reachable; ranked and capped
at 500 with a query; level range; pack filter). app/reference/browse.py
holds the display order and labels (5e's ancestry is "Species").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): browse the rules by kind, a numbered page at a time (#1240) ... 73d4fb7c93

Rules & bestiary with the search box empty lists the kinds with counts;
a kind opens as an A-Z list with a level range, pack buttons when more
than one pack is loaded, a search inside the kind, and a numbered pager
(new ui/Pager, on /design). State lives in the URL so Back returns to the
same page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): browse levels as whole numbers, a kind with none has no level filter (#1240) ... 82712caa45

The server's level_range is {min: null, max: null} for a kind with no
levels, never null, which made a bogus option; and a 5e challenge rating
is fractional, so the selects run from floor(min) to ceil(max) and "to N"
asks for everything below N+1. The test now uses the server's real shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-10-30 21:48:46 +00:00

Author

Collaborator

Copy link

Render check (2026-10-30), on the seeded journeys stack (Playwright 1.64.1 + axe, on docker-test; the stack is torn down). Campaign: The Lanterns of Cortal (pf2e). A synthetic 120-creature pack was imported through the real API, to get a creature kind and three pages.

Rules & bestiary, as the GM (dana) and a player (joaquin), at 1280×800 and 390×844, light and dark:

Page	Seen
empty box	"Browse" with Creatures 120 and Rules 3 tiles, then house rules
?kind=creature	‹ All kinds, Creatures 120, the filter row (level, 3 pack buttons, Search creatures), 50 A–Z rows, Page 1 of 3
&page=2	the next 50, page 2 marked current
&lvlmin=30	"No creatures at level 30 or higher." + Clear the level
typed "gob" in Search creatures	the URL gains &q=gob, Creatures 12, Gob- names only

Every one returned HTTP 200, with 0 console errors and no axe violations. At 390 there's no horizontal overflow (page 390/390, filter row 292/292). I looked at the phone shot myself: the stacked filters and the search box are normal height, and the pager sits at the bottom.

/design, where the Pager section shows its three samples: axe reports critical aria-required-children (2) and aria-valid-attr-value (3), serious color-contrast, and at 390 scrollable-region-focusable, across the whole 38,000 px gallery. The Pager itself uses only aria-label, aria-current="page" and aria-hidden on the gaps, so it's unlikely to be the source, but that hasn't been confirmed against main. It's a follow-up, not a blocker for this PR. At 390, a sample with many pages wraps "Next" onto a second line, which is acceptable.

Screenshots are in the session's scratchpad (render1240/).

**Render check (2026-10-30), on the seeded journeys stack** (Playwright 1.64.1 + axe, on docker-test; the stack is torn down). Campaign: The Lanterns of Cortal (pf2e). A synthetic 120-creature pack was imported through the real API, to get a creature kind and three pages. **Rules & bestiary**, as the GM (dana) and a player (joaquin), at 1280×800 and 390×844, light and dark: | Page | Seen | |---|---| | empty box | "Browse" with **Creatures 120** and **Rules 3** tiles, then house rules | | `?kind=creature` | ‹ All kinds, **Creatures 120**, the filter row (level, 3 pack buttons, Search creatures), 50 A–Z rows, **Page 1 of 3** | | `&page=2` | the next 50, page 2 marked current | | `&lvlmin=30` | **"No creatures at level 30 or higher."** + Clear the level | | typed "gob" in Search creatures | the URL gains `&q=gob`, **Creatures 12**, Gob- names only | Every one returned HTTP 200, with **0 console errors** and **no axe violations**. At 390 there's **no horizontal overflow** (page 390/390, filter row 292/292). I looked at the phone shot myself: the stacked filters and the search box are normal height, and the pager sits at the bottom. **`/design`**, where the Pager section shows its three samples: axe reports critical `aria-required-children` (2) and `aria-valid-attr-value` (3), serious `color-contrast`, and at 390 `scrollable-region-focusable`, across the whole 38,000 px gallery. The Pager itself uses only `aria-label`, `aria-current="page"` and `aria-hidden` on the gaps, so it's unlikely to be the source, but **that hasn't been confirmed against main**. It's a follow-up, not a blocker for this PR. At 390, a sample with many pages wraps "Next" onto a second line, which is acceptable. Screenshots are in the session's scratchpad (`render1240/`).

rbrooks added 2 commits 2026-10-30 23:02:05 +00:00

copy(webapp): the rules search's GM-only chip says "GMs only" (#1240) ... 72ec1e6cc2

The owner's wording, j-008 on the Wording Review page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into feat/1240-browse-rules 3c3ae16809

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-30 23:02:24 +00:00

rbrooks referenced this pull request from a commit 2026-10-30 23:25:04 +00:00

copy: "GM only" is "GMs only" everywhere it is shown

claude-bot referenced this pull request 2026-10-30 23:25:12 +00:00

copy: "GM only" is "GMs only" everywhere it is shown #1296

claude-bot merged commit be8eaad7bf into main 2026-10-31 00:21:35 +00:00

claude-bot deleted branch feat/1240-browse-rules 2026-10-31 00:21:36 +00:00

claude-bot referenced this pull request from a commit 2026-10-31 00:21:37 +00:00

Merge pull request 'feat(webapp): browse the rules, stage 1: kinds with counts, a kind in numbered pages (#1240)' (#1295) from feat/1240-browse-rules into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1295

No description provided.