feat(feedback-site): lane 1, round two — the owner's decisions (#659) #670
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/lane1-round2-659"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Six answers from the owner's review of lane 1, plus two things the review turned up.
Settled
The footer's justification is worth stating, since "should there be one?" was a real question:
PUB-10(accessibility statement, decision D4) andPUB-6(rules licences and notices, #553) are both catalogued pages with no door anywhere in the app, and neither belongs in the Contents. The version is there because this is software people run themselves and "what version?" is the first thing any bug report needs.Because the phone sheet now carries the full menu, the desktop rail drops its own half-copy — the identity disc is on every page, and two partial copies of the account menu is one more thing to keep in step than it is worth.
Two fixes
The bell panel ran past the bottom of the screen, so "Notification settings" could not be reached at all — reported by the owner. A panel now caps its height and is a flex column: the head and the foot stay put, the middle scrolls. Search does the same, for the same reason.
Settings is gone from a player's Contents. The owner asked whether players need it; I checked rather than assumed:
isGm(CampaignDetail.jsx:1726,:784,:808).PATCH /campaigns/{id}isDepends(require_gm)(campaigns.py:976-982).user.py:55,60), andCampaignMemberhas onlycampaign_id,user_id,role,joined_at(models/campaign.py:255-290).So a player was being shown a door that only says no.
One thing raised, not changed
Analytics is the opposite case and stays for players — the endpoint is
require_campaign_member(campaigns.py:2549-2556), and every member can open it today. But it shows every member by name with their attendance and vote-participation rates, colour-coded green/yellow/red (analytics_service.py:141-170, no viewer argument, so no per-viewer filtering).Nobody chose that; it is what the page happens to do. It is raised on the lane page as a decision for the owner, with a recommendation (keep the page for everyone, show a player the campaign-wide numbers and their own row), rather than changed unilaterally here.
A self-inflicted fault, found by rendering
The "You" group was drawn on chrome-coloured ground, but
.sheet__panelis a paper panel — so the group's own text came out near-invisible. Now drawn on the ground it will really sit on, measured at 17.4:1. Reading the code would not have caught it.Tests: 77 passed. Rendered at 1500px, no console output, no page errors, and all three anchored panels verified to sit inside their box rather than overflowing it.
🤖 Generated with Claude Code
Six answers from the review, plus two things the review turned up. Settled: - Phone bar carries a real search box inside a campaign, at the cost of the wordmark and the page title. Outside a campaign there is nothing to search, so the title comes back. The icon version stays drawn, for the record. - Search results group by kind, and the standing "searching this campaign only" line is gone: the scope is what anyone would assume, so saying it above every result was noise. The nothing-found message still names the campaign, where the name is the useful part. - There is a footer: version, Help, Accessibility, Licences & notices. The case for it is that PUB-10 and PUB-6 are catalogued pages with no door anywhere in the app, and the version is what any bug report needs first. Not shown in Table mode. - The phone Contents sheet carries the whole account menu in a "You" group, on every sheet rather than only Home's — otherwise signing out from inside a campaign means going Home first. The desktop rail therefore drops its own half-copy: the identity disc is right there. - The Lore icon keeps its star. Fixed, both reported or asked by the owner: - The bell panel ran past the bottom of the screen, so "Notification settings" could not be reached at all. A panel now caps its height and is a column: head and foot stay put, the middle scrolls. Search does the same, for the same reason. - Settings is gone from a player's Contents. Checked rather than assumed: every entry point to the Edit Campaign form is gated on isGm, PATCH /campaigns/{id} is require_gm, and no per-member preference hides under it — a member's email and calendar opt-ins are on the user profile. A player was being shown a door that only says no. Analytics is the opposite and stays for players: the endpoint asks only for campaign membership. But it shows every member by name with their attendance and vote-participation rates, colour-coded, to everyone. Nobody chose that. Raised on the page as a decision for the owner, with a recommendation, rather than changed here. One self-inflicted fault found by rendering: the "You" group was drawn on chrome-coloured ground, but the phone sheet is a paper panel, so its own text came out near-invisible. Now drawn on the ground it will really sit on, at 17.4:1. Tests: 77 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>