rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

Lane 2b backfill — Settings, every state drawn (#659, #696) #704

Closed
claude-bot wants to merge 0 commits from feat/lane2b-backfill into main
pull from: feat/lane2b-backfill
merge into: rbrooks:main
Conversation 1 Commits - Files changed - +745 -128
claude-bot commented 2026-09-19 18:15:39 +00:00
Collaborator
Copy link

Step 3 of #696, part 2: the Settings pages (CAMP-9 to CAMP-17). The shell backfill follows in its own PR.

Coverage

coverage/lane2b.py classifies 147 placements, none missing:

Classification Count
Drawn 124
Replaced by a decision 2
Elsewhere 18
Deferred (speculative) 2
Behaviour 1

Before the backfill, the audit found 8 missing and 38 half-drawn. All four coverage scripts (lanes 2, 2b, 3 and 4) pass.

What is drawn

Invites

  • The third dead-link reason, "No longer works".
  • The links while loading, and when they fail to load.
  • "Creating…" on the button.

Ownership

  • Two GMs.
  • The hosted-slot rule (IS-195), from both sides: Dana hears that a slot may be needed, and Priya hears whether she has one. Neither is told the other's plan.
  • "Offering…" on the button.

Recording & AI

  • Audio retention in every state: the instance default, the campaign's own, at the cap, and "keep it" where the instance sets no cap.
  • The shortening confirmation for audio, for both, and the no-prompt case when nothing is old enough.
  • The AI panel loading, never set up, the other way round, and switched back on.
  • The summariser test's error and capability-gap verdicts.
  • The transcriber's own test and removable key.
  • Saving, saved and not saved.

Wiki

  • Reputation levels (IS-088), starting from Pathfinder's seven.

Content packs

  • The list empty, loading and failing.
  • Removing a pack.
  • An administrator's required reason for turning a pack off.
  • Loading from a web address.
  • The affirmation while loading, and re-armed after a 422.
  • Importing, the error, and both outcomes, with what was skipped.
  • A licence the GM gave, marked as theirs.

Foundry

  • Scenes paired with maps, in all four states (IS-321).

Archive

  • The archive confirmation.
  • "Archiving…", and the archived section.
  • Export busy.
  • Delete, with its copy in progress, deleting, and not deleted.

General, finished

  • The system control while loading, and with no systems.
  • Three reminders set.
  • Saving.
  • The conversion queue's states.
  • What a member reads, including the blank case.

Discord, finished (new section)

  • A mistyped channel.
  • The bot unable to see the channel.
  • Webhook tests.
  • Webhook only.

Decided while drawing

  • "Who can look things up in it" stays two choices. At campaign scope, "Default" and "GM only" mean the same thing.
  • "Keep it for good" is offered only where the instance sets no cap.
  • A Test button appears only where there is something of the campaign's own to test.

First-draw faults fixed, in lanes 2 and 2b

  • General's timezone hint contradicted D17.
  • General and the Settings index said members read it here, which D45 moved to This week.
  • "No timezone stops scheduling" contradicted CA-132.
  • Handing on ownership was said to cost the export.
  • The ownership offer's name and date disagreed with SH-8.
  • Shortening transcripts used Save's colour.
  • Lane 2's index still said "Ownership & GMs" (D26).

Caught by rendering

  • Oversized headings in stills of a single section.
  • An audio confirmation that named sessions too recent to be affected.
  • "One setting" above a second one.
  • Stills of mixed heights sharing a row.
  • The Discord form running into its lead.

The feedback-site tests pass (101).

🤖 Generated with Claude Code

Step 3 of #696, part 2: the Settings pages (CAMP-9 to CAMP-17). The shell backfill follows in its own PR. ## Coverage `coverage/lane2b.py` classifies **147 placements, none missing**: | Classification | Count | |---|---| | Drawn | 124 | | Replaced by a decision | 2 | | Elsewhere | 18 | | Deferred (speculative) | 2 | | Behaviour | 1 | Before the backfill, the audit found 8 missing and 38 half-drawn. All four coverage scripts (lanes 2, 2b, 3 and 4) pass. ## What is drawn **Invites** - The third dead-link reason, "No longer works". - The links while loading, and when they fail to load. - "Creating…" on the button. **Ownership** - Two GMs. - The hosted-slot rule (`IS-195`), from both sides: Dana hears that a slot may be needed, and Priya hears whether she has one. Neither is told the other's plan. - "Offering…" on the button. **Recording & AI** - Audio retention in every state: the instance default, the campaign's own, at the cap, and "keep it" where the instance sets no cap. - The shortening confirmation for audio, for both, and the no-prompt case when nothing is old enough. - The AI panel loading, never set up, the other way round, and switched back on. - The summariser test's error and capability-gap verdicts. - The transcriber's own test and removable key. - Saving, saved and not saved. **Wiki** - Reputation levels (`IS-088`), starting from Pathfinder's seven. **Content packs** - The list empty, loading and failing. - Removing a pack. - An administrator's required reason for turning a pack off. - Loading from a web address. - The affirmation while loading, and re-armed after a 422. - Importing, the error, and both outcomes, with what was skipped. - A licence the GM gave, marked as theirs. **Foundry** - Scenes paired with maps, in all four states (`IS-321`). **Archive** - The archive confirmation. - "Archiving…", and the archived section. - Export busy. - Delete, with its copy in progress, deleting, and not deleted. **General, finished** - The system control while loading, and with no systems. - Three reminders set. - Saving. - The conversion queue's states. - What a member reads, including the blank case. **Discord, finished** (new section) - A mistyped channel. - The bot unable to see the channel. - Webhook tests. - Webhook only. ## Decided while drawing - "Who can look things up in it" stays two choices. At campaign scope, "Default" and "GM only" mean the same thing. - "Keep it for good" is offered only where the instance sets no cap. - A Test button appears only where there is something of the campaign's own to test. ## First-draw faults fixed, in lanes 2 and 2b - General's timezone hint contradicted D17. - General and the Settings index said members read it here, which D45 moved to This week. - "No timezone stops scheduling" contradicted `CA-132`. - Handing on ownership was said to cost the export. - The ownership offer's name and date disagreed with SH-8. - Shortening transcripts used Save's colour. - Lane 2's index still said "Ownership & GMs" (D26). ## Caught by rendering - Oversized headings in stills of a single section. - An audio confirmation that named sessions too recent to be affected. - "One setting" above a second one. - Stills of mixed heights sharing a row. - The Discord form running into its lead. The feedback-site tests pass (101). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(feedback-site): lane 2b backfill — Settings, every state drawn (#659, #696)
All checks were successful
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m3s
Details
CI / Bot/backend version sync (pull_request) Successful in 50s
Details
CI / Backend lint (ruff) (pull_request) Successful in 57s
Details
CI / Feedback site tests (pull_request) Successful in 1m21s
Details
CI / Frontend tests, audit, and build (pull_request) Successful in 3m18s
Details
CI / Docker image build (pull_request) Successful in 3m5s
Details
CI / Bot tests and audit (pull_request) Successful in 3m48s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 10m47s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Successful in 18m4s
Details
1ded8f06d6 
The row-by-row audit found Settings (CAMP-9 to 17) had dropped 8
features and half-drawn 38. All are drawn now; coverage/lane2b.py
classifies 147 placements with none missing (124 drawn, 2 replaced,
18 elsewhere, 2 deferred, 1 behaviour).

- Invites: the third dead reason; links loading and failing; Creating.
- Ownership: two GMs; the hosted-slot rule (IS-195) for both sides;
  Offering.
- Recording & AI: audio retention in every state (default, own, at the
  cap, no cap); shortening audio, both, or nothing old enough; the AI
  panel loading, never set up, the other way round, switched back on;
  summariser test verdicts; saving states.
- Wiki: reputation levels (IS-088), from Pathfinder's seven.
- Content packs: the list empty/loading/failing; removing; an admin's
  turn-off reason; loading from a web address; the affirmation loading
  and re-armed; importing, errors and both outcomes; a licence the GM
  gave.
- Foundry: scenes paired with maps, in all four states (IS-321).
- Archive: archiving confirm and busy, archived; export and delete
  busy; delete error.
- General and Discord finished: system control, reminders, saving,
  the conversion queue's states, the About card blank; channel and
  webhook tests and errors, webhook-only.

Fixes first-draw faults in lanes 2 and 2b: General's timezone hint
contradicted D17; General and the Settings index said members read it
(D45); "no timezone stops scheduling" contradicted CA-132; handing on
ownership was said to cost the export; the offer's name and date
disagreed with SH-8; shortening transcripts used Save's colour; lane
2's index still said "Ownership & GMs" (D26).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rbrooks closed this pull request 2026-09-19 18:35:21 +00:00
claude-bot commented 2026-09-19 18:35:26 +00:00
Author
Collaborator
Copy link

Merged as b05cdb8. CI was green on all jobs. Deploying the review site next.

Merged as b05cdb8. CI was green on all jobs. Deploying the review site next.
All checks were successful
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m3s
Required
Details
CI / Bot/backend version sync (pull_request) Successful in 50s
Required
Details
CI / Backend lint (ruff) (pull_request) Successful in 57s
Required
Details
CI / Feedback site tests (pull_request) Successful in 1m21s
Required
Details
CI / Frontend tests, audit, and build (pull_request) Successful in 3m18s
Required
Details
CI / Docker image build (pull_request) Successful in 3m5s
Required
Details
CI / Bot tests and audit (pull_request) Successful in 3m48s
Required
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 10m47s
Required
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Successful in 18m4s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!704
No description provided.