fix(webapp): rules search results say the level too ("creature 2") (#731) #856

Merged

claude-bot merged 4 commits from fix/rule-card-level-label into main 2026-09-26 22:01:15 +00:00

Conversation 0 Commits 4 Files changed 3 +47 -1

claude-bot commented 2026-09-26 19:17:28 +00:00

Collaborator

Copy link

This comes from the owner's answer to lane 5's Find departures: accept them, and add the level everywhere.

The cards were already done. cardKinds.js kindOf() gained the level in a567348a, and every card surface uses that helper: the table cards, the stage, the preview, the GM's phone view, the sweep, and Find's shelf rows.

The one place still missing it was rules search results, both Find's "In the rules" and the app bar's search. Both read SearchItem.line from search.py _rules(), which built the line from kind alone, even though the reference search already returns level.

The fix is a new helper, _rule_kind_text(kind, level), which gives "creature 2" (0 and −1 included, matching kindOf) or the bare kind when there's no level.

Tests: a new test_a_rule_with_a_level_shows_it_in_the_line. test_campaign_search and test_reference_search pass (45), and ruff is clean. The frontend is unchanged.

🤖 Generated with Claude Code

This comes from the owner's answer to lane 5's Find departures: accept them, **and add the level everywhere**. The cards were already done. `cardKinds.js` `kindOf()` gained the level in `a567348a`, and every card surface uses that helper: the table cards, the stage, the preview, the GM's phone view, the sweep, and Find's shelf rows. The one place still missing it was **rules search results**, both Find's "In the rules" and the app bar's search. Both read `SearchItem.line` from `search.py` `_rules()`, which built the line from `kind` alone, even though the reference search already returns `level`. The fix is a new helper, `_rule_kind_text(kind, level)`, which gives "creature 2" (0 and −1 included, matching `kindOf`) or the bare kind when there's no level. Tests: a new `test_a_rule_with_a_level_shows_it_in_the_line`. `test_campaign_search` and `test_reference_search` pass (45), and ruff is clean. The frontend is unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-09-26 19:17:29 +00:00

fix(backend): a Find rules hit says its level too (#852) ... e06d15d861

kindOf() already put a rule's level on the shelf card's own kind label
(a567348a, "creature 2"), but Find's and the app-bar search's rules
results are built server-side in search.py's _rules(), a separate path
that composed the line from kind alone. Add _rule_kind_text(), the same
"kind level" shape, so a hit reads the same word as the card it opens
into.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

docs(webapp): changelog entry for the rules line's level (#852) ... d772490d5a

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fix(webapp): correct the issue reference on the level fix ... 85a2bde9e5

Cited #852 by mistake (the base branch's last merged PR, unrelated) —
this is lane 5's rule-card work, #731.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-09-26 19:26:50 +00:00

docs: the owner's remaining decisions D179–D217, and the lanes' PR 0 reclassifications #857

rbrooks added 1 commit 2026-09-26 20:23:38 +00:00

Merge remote-tracking branch 'origin/main' into fix/rule-card-level-label ... 87a8a668a3

# Conflicts:
#	CHANGELOG.md

claude-bot merged commit a3274db357 into main 2026-09-26 22:01:15 +00:00

claude-bot referenced this pull request from a commit 2026-09-26 22:01:16 +00:00

Merge PR #856: rules search results say the level too (#731)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!856

No description provided.