fix(webapp): each "keep the audio" choice means what it says (#834, A1/D179) #860

Merged

claude-bot merged 3 commits from fix/834-retention-semantics into main 2026-09-26 21:59:45 +00:00

Conversation 0 Commits 3 Files changed 31 +624 -346

claude-bot commented 2026-09-26 20:09:52 +00:00

Collaborator

Copy link

Closes #834. This is the owner's A1 answer (D179).

Behaviour, before and after

Mode	Before	After
Default (renamed trash_after_processing → trash_after_approval)	Binned the moment processing succeeded, before any GM read the summary	Binned when the GM approves the summary. Until then it stays, limited only by the instance cap
Keep for N days	Approval also binned it early	Approval leaves it alone; it's binned N days after transcription
Keep it	Approval also binned it ("keep" really meant "until approved")	Approval leaves it alone; it's kept until someone removes it
A failed run	Its N-day debug window	Unchanged: kept for its N-day debug window so it can be retried
Nightly sweep	"Already transcribed → goes at once"	"Already approved → goes at once"

• apply_post_processing_audio_retention is now a documented no-op.
• The old stored values (delete_after_processing, trash_after_processing) are normalised on read. There's no migration; the new name is written on the next save.
• Privacy page: its audio line switched on a value the server never stored, so it could never match. It's now true.
• Self-hosters: under the default, audio is now kept until approval, which is longer than before. The CHANGELOG says so.

e2e seed

The J5 fixture's campaign-level override only existed to work around this bug, so it's removed; the default now does what J5 needs. J5 needs its CI run to confirm this.

Tests

• New: one test per mode and state, plus the sweep, in test_retention.py. Two approval regressions in test_sessions.py (retain_days and retain_indefinitely untouched by approval).
• Rewritten for the new semantics: the cap and preview tests.
• Backend targeted: 328 + 100 passed.
• Frontend: 2,471 passed; eslint has 0 errors.
• ruff is clean.

It adds no Depends(get_db). It merges cleanly with main, #854 included.

🤖 Generated with Claude Code

Closes #834. This is the owner's A1 answer (D179). ## Behaviour, before and after | Mode | Before | After | |---|---|---| | **Default** (renamed `trash_after_processing` → **`trash_after_approval`**) | Binned the moment processing succeeded, before any GM read the summary | Binned when the GM **approves** the summary. Until then it stays, limited only by the instance cap | | **Keep for N days** | Approval also binned it early | Approval leaves it alone; it's binned N days after transcription | | **Keep it** | Approval also binned it ("keep" really meant "until approved") | Approval leaves it alone; it's kept until someone removes it | | **A failed run** | Its N-day debug window | Unchanged: kept for its N-day debug window so it can be retried | | **Nightly sweep** | "Already transcribed → goes at once" | "Already **approved** → goes at once" | - `apply_post_processing_audio_retention` is now a documented no-op. - The old stored values (`delete_after_processing`, `trash_after_processing`) are normalised on read. There's no migration; the new name is written on the next save. - **Privacy page:** its audio line switched on a value the server never stored, so it could never match. It's now true. - **Self-hosters:** under the default, audio is now kept until approval, which is longer than before. The CHANGELOG says so. ## e2e seed The J5 fixture's campaign-level override only existed to work around this bug, so it's removed; the default now does what J5 needs. **J5 needs its CI run to confirm this.** ## Tests - **New:** one test per mode and state, plus the sweep, in `test_retention.py`. Two approval regressions in `test_sessions.py` (`retain_days` and `retain_indefinitely` untouched by approval). - **Rewritten** for the new semantics: the cap and preview tests. - Backend targeted: 328 + 100 passed. - Frontend: 2,471 passed; eslint has 0 errors. - ruff is clean. It adds no `Depends(get_db)`. It merges cleanly with main, #854 included. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-09-26 20:09:53 +00:00

fix(backend): each retention choice means what it says (#834, A1) ... 4c74b3f3e4

The default mode now bins audio when the GM approves the summary, not the
moment process_audio succeeds — apply_post_processing_audio_retention is a
documented no-op, and the nightly sweep's "already transcribed" catch becomes
"already approved" (Session.content_approved_at). "Keep for N days" and "Keep
it" no longer get overridden by approval: POST /sessions/{id}/approve only
trashes audio under trash_after_approval now, and the review tab's
audio_bin_days only appears when approving would actually bin something. A
failed run keeps its usual debug window regardless of mode.

Renamed the stored mode trash_after_processing -> trash_after_approval, with
delete_after_processing and trash_after_processing both read as legacy
spellings (settings_service, exactly as #427 did). No migration.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fix(webapp): retention text and forms say trash_after_approval (#834, A1) ... 5ba3c560bc

The setup wizard, the admin retention form, the campaign override form and
the legacy /manage dropdown all wrote trash_after_processing; the public
Privacy page's own switch-case couldn't match it either, since the backend
was already sending the old spelling. All four now write/match
trash_after_approval, and the copy that claimed audio is binned "once
transcribed" now says "once approved" — true, now that the backend does it.

e2e seed: no campaign override is needed any more to get a `ready` recording
for J5 to review — the instance default already leaves audio ready until
approval. expected_audio_status() always answers `ready` and says why.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

docs(webapp): describe trash_after_approval, and log #834 in the CHANGELOG ... 3d25f28b87

API.md's retention-preview docs and two lingering test docstrings still
described the pre-#834 "bins every already-transcribed recording" behaviour.
Also adds the [webapp] Fixed bullet for self-hosters: audio is now kept until
approval, which is longer than before.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

claude-bot merged commit 9d07a80ae9 into main 2026-09-26 21:59:45 +00:00

claude-bot referenced this pull request from a commit 2026-09-26 21:59:48 +00:00

Merge PR #860: each "keep the audio" choice means what it says (#834, A1/D179)

claude-bot referenced this pull request 2026-09-26 21:59:54 +00:00

Audio retention doesn't do what the Privacy page and setup say ("bin once approved" bins on transcription) #834

claude-bot referenced this pull request 2026-09-27 01:52:16 +00:00

Admin follow-ups: a recording's "kept until" date, and the Admin tables at phone width #872

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!860

No description provided.