A raw campaign DELETE works: quest_objectives' FK is deferred (#943) #957

Merged

claude-bot merged 2 commits from fix/943-quest-objectives-fk into main 2026-09-30 07:02:03 +00:00

Conversation 0 Commits 2 Files changed 6 +202 -42

claude-bot commented 2026-09-30 06:40:52 +00:00

Collaborator

Copy link

Closes #943.

Diagnosis confirmed: reproduced on main. A raw DELETE FROM campaigns fails when an objective has a done_session_id. The row is reached by two paths in one statement:

• CASCADE, via quest_objectives.lore_entry_id → quest_details.lore_entry_id;
• SET NULL, via sessions.

The SET NULL update then references a quest_details row that is already being deleted.

Fix: migration a9430d1e2f3b (down_revision 10e5f6a7b8c9, the single head) recreates quest_objectives_lore_entry_id_fkey with the same column, target and ON DELETE CASCADE, now DEFERRABLE INITIALLY DEFERRED. Downgrade restores it as not deferrable. The model's ForeignKey matches. Deferring that one constraint was enough.

The seed's workaround is gone: _delete_lane8_first was removed from demo/engine.py, and delete_demo's single DELETE FROM campaigns now covers everything, the GM copy (#954) included.

Tests:

• test_quest_objectives_fk_migration.py (new):
  • the head pin, moved here;
  • the raw-delete repro, with SET CONSTRAINTS ALL IMMEDIATE because the test rolls back. It fails on main.
  • upgrade/downgrade/upgrade in a scratch schema, checking condeferrable and condeferred.
• test_test_usage_migration.py's head pin is loosened to "the revision exists".
• The delegate's run: every module matching quest_objectives|QuestObjective|delete_demo|_migration, plus the seed, passed (1071).
• Re-run after merging main with #954: test_demo_seed, the new file and the usage-migration test pass (21).
• Real Alembic: upgrade head, downgrade -1, then upgrade head, with pg_constraint showing it deferrable and deferred.
• Lint and changelog: ruff check and format are clean, and changelog.py check passes.

Changelog: changelog.d/943-quest-objectives-fk.fixed.md.

🤖 Generated with Claude Code

Closes #943. **Diagnosis confirmed:** reproduced on main. A raw `DELETE FROM campaigns` fails when an objective has a `done_session_id`. The row is reached by two paths in one statement: - CASCADE, via `quest_objectives.lore_entry_id → quest_details.lore_entry_id`; - SET NULL, via `sessions`. The SET NULL update then references a `quest_details` row that is already being deleted. **Fix:** migration `a9430d1e2f3b` (down_revision `10e5f6a7b8c9`, the single head) recreates `quest_objectives_lore_entry_id_fkey` with the same column, target and `ON DELETE CASCADE`, now **`DEFERRABLE INITIALLY DEFERRED`**. Downgrade restores it as not deferrable. The model's `ForeignKey` matches. Deferring that one constraint was enough. **The seed's workaround is gone:** `_delete_lane8_first` was removed from `demo/engine.py`, and `delete_demo`'s single `DELETE FROM campaigns` now covers everything, the GM copy (#954) included. **Tests:** - `test_quest_objectives_fk_migration.py` (new): - the head pin, moved here; - the raw-delete repro, with `SET CONSTRAINTS ALL IMMEDIATE` because the test rolls back. It fails on main. - `upgrade`/`downgrade`/`upgrade` in a scratch schema, checking `condeferrable` and `condeferred`. - `test_test_usage_migration.py`'s head pin is loosened to "the revision exists". - **The delegate's run:** every module matching `quest_objectives|QuestObjective|delete_demo|_migration`, plus the seed, passed (1071). - **Re-run after merging main with #954:** `test_demo_seed`, the new file and the usage-migration test pass (21). - **Real Alembic:** upgrade head, downgrade -1, then upgrade head, with `pg_constraint` showing it deferrable and deferred. - **Lint and changelog:** ruff check and format are clean, and `changelog.py check` passes. Changelog: `changelog.d/943-quest-objectives-fk.fixed.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-09-30 06:40:53 +00:00

fix(webapp): defer quest_objectives lore_entry FK so raw campaign delete works (#943) ... 8efb2ed7e7

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into fix/943-quest-objectives-fk d1ff37eb3d

claude-bot merged commit 05f3be1e4f into main 2026-09-30 07:02:03 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 07:02:04 +00:00

Merge PR #957: a raw campaign DELETE works — quest_objectives' FK is deferred (#943)

claude-bot referenced this pull request 2026-09-30 07:02:05 +00:00

A raw DELETE of a campaign fails on quest_objectives (two cascade paths) #943

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!957

No description provided.