Lane 11 PR 6: content with structured fields, and a small character pack per system (#737) #968

Merged

claude-bot merged 10 commits from build/lane11-6-content into main 2026-09-30 11:47:06 +00:00

Conversation 0 Commits 10 Files changed 35 +4438 -163

claude-bot commented 2026-09-30 08:58:29 +00:00

Collaborator

Copy link

Lane 11 (#737) PR 6 (IS-401 content; D203; owner answers L1 and L8). Reference entries now carry the per-kind fields the sheet definitions read (#962, #963). It adds no migration: the column and the kinds came with #964.

Pipeline:

• app/reference/fields.py: checks the shapes the definitions read.
  • PF2e damage die is written "d6"; 5e hit_die is written as sides.
  • Action costs, lower-case 5e properties, and penalties ≤ 0.
  • A 32 KiB cap. Unknown keys pass through.
• Bad fields never reject a record. They're kept in extra.unvalidated_fields with a warning, as stats are.
• Export writes fields, so they survive a round trip.

Adapters:

• PF2e (foundry.py, foundry_maps/pf2e.py):
  • Covers: items, weapons, armour, shields, ammunition, feats, actions, spells, classes (levels in the definition's choose shape), ancestries, heritages, backgrounds and conditions.
  • Shapes as the fixtures have them: bulk L = 0.1 with bulk_per, {dice, die, type} damage, thrown weapons with range: null.
  • Conditions: modifiers come from Foundry's FlatModifier rules.
• 5e (open5e.py):
  • Covers: items, spells, feats, classes, species (as ancestry), backgrounds and conditions from SRD 5.2.1 records.
  • Upstream quirks handled: Open5e files the Shield as heavy armour, and its Fighter saving throws disagree with its own table.
• .qbpack records may carry fields directly.

Starter scripts (D203):

• PF2e: build_pf2e_starter.py adds Player Core's (and Player Core 2's) classes, ancestries, heritages, backgrounds, feats and equipment. Setting prose is stripped: ancestry, background and class descriptions are always dropped, and any description naming a reserved setting term is too.
• 5e: build_5e_starter.py takes srd-2024 only, with the single SRD 5.2.1 notice.
• Publishing: STARTERS stays empty. Publishing the full starters is a release step for the owner (L1). docs/OPERATIONS.md gains "Building the starter packs".

Mini character packs (one source, webapp/backend/tests/fixtures/packs/; the demo and e2e seeds read from here):

• Contents: pf2e-characters (68 entries, ORC) and dnd5e-characters (63 entries, SRD 5.2.1 CC BY): 3 classes, 3 ancestries, 3 heritages or species, 3 backgrounds, 15–17 feats, 20–21 items, 10 spells and the conditions.
• Every weapon and armour the definitions' fixtures name carries the fixtures' numbers.
• No setting proper nouns; the text is paraphrased mechanics.

Tests:

• New: test_reference_fields.py and tests/sheets/test_sheet_content_packs.py.
  • Each adapter maps a sample record to its exact fields.
  • Bad fields are demoted, and export round-trips.
  • Both packs import with no warnings.
• Evaluator: putting the imported rows on sheets reproduces the definitions' own fixtures (Ossian's AC 23, bulk 4.9 and strikes; Tam's AC 18, HP 31 and longsword).
• Server: the same through #964's routes.
• Run: every module that touches the adapters, the import service, ReferenceEntry, KINDS, packs or starters, plus tests/sheets: 1205 pass.
• Lint and changelog: ruff is clean (including alembic/), and changelog.py check passes.

What the adapters can't fill from upstream (it stays in extra):

• PF2e consumables' action cost and triggers, which are prose only;
• feat and heritage rule elements beyond flat condition modifiers;
• creature fields, which is PR 7's.

Changelog: changelog.d/737-lane11-content-fields.added.md.

🤖 Generated with Claude Code

Lane 11 (#737) PR 6 (IS-401 content; D203; owner answers L1 and L8). Reference entries now carry the per-kind `fields` the sheet definitions read (#962, #963). It adds no migration: the column and the kinds came with #964. **Pipeline:** - **`app/reference/fields.py`:** checks the shapes the definitions read. - PF2e damage `die` is written "d6"; 5e `hit_die` is written as sides. - Action costs, lower-case 5e properties, and penalties ≤ 0. - A 32 KiB cap. Unknown keys pass through. - **Bad fields never reject a record.** They're kept in `extra.unvalidated_fields` with a warning, as stats are. - **Export** writes `fields`, so they survive a round trip. **Adapters:** - **PF2e** (`foundry.py`, `foundry_maps/pf2e.py`): - **Covers:** items, weapons, armour, shields, ammunition, feats, actions, spells, classes (levels in the definition's `choose` shape), ancestries, heritages, backgrounds and conditions. - **Shapes as the fixtures have them:** bulk L = 0.1 with `bulk_per`, `{dice, die, type}` damage, thrown weapons with `range: null`. - **Conditions:** modifiers come from Foundry's `FlatModifier` rules. - **5e** (`open5e.py`): - **Covers:** items, spells, feats, classes, species (as `ancestry`), backgrounds and conditions from **SRD 5.2.1** records. - **Upstream quirks handled:** Open5e files the Shield as heavy armour, and its Fighter saving throws disagree with its own table. - **`.qbpack`** records may carry `fields` directly. **Starter scripts (D203):** - **PF2e:** `build_pf2e_starter.py` adds Player Core's (and Player Core 2's) classes, ancestries, heritages, backgrounds, feats and equipment. Setting prose is stripped: ancestry, background and class descriptions are always dropped, and any description naming a reserved setting term is too. - **5e:** `build_5e_starter.py` takes **srd-2024 only**, with the single SRD 5.2.1 notice. - **Publishing:** `STARTERS` stays empty. Publishing the full starters is a release step for the owner (L1). `docs/OPERATIONS.md` gains "Building the starter packs". **Mini character packs** (one source, `webapp/backend/tests/fixtures/packs/`; the demo and e2e seeds read from here): - **Contents:** `pf2e-characters` (68 entries, ORC) and `dnd5e-characters` (63 entries, SRD 5.2.1 CC BY): 3 classes, 3 ancestries, 3 heritages or species, 3 backgrounds, 15–17 feats, 20–21 items, 10 spells and the conditions. - **Every weapon and armour** the definitions' fixtures name carries the fixtures' numbers. - **No setting proper nouns**; the text is paraphrased mechanics. **Tests:** - **New:** `test_reference_fields.py` and `tests/sheets/test_sheet_content_packs.py`. - Each adapter maps a sample record to its exact `fields`. - Bad fields are demoted, and export round-trips. - **Both packs import with no warnings.** - **Evaluator:** putting the imported rows on sheets reproduces the definitions' own fixtures (Ossian's AC 23, bulk 4.9 and strikes; Tam's AC 18, HP 31 and longsword). - **Server:** the same through #964's routes. - **Run:** every module that touches the adapters, the import service, `ReferenceEntry`, `KINDS`, packs or starters, plus `tests/sheets`: **1205 pass**. - **Lint and changelog:** ruff is clean (including `alembic/`), and `changelog.py check` passes. **What the adapters can't fill from upstream** (it stays in `extra`): - PF2e consumables' action cost and triggers, which are prose only; - feat and heritage rule elements beyond flat condition modifiers; - creature `fields`, which is PR 7's. Changelog: `changelog.d/737-lane11-content-fields.added.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 9 commits 2026-09-30 08:58:31 +00:00

Merge branch 'build/lane11-3-server' into build/lane11-base e3764ef0e9

Merge branch 'build/lane11-4-js-evaluator' into build/lane11-base 6ef1ef1157

Merge branch 'build/lane11-5a-pf2e' into build/lane11-base df4ec052e2

Merge branch 'build/lane11-5b-5e' into build/lane11-base a49e6a1c5e

WIP lane 11 PR 6: reference fields — record field, per-kind check, Foundry pf2e and Open5e maps ... f06d153999

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP lane 11 PR 6: mini character packs (pf2e, dnd5e) and tests of fields on sheets ... 95e01c0bd2

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP lane 11 PR 6: starter scripts for D203 (Player Core character content, SRD 5.2.1 only) and their tests ... 88905af49a

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Lane 11 PR 6: content with structured fields — docs, changelog, formatting (#737) ... 6416da091e

Reference entries carry per-kind fields (contract 3.3) filled by the Foundry
pf2e and Open5e adapters and passed through from native packs, checked per
kind; ancestry/heritage kinds; the starter scripts build Player Core character
content (ORC, setting prose stripped) and SRD 5.2.1 only; a mechanics-only
mini character pack per system under tests/fixtures/packs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-6-content 286c84dcaf

rbrooks added 1 commit 2026-09-30 10:17:03 +00:00

Merge remote-tracking branch 'origin/main' into build/lane11-6-content 7836f20df5

claude-bot merged commit 055fbf0efd into main 2026-09-30 11:47:06 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 11:47:08 +00:00

Merge PR #968: lane 11 PR 6 — content on the sheet (#737)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!968

No description provided.