Lane 11 PR 7: today's stat blocks become blocks on the new sheets (#737, D205) #974

Merged

claude-bot merged 7 commits from build/lane11-7-convert into main 2026-09-30 16:00:06 +00:00

Conversation 0 Commits 7 Files changed 25 +3349 -473

claude-bot commented 2026-09-30 13:10:46 +00:00

Collaborator

Copy link

Part of #737 (lane 11, character sheets), PR 7 of the build contract (docs/design/lane11-build-contract.md).

What changes

• Data migration 11b2c3d4e5f6 (chains on 11a1b2c3d4e5). Every person's and creature's lore_entries.stats becomes a creature sheet for its game, via legacy.py's legacy_map: PF2e, 5e, a pack's system, or the generic block when the game is gone.
  • Who can see it: a public block becomes table-visible (D205, L-decision "table" not "party"); a GM-only or player-private block stays GM.
  • Nothing is lost: the old block is kept with the sheet, and values that don't fit are kept aside.
  • Downgrade: implemented and tested.
• Lazy rebuild: the page's block projection is rebuilt the first time it's opened. python -m app.sheets.rebuild_projections [--dry-run] does it on demand, and the worker runs it once at start.
• Compat shim: until PR 13 removes the old editor, the page's stats input on create and update is translated through legacy_map into the page's creature sheet. The stat block editor, the importer, "Stat block" and "Convert stats" work on the sheet.
• Drafts: a drafted stat block fills the block's fields, and on approval lands on the page's sheet instead of in its text.
• Edge case: a block nobody may read projects to nothing.

Checks

• Locally, after merging main: tests/sheets, the content-pack suites, the lore suites and test_quest_objectives_fk_migration: 861 passed.
• Migrations: alembic upgrade head gives a single head 11b2c3d4e5f6, and downgrade -1 / upgrade head round-trips.
• Ruff 0.4.4 check and format are clean, including alembic/.
• New tests/sheets/test_stat_block_conversion.py, which moves the one-head pin.
• Changelog: changelog.d/737-lane11-*convert* (added).

PR 8 (packs) is stacked on this and re-points its migration 11c3d4e5f6a7 onto 11b2c3d4e5f6.

🤖 Generated with Claude Code

Part of #737 (lane 11, character sheets), PR 7 of the build contract (`docs/design/lane11-build-contract.md`). **What changes** - **Data migration `11b2c3d4e5f6`** (chains on `11a1b2c3d4e5`). Every person's and creature's `lore_entries.stats` becomes a creature sheet for its game, via `legacy.py`'s `legacy_map`: PF2e, 5e, a pack's system, or the generic block when the game is gone. - **Who can see it:** a public block becomes table-visible (D205, L-decision "table" not "party"); a GM-only or player-private block stays GM. - **Nothing is lost:** the old block is kept with the sheet, and values that don't fit are kept aside. - **Downgrade:** implemented and tested. - **Lazy rebuild:** the page's block projection is rebuilt the first time it's opened. `python -m app.sheets.rebuild_projections [--dry-run]` does it on demand, and the worker runs it once at start. - **Compat shim:** until PR 13 removes the old editor, the page's `stats` input on create and update is translated through `legacy_map` into the page's creature sheet. The stat block editor, the importer, "Stat block" and "Convert stats" work on the sheet. - **Drafts:** a drafted stat block fills the block's fields, and on approval lands on the page's sheet instead of in its text. - **Edge case:** a block nobody may read projects to nothing. **Checks** - Locally, after merging main: `tests/sheets`, the content-pack suites, the lore suites and `test_quest_objectives_fk_migration`: 861 passed. - Migrations: `alembic upgrade head` gives a single head `11b2c3d4e5f6`, and `downgrade -1` / `upgrade head` round-trips. - Ruff 0.4.4 check and format are clean, including `alembic/`. - New `tests/sheets/test_stat_block_conversion.py`, which moves the one-head pin. - Changelog: `changelog.d/737-lane11-*convert*` (added). PR 8 (packs) is stacked on this and re-points its migration `11c3d4e5f6a7` onto `11b2c3d4e5f6`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-09-30 13:10:46 +00:00

WIP lane 11 PR 7: stat blocks become sheets — shim, lazy rebuild, drafts target the block (#737) ... de5c2dc7d5

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP lane 11 PR 7: data migration 11b2c3d4e5f6 (D205), CLI and worker pass (#737) ... f4ef2a0851

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP lane 11 PR 7: conversion tests; a block nobody may read projects to nothing (#737) ... 7292355f2e

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

lane 11 PR 7: today's stat blocks become blocks (D205), and drafts target the block (#737) ... 3d5624813d

Data migration 11b2c3d4e5f6 (down_revision 11a1b2c3d4e5) inserts the built-in
definitions, explodes non-builtin systems' legacy schemas into generated
creature definitions, and converts every npc/creature page's legacy stat
envelope into a creature sheet under the system it was written for, keeping
who could see it (public -> table, gm/player_private -> gm), the old envelope
in source_ref.legacy and anything that didn't fit in legacy_unmapped. stats is
untouched; projections rebuild lazily on read, by
python -m app.sheets.rebuild_projections, and once at worker start.

LoreEntryCreate/Update.stats is now a compat shim into the page's sheet; the
importer checks creatures against the creature definition; generate_statblock
and convert_stats target the creature definition's draft_fields, route #20
drafts a block, and approval writes the sheet.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-7-convert 751c2377f3

Merge remote-tracking branch 'origin/main' into build/lane11-7-convert 7a239fbe50

rbrooks added 1 commit 2026-09-30 14:36:19 +00:00

Lane 11 PR 7: rebuild_projections takes a task session, not the pooled factory (#737, #129) ... a4952f83f2

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit d1c724d04e into main 2026-09-30 16:00:06 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 16:00:09 +00:00

Merge PR #974: lane 11 PR 7 — today's stat blocks become blocks on the new sheets (#737, D205)

claude-bot referenced this pull request 2026-09-30 16:18:31 +00:00

Lane 11 PR 8: content packs can carry sheet definitions (pack format v2) (#737) #977

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!974

No description provided.