Lane 11 PR 10: edit a sheet, and it saves itself (#737) #975

Merged

claude-bot merged 6 commits from build/lane11-10-editing into main 2026-09-30 15:07:19 +00:00

Conversation 0 Commits 6 Files changed 34 +2836 -76

claude-bot commented 2026-09-30 13:31:52 +00:00

Collaborator

Copy link

Part of #737 (lane 11, character sheets), PR 10 of the build contract. It builds on PR 9 (#972, merged).

What's new

• Edit mode: source fields become inputs of the right kind:

  • numbers, with the definition's min/max/step and a message before sending;
  • text;
  • choices that also accept a name of your own;
  • ranks as pips you press;
  • add/remove rows on the generic sheet.

  Worked-out figures stay text and update live as you type (live.js runs the JS evaluator).

• Autosave: there is no Save button. The save line shows Saving…, Saved at, or Not saved with Try again, and is blank until the first save. A draft is kept on the device until it lands (editState.js, useSheetEditor.js), and there is a leave guard.

• Conflicts: if someone else saved first, ConflictPanel shows both values of each field. Keep mine or Use theirs, and focus then returns to the save line.

• Locks: the GM can lock a field or a group, and the player sees it as locked. A refused save reverts the input, and the save line warns "Not saved. That part of the sheet is the GM's to change."

• Audience: each group with its own audience gets the audience picker.

• Versions: every save is a version, and any of them can be put back from Versions.

• Make a sheet: shown on a person's or creature's page with no sheet, for the GM and for the character's own player.

• Accessibility:

  • Field and cell errors are tied to their inputs with aria-describedby.
  • The label sits in a row above each control, with Lock beside it.
  • Long names wrap. App bar crumb segments ellipsise and carry their full text in title.

• Lane 0:

  • SaveState gains note and blank.
  • AudiencePicker radios are 24×24.
  • AppBar crumb truncation.
  • Derivation prints a constant term once.

Checks

• Render-checked twice at 390×844 and 1440 in both themes, as Priya (player) and Dana (GM). The first round found nine faults; the re-render shows all nine fixed, axe clean, no page overflow.
• Also re-checked /design AudiencePicker and normal-length crumbs on other pages.
• Full vitest passes, and lint has 0 errors.
• Changelog: changelog.d/737-lane11-sheet-editing.added.md. CATALOGUE and ledger updated.

🤖 Generated with Claude Code

Part of #737 (lane 11, character sheets), PR 10 of the build contract. It builds on PR 9 (#972, merged). **What's new** - **Edit mode:** source fields become inputs of the right kind: - numbers, with the definition's min/max/step and a message before sending; - text; - choices that also accept a name of your own; - ranks as pips you press; - add/remove rows on the generic sheet. Worked-out figures stay text and update live as you type (`live.js` runs the JS evaluator). - **Autosave:** there is no Save button. The save line shows Saving…, Saved at, or Not saved with Try again, and is blank until the first save. A draft is kept on the device until it lands (`editState.js`, `useSheetEditor.js`), and there is a leave guard. - **Conflicts:** if someone else saved first, `ConflictPanel` shows both values of each field. Keep mine or Use theirs, and focus then returns to the save line. - **Locks:** the GM can lock a field or a group, and the player sees it as locked. A refused save reverts the input, and the save line warns "Not saved. That part of the sheet is the GM's to change." - **Audience:** each group with its own audience gets the audience picker. - **Versions:** every save is a version, and any of them can be put back from Versions. - **Make a sheet:** shown on a person's or creature's page with no sheet, for the GM and for the character's own player. - **Accessibility:** - Field and cell errors are tied to their inputs with `aria-describedby`. - The label sits in a row above each control, with Lock beside it. - Long names wrap. App bar crumb segments ellipsise and carry their full text in `title`. - **Lane 0:** - `SaveState` gains `note` and `blank`. - `AudiencePicker` radios are 24×24. - `AppBar` crumb truncation. - `Derivation` prints a constant term once. **Checks** - Render-checked twice at 390×844 and 1440 in both themes, as Priya (player) and Dana (GM). The first round found nine faults; the re-render shows all nine fixed, axe clean, no page overflow. - Also re-checked `/design` AudiencePicker and normal-length crumbs on other pages. - Full vitest passes, and lint has 0 errors. - Changelog: `changelog.d/737-lane11-sheet-editing.added.md`. CATALOGUE and ledger updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-09-30 13:31:53 +00:00

Lane 11 PR 10 WIP: sheet editing (autosave, inputs, locks, audiences, versions, make a sheet), crumb/print/first-name fixes, Derivation constant ... 1c49894b53

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 10: sheet editing tests, Make a sheet on the article, catalogue row IS-463, changelog ... 3ea5786b61

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 10: leave-guard caller list, first-name pill and print tests, rank label ... b19bca4ed9

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-10-editing c90a17f781

Lane 11 PR 10 render-check fixes: long names wrap and crumbs ellipsise, audience picker out of the heading with 24px radios, focus after the conflict choice, a refused save reverts and warns, cell errors described, number limits before saving, stacked field layout, blank save line, no Sheet label without a sheet ... 1d753aab4f

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-10-editing 8bc9f79cff

claude-bot merged commit 6472b8188b into main 2026-09-30 15:07:19 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 15:07:21 +00:00

Merge PR #975: lane 11 PR 10 — edit a sheet, and it saves itself (#737)

claude-bot referenced this pull request 2026-09-30 15:08:01 +00:00

Lane 11 PR 11: the sheet at the table — hit points, conditions, spells, rests, add from content (#737) #976

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!975

No description provided.