#92 - v1.0.2 — Alert correctness & integrity - rbrooks/WeatherBot

claude-bot commented

2026-07-18 06:51:27 +00:00

Contributor

Patch release fixing the highest-severity alert-pipeline defects from the 2026-07-17 codebase audit. Bug fixes only, no new features.

Fixes

Issue	Finding	Fix
#40	F-01	Transient NWS fetch failure mass-cleared all active alerts (false all-clears during live warnings). Fetches now retry with jittered backoff and return `None` on failure; the poll cycle is skipped (no clearing/dispatch). Mass-clear gated on non-empty locations; alerts with no `ends`/`expires` get a synthetic 6h expiry.
#41	F-02	`/alerts/active` pagination now followed (bounded to 10 pages, logged) so large outbreaks aren't truncated to page one and then cleared as "disappeared".
#42	F-03	SPC convective outlooks record/dispatch per day (1/2/3) instead of collapsing to the single highest risk — lower-risk same-day outlooks are no longer dropped.
#43	F-04	MCD state matching parses the `AREAS AFFECTED` line instead of the whole narrative, so "in"/"or" no longer match Indiana/Oregon.
#44	F-05	Same-risk SPC reissuance treated as a continuation (row refreshed, no re-dispatch) — ends duplicate notifications and orphaned dashboard rows.
#48	F-09	Channel deletion preserves `sent_alerts` history (DB `SET NULL`) instead of cascade-deleting it.
#49	F-10	Public location page server-renders current active alerts with a "No active alerts" empty state instead of "Loading alerts…" forever.
#54	F-15	Details-link generation guarded at every notifier call site (all six channels) — a link failure sends without a link instead of dropping the alert.
#62	F-23	Per-feature SPC parsing and gathers made failure-tolerant — one malformed upstream feature is skipped, not fatal to the whole poll.

Testing

Full suite green on the dev server (Postgres-deps venv, all channels installed): 344 passed, including 27 new regression tests across the five fix areas — false-all-clear injection, pagination, cross-day SPC, MCD collision words, same-risk reissuance, channel-delete history, public-page backfill, per-channel link-failure injection, and malformed-feature skip.

Notes

F-15 (#54) was found partly stale — the details-link helper is already internally guarded — so the change is defense-in-depth at the call sites plus regression tests; signal was added for full six-channel parity.
The sent_alerts history test asserts the ORM no longer cascade-deletes; the DB-level SET NULL semantics are authoritative on Postgres (SQLite test tier doesn't enforce FKs).

Closes #40, #41, #42, #43, #44, #48, #49, #54, #62

🤖 Generated with Claude Code

Patch release fixing the highest-severity alert-pipeline defects from the 2026-07-17 codebase audit. **Bug fixes only, no new features.** ## Fixes | Issue | Finding | Fix | |---|---|---| | #40 | F-01 | Transient NWS fetch failure mass-cleared all active alerts (false all-clears during live warnings). Fetches now retry with jittered backoff and return `None` on failure; the poll cycle is skipped (no clearing/dispatch). Mass-clear gated on non-empty locations; alerts with no `ends`/`expires` get a synthetic 6h expiry. | | #41 | F-02 | `/alerts/active` pagination now followed (bounded to 10 pages, logged) so large outbreaks aren't truncated to page one and then cleared as "disappeared". | | #42 | F-03 | SPC convective outlooks record/dispatch **per day** (1/2/3) instead of collapsing to the single highest risk — lower-risk same-day outlooks are no longer dropped. | | #43 | F-04 | MCD state matching parses the `AREAS AFFECTED` line instead of the whole narrative, so "in"/"or" no longer match Indiana/Oregon. | | #44 | F-05 | Same-risk SPC reissuance treated as a continuation (row refreshed, no re-dispatch) — ends duplicate notifications and orphaned dashboard rows. | | #48 | F-09 | Channel deletion preserves `sent_alerts` history (DB `SET NULL`) instead of cascade-deleting it. | | #49 | F-10 | Public location page server-renders current active alerts with a "No active alerts" empty state instead of "Loading alerts…" forever. | | #54 | F-15 | Details-link generation guarded at every notifier call site (all six channels) — a link failure sends without a link instead of dropping the alert. | | #62 | F-23 | Per-feature SPC parsing and gathers made failure-tolerant — one malformed upstream feature is skipped, not fatal to the whole poll. | ## Testing Full suite green on the dev server (Postgres-deps venv, all channels installed): **344 passed**, including **27 new regression tests** across the five fix areas — false-all-clear injection, pagination, cross-day SPC, MCD collision words, same-risk reissuance, channel-delete history, public-page backfill, per-channel link-failure injection, and malformed-feature skip. ## Notes - F-15 (#54) was found partly stale — the details-link helper is already internally guarded — so the change is defense-in-depth at the call sites plus regression tests; `signal` was added for full six-channel parity. - The `sent_alerts` history test asserts the ORM no longer cascade-deletes; the DB-level `SET NULL` semantics are authoritative on Postgres (SQLite test tier doesn't enforce FKs). Closes #40, #41, #42, #43, #44, #48, #49, #54, #62 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits

2026-07-18 06:51:28 +00:00

Fix NWS fetch failures causing false all-clears and dropped outbreak alerts a046af24b3

A failed /alerts/active fetch returned [] indistinguishable from an empty
feed, so one transient NWS error cleared every active alert (all-clears
during live warnings) and re-alerted next poll. fetch_alerts_for_states now
retries with jittered backoff and returns None on failure; poll_alerts_job
skips the cycle (no clearing, no dispatch) on None. The mass-clear path is
also gated on a non-empty locations list, and alerts with no ends/expires
get a synthetic 6h expiry so they stay visible and clearable.

Also follow /alerts/active pagination (bounded to 10 pages, logged) so
large multi-state outbreaks aren't truncated to page one and then cleared
as "disappeared". api/alerts.py handles the new None contract.

Closes #40, #41

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Fix SPC outlook/MCD correctness bugs e8dce98a8b

- Convective outlooks now record and dispatch per day (1/2/3) instead of
  collapsing to the single globally-highest risk, so a lower-risk same-day
  outlook is no longer dropped when a later day is higher (#42).
- MCD state matching parses the AREAS AFFECTED line instead of scanning the
  whole narrative, so "in"/"or" no longer match Indiana/Oregon (#43).
- Same-risk SPC reissuance is treated as a continuation (row refreshed, no
  re-dispatch) instead of a new outlook, ending duplicate notifications and
  orphaned dashboard rows (#44).
- Per-feature parsing and the SPC gathers are failure-tolerant, so one
  malformed upstream feature is skipped rather than aborting the poll (#62).

Closes #42, #43, #44, #62

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Preserve sent_alerts history when a channel is deleted 7d6b1e37a5

The sent_alerts relationship declared cascade="all, delete-orphan", which
overrode the DB FK's ON DELETE SET NULL and hard-deleted alert history on
channel deletion. Drop the cascade and set passive_deletes=True so deleting
a channel leaves its rows as dashboard-only records (channel_id NULL).

Closes #48

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Render current active alerts on the public location page b4dca0ca7c

The public page relied solely on SSE deltas, so a visitor during an active
alert saw "Loading alerts…" forever and pre-existing alerts never appeared.
Server-render the location's current active alerts with an explicit
"No active alerts" empty state, keeping SSE (de-duped by alert id) for live
updates.

Closes #49

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Guard details-link generation in all notifier channels 8100c36631

The details-link helper is internally guarded, but the richer channels
awaited it without a local guard, so any future regression could abort the
send and permanently drop the alert. Wrap the call at every site (all six
channels, including signal) as SMS already does: on failure, log and send
without a link. Adds a failure-injection regression test per channel.

Closes #54

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Add v1.0.2 changelog entry

CI / test (pull_request) Successful in 4m39s

Details

deb996bf5c

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

claude-bot merged commit 53240035f3 into main

2026-07-18 06:56:42 +00:00

claude-bot deleted branch fix/v1.0.2-alert-correctness

2026-07-18 06:56:43 +00:00

claude-bot referenced this pull request from a commit

2026-07-18 06:56:45 +00:00

Merge pull request 'v1.0.2 — Alert correctness & integrity' (#92) from fix/v1.0.2-alert-correctness into main

claude-bot referenced this pull request

2026-07-18 06:57:14 +00:00

Alert clearing treats NWS fetch failure as "no active alerts" — mass false all-clears #40

claude-bot referenced this pull request

2026-07-18 06:57:16 +00:00

Follow NWS /alerts/active pagination — alerts beyond page 1 are dropped then falsely cleared #41

claude-bot referenced this pull request

2026-07-18 06:57:18 +00:00

SPC convective notifications collapse Day 1/2/3 into one — lower-day risk silently dropped #42

claude-bot referenced this pull request

2026-07-18 06:57:21 +00:00

MCD state extraction matches "in"/"or" as Indiana/Oregon — anchor to AREAS AFFECTED #43

claude-bot referenced this pull request

2026-07-18 06:57:23 +00:00

Same-risk SPC reissuance treated as new outlook — duplicate notifications + orphaned rows #44

claude-bot referenced this pull request

2026-07-18 06:57:26 +00:00

Channel deletion cascades away sent_alerts history that the DB was designed to keep #48

claude-bot referenced this pull request

2026-07-18 06:57:29 +00:00

Public location page shows "Loading alerts…" forever — never fetches current alerts #49

claude-bot referenced this pull request

2026-07-18 06:57:32 +00:00

Guard details-link generation in richer notifiers — a link failure currently drops the alert #54

claude-bot referenced this pull request

2026-07-18 06:57:35 +00:00

Harden SPC parsing — one malformed feature currently aborts the whole poll cycle #62

Rows
Columns

v1.0.2 — Alert correctness & integrity #92

Fixes

Testing

Notes