Wiki health: "Link it" on an unlinked mention opens the editor instead of making the link #1157

New issue

Closed

opened 2026-10-13 01:03:00 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-13 01:03:00 +00:00

Collaborator

Found by the owner on prod (v4.5.0), 2026-10-13: "when I go through the Unlinked Mentions in the wiki health it's not auto-linking to the suggested page when I hit Link It."

What it does today

webapp/frontend/src/pages/wiki/Health.jsx (~233): the row's "Link it" is a plain link to the mentioning page's editor (/wiki/{from.id}/edit). Nothing is linked. In the editor the GM has to find the same mention among the editor's own link suggestions (pages/wiki/EditorParts.jsx ~150, which has a second "Link it" that does apply one, through utils/wikiLinkSuggestions.js::applySuggestionToBody) and then save. The file's own header describes this ("Link it — the page that mentions it, in the editor"), so it was built as designed; the design is what is wrong: a button that says "Link it" should link it.

What it should do (4.5.1)

"Link it" makes the link, in place, in one press:

The server wraps the first bare mention of the target page's title (or one of its aliases) in the mentioning page as a wiki link, using the same matching Wiki health used to find it (services/wiki_health.py::_unlinked_mentions, _mentions), and saves it as an ordinary edit by that GM: a version, the link index, the page's events, as any Save does.
The row leaves the list, with a short line saying where it was linked and an Undo, as the app does elsewhere.
If the page changed since the report was drawn and the mention is gone, it says so and the row goes.
The page's name in the row stays the way to open the page itself.

Found by the owner on prod (v4.5.0), 2026-10-13: "when I go through the Unlinked Mentions in the wiki health it's not auto-linking to the suggested page when I hit Link It." ## What it does today `webapp/frontend/src/pages/wiki/Health.jsx` (~233): the row's "Link it" is a plain link to the mentioning page's editor (`/wiki/{from.id}/edit`). Nothing is linked. In the editor the GM has to find the same mention among the editor's own link suggestions (`pages/wiki/EditorParts.jsx` ~150, which has a second "Link it" that does apply one, through `utils/wikiLinkSuggestions.js::applySuggestionToBody`) and then save. The file's own header describes this ("Link it — the page that mentions it, in the editor"), so it was built as designed; the design is what is wrong: a button that says "Link it" should link it. ## What it should do (4.5.1) "Link it" makes the link, in place, in one press: - The server wraps the first bare mention of the target page's title (or one of its aliases) in the mentioning page as a wiki link, using the same matching Wiki health used to find it (`services/wiki_health.py::_unlinked_mentions`, `_mentions`), and saves it as an ordinary edit by that GM: a version, the link index, the page's events, as any Save does. - The row leaves the list, with a short line saying where it was linked and an Undo, as the app does elsewhere. - If the page changed since the report was drawn and the mention is gone, it says so and the row goes. - The page's name in the row stays the way to open the page itself.

claude-bot added this to the v4.5.1 - Fixes after the redesign milestone

2026-10-13 01:03:36 +00:00