fix(webapp): "Link it" on Wiki health makes the link (#1157) #1164

Merged

claude-bot merged 20 commits from fix/1157-wiki-health-link-it into main 2026-10-13 03:42:37 +00:00

Conversation 0 Commits 20 Files changed 16 +1553 -39

claude-bot commented 2026-10-13 02:20:35 +00:00

Collaborator

Copy link

Closes #1157 (D301).

"Link it" beside an unlinked mention used to open the editor. It now makes the link in one press, with Undo.

• Route: POST /campaigns/{id}/lore/{entry_id}/link-mention {to}, GM only. Saves through update_lore_entry as the acting GM (version row, link index, wiki event), and writes an audit event lore.mention_linked.
• What is written: [[Title]] when the words equal the title exactly, else [[Title|the words]], so the GM's prose is kept. The editor's own suggestion now does the same.
• What counts as a mention: wiki_health._bare_text blanks everything a renderer does not draw as prose (code, fences, links and embeds, web links and images, footnotes and their definitions, anchors, headings, marker lines). Where the server's reading and the frontend's could differ, the text is treated as not prose. The report and the route share it, so such mentions also leave the report.
• Refusals: a target not shared with the table (422, so a hidden title never lands in text a player can read); an ambiguous title with no unique alias; a result over the body limit; a mention that is gone (409). Missing, other-campaign and trashed pages give the same 404.
• Undo: the existing restore route with a new optional ?if_version_id=; refused with 409 if the page has changed since. The comparison is now made under the row lock.

Additive only; no bot contract change, no migration.

Review

An independent review found two must-fix defects (headings; footnote definitions masking a later mention) and nine smaller ones (blockquote grouping, fence disagreements, length caps, !/\ prefixes, unlinkable titles, two concurrency gaps, body limit and audit, Health page focus and refresh, editor agreement). All eleven are fixed, each with a test using the reviewer's input. The review found no authorisation or disclosure problem and no super-linear pattern at 200,000 characters.

Verified

On docker-test: tests/wiki in full (1626 passed, 1 failed: a title-reader guard, then fixed; only that file and two others were re-run, 92 passed). Ruff clean. Frontend lint clean, full vitest 4017 passed. Changelog check OK.

Not run: e2e/j8-wiki-health-link-it.spec.js (CI will); no race test for the locking.

Known limits: a pair whose only mentions sit in quote lines, lists or near a length cap can still be listed while the route refuses; it never writes wrongly. The audit row is a second commit after the link.

🤖 Generated with Claude Code

Closes #1157 (D301). "Link it" beside an unlinked mention used to open the editor. It now makes the link in one press, with Undo. - **Route**: `POST /campaigns/{id}/lore/{entry_id}/link-mention {to}`, GM only. Saves through `update_lore_entry` as the acting GM (version row, link index, wiki event), and writes an audit event `lore.mention_linked`. - **What is written**: `[[Title]]` when the words equal the title exactly, else `[[Title|the words]]`, so the GM's prose is kept. The editor's own suggestion now does the same. - **What counts as a mention**: `wiki_health._bare_text` blanks everything a renderer does not draw as prose (code, fences, links and embeds, web links and images, footnotes and their definitions, anchors, headings, marker lines). Where the server's reading and the frontend's could differ, the text is treated as not prose. The report and the route share it, so such mentions also leave the report. - **Refusals**: a target not shared with the table (422, so a hidden title never lands in text a player can read); an ambiguous title with no unique alias; a result over the body limit; a mention that is gone (409). Missing, other-campaign and trashed pages give the same 404. - **Undo**: the existing restore route with a new optional `?if_version_id=`; refused with 409 if the page has changed since. The comparison is now made under the row lock. Additive only; no bot contract change, no migration. ## Review An independent review found two must-fix defects (headings; footnote definitions masking a later mention) and nine smaller ones (blockquote grouping, fence disagreements, length caps, `!`/`\` prefixes, unlinkable titles, two concurrency gaps, body limit and audit, Health page focus and refresh, editor agreement). All eleven are fixed, each with a test using the reviewer's input. The review found no authorisation or disclosure problem and no super-linear pattern at 200,000 characters. ## Verified On `docker-test`: `tests/wiki` in full (1626 passed, 1 failed: a title-reader guard, then fixed; only that file and two others were re-run, 92 passed). Ruff clean. Frontend lint clean, full vitest 4017 passed. Changelog check OK. Not run: `e2e/j8-wiki-health-link-it.spec.js` (CI will); no race test for the locking. Known limits: a pair whose only mentions sit in quote lines, lists or near a length cap can still be listed while the route refuses; it never writes wrongly. The audit row is a second commit after the link. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 17 commits 2026-10-13 02:20:35 +00:00

wip(webapp): Link it route for Wiki health (#1157) ... 7cb61846c9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: tests 52711289f6

wip: bounded blanking, disclosure tests 2a6e85ed59

wip: simplify ec1ee912f9

wip: paragraph-level blanking in renderer order, write checks 2b1650e93b

wip: tests 6be9ed7490

wip: only table-visible pages are named in text 5221b691fd

wip(webapp): Link it button, quiet line, Undo (#1157) 89eacc0704

wip: docs, changelog, journey (#1157) 72c44748b0

wip: lint fixes 92bc3614eb

style: ruff format (#1157) 93bc5a7374

wip: reviewer fixes, backend 56f81fd00e

wip: reviewer fixes, frontend 7d59b468a0

wip: fix flush ee189cd73f

wip: tests d32269eac0

style: ruff (#1157) 91e0f4ebac

test: list the title read in the report (#1157) 0329af3b1b

rbrooks added 2 commits 2026-10-13 02:21:30 +00:00

Merge remote-tracking branch 'origin/main' into fix/1157-wiki-health-link-it 6e13053c31

fix(e2e): j8 spec takes a fixture argument, uses the seeded campaign name (#1157) ... 52d2c63842

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-13 02:50:39 +00:00

fix(e2e): j8 reads the page from the GET's entry wrapper (#1157) ... c92b99954e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 337704125d into main 2026-10-13 03:42:37 +00:00

claude-bot deleted branch fix/1157-wiki-health-link-it 2026-10-13 03:42:38 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 03:42:38 +00:00

Merge PR #1164: "Link it" on Wiki health makes the link (#1157)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1164

No description provided.