Small things seen in the 4.5.1-rc1 render check #1175

New issue

Closed

opened 2026-10-13 17:04:22 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-13 17:04:22 +00:00

Collaborator

From the render check of v4.5.1-rc1 on the seeded stack (13 Oct), at 390x844 and 1280x800. None blocks 4.5.1; none is new in it unless marked.

"Nobody has answered yet." when the GM has. On a confirmed session where the only answer is the GM's own "Yes", the line under the title still reads "Nobody has answered yet." and the roster heading reads "0 of 0 have answered", beside the GM's row marked "In". The count leaves the GM out; the sentence should not contradict the row. With no players at all, "0 of 0 have answered" wants its own wording or no count.
The map on a phone: one target under 24 px (axe target-size, serious, 1 element, both themes). Belongs with #367.
/favicon.ico answers 200 with the app's HTML. The page links /favicon.png, which is right; a browser or crawler asking for .ico gets a page. Serve the icon or a 404.
New in 4.5.1, wording only: "The bot needs updating before it can post this reminder." is what a GM sees when the bot does not list the nudge feature (#1158). True after a backend-only upgrade; check it reads right to a GM who cannot update anything, and that it never shows when both images are 4.5.1.

Clean in the same check: no image was blocked under img-src 'self' (map tiles, an uploaded picture in an article and in the editor preview, the shell's icons); the delete dialog and Manage menu; the nudge setting on and off in both themes; Link it, Undo and "Put back."; the Sessions list; the move form; the empty bell. No horizontal overflow at 390 px anywhere, and no console errors beyond the expected 401 signed out and the 409 behind item 4.

From the render check of `v4.5.1-rc1` on the seeded stack (13 Oct), at 390x844 and 1280x800. None blocks 4.5.1; none is new in it unless marked. 1. **"Nobody has answered yet." when the GM has.** On a confirmed session where the only answer is the GM's own "Yes", the line under the title still reads "Nobody has answered yet." and the roster heading reads "0 of 0 have answered", beside the GM's row marked "In". The count leaves the GM out; the sentence should not contradict the row. With no players at all, "0 of 0 have answered" wants its own wording or no count. 2. **The map on a phone: one target under 24 px** (axe `target-size`, serious, 1 element, both themes). Belongs with #367. 3. **`/favicon.ico` answers 200 with the app's HTML.** The page links `/favicon.png`, which is right; a browser or crawler asking for `.ico` gets a page. Serve the icon or a 404. 4. **New in 4.5.1, wording only:** "The bot needs updating before it can post this reminder." is what a GM sees when the bot does not list the nudge feature (#1158). True after a backend-only upgrade; check it reads right to a GM who cannot update anything, and that it never shows when both images are 4.5.1. Clean in the same check: no image was blocked under `img-src 'self'` (map tiles, an uploaded picture in an article and in the editor preview, the shell's icons); the delete dialog and Manage menu; the nudge setting on and off in both themes; Link it, Undo and "Put back."; the Sessions list; the move form; the empty bell. No horizontal overflow at 390 px anywhere, and no console errors beyond the expected 401 signed out and the 409 behind item 4.