rbrooks/Quest-Board

Watch

This week's "2 of 3 have answered" counts the GM #1202

New issue

Closed

opened 2026-10-17 04:21:15 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-17 04:21:15 +00:00

Collaborator

Seen on prod by the owner after 4.5.1. The campaign's This week page counts the GM in its "N of M have answered" line under the next session's "Are you in?". 4.5.1 (#1175, PR #1176) fixed the same count on the session page to count players only ("4 of 5 players have answered"; "No players have answered yet." when only the GM has; no count at all when there are no players). This week should follow the same rule and wording, ideally through one shared helper so the two can't drift again.

Done when This week and the session page agree, with a test for each of the three cases. Part of 4.6.0.

Seen on prod by the owner after 4.5.1. The campaign's This week page counts the GM in its "N of M have answered" line under the next session's "Are you in?". 4.5.1 (#1175, PR #1176) fixed the same count on the session page to count players only ("4 of 5 players have answered"; "No players have answered yet." when only the GM has; no count at all when there are no players). This week should follow the same rule and wording, ideally through one shared helper so the two can't drift again. Done when This week and the session page agree, with a test for each of the three cases. Part of 4.6.0.

claude-bot added this to the v4.6.0 - Calendar, Templates & Table Tools milestone

2026-10-17 04:21:22 +00:00

rbrooks referenced this issue from a commit

2026-10-17 06:02:23 +00:00

fix(webapp): This week counts players only in the answered line, through one shared helper (#1202)

claude-bot referenced this issue from a pull request that will close it,

2026-10-17 06:07:27 +00:00

fix(webapp): This week counts players, not the GM, in "Are you in?" (#1202) #1204

rbrooks referenced this issue from a commit

2026-10-17 06:34:49 +00:00

test(e2e): J1 reads the players-only count (#1202)

claude-bot closed this issue

2026-10-17 07:13:15 +00:00

claude-bot referenced this issue from a commit

2026-10-17 07:13:16 +00:00

Merge PR #1204: This week counts players, not the GM (#1202)

claude-bot referenced this issue

2026-10-17 17:02:34 +00:00

chore(release): v4.6.0-rc1 #1216

claude-bot referenced this issue

2026-10-17 20:14:02 +00:00

fix: a vote-mode switch keeps approved sessions' picks; This week counts players still deciding (4.6.0-rc2) #1218

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board#1202

No description provided.