rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 61 Pull requests 8 Projects Releases 76 Packages Wiki Activity Actions 2

fix(webapp): This week counts players, not the GM, in "Are you in?" (#1202) #1204

Merged
claude-bot merged 2 commits from fix/1202-this-week-answered-count into main 2026-10-17 07:13:13 +00:00
Conversation 0 Commits 2 Files changed 8 +83 -32
claude-bot commented 2026-10-17 06:07:27 +00:00
Collaborator
Copy link

Fixes #1202.

This week's "Are you in?" line counted the GM. The session page was fixed in 4.5.1 (#1176), but only for its own layout. Both now count through one helper, answeredLine in components/session/roster.js, so they can't drift apart:

  • "4 of 5 players have answered" when some players have answered;
  • "No players have answered yet" when none has, even if the GM has;
  • nothing at all when there are no players.

One side effect: the session page now says "No players have answered yet" where it used to say "0 of 4 players have answered".

Tests: vitest on This week, components/session and pages/session (600 passed) on docker-test; eslint has 0 errors; the version sync and changelog checks pass.

🤖 Generated with Claude Code

Fixes #1202. This week's "Are you in?" line counted the GM. The session page was fixed in 4.5.1 (#1176), but only for its own layout. Both now count through one helper, `answeredLine` in `components/session/roster.js`, so they can't drift apart: - "4 of 5 players have answered" when some players have answered; - "No players have answered yet" when none has, even if the GM has; - nothing at all when there are no players. One side effect: the session page now says "No players have answered yet" where it used to say "0 of 4 players have answered". Tests: vitest on This week, `components/session` and `pages/session` (600 passed) on docker-test; eslint has 0 errors; the version sync and changelog checks pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(webapp): This week counts players only in the answered line, through one shared helper (#1202)
Some checks failed
CI / Backend lint (ruff) (pull_request) Successful in 26s
Details
CI / Which journeys does this change need? (pull_request) Successful in 29s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 31s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Feedback site tests (pull_request) Successful in 42s
Details
CI / Bot/backend version sync (pull_request) Successful in 57s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 59s
Details
CI / Docker image build (pull_request) Successful in 1m36s
Details
CI / Bot tests and audit (pull_request) Successful in 1m59s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 7m19s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 8m44s
Details
CI / End-to-end journeys (desktop) (desktop) (pull_request) Failing after 21m23s
Details
CI / Backend migration, tests, and audit (pull_request) Has been cancelled
Details
96e30675ca 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 06:07:29 +00:00
test(e2e): J1 reads the players-only count (#1202)
All checks were successful
CI / Backend lint (ruff) (pull_request) Successful in 36s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m7s
Details
CI / Bot/backend version sync (pull_request) Successful in 26s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 24s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Which journeys does this change need? (pull_request) Successful in 24s
Details
CI / Feedback site tests (pull_request) Successful in 1m26s
Details
CI / Bot tests and audit (pull_request) Successful in 2m20s
Details
CI / Docker image build (pull_request) Successful in 5m37s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 9m47s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 11m29s
Details
CI / End-to-end journeys (phone) (phone) (pull_request) Successful in 13m2s
Details
CI / End-to-end journeys (desktop) (desktop) (pull_request) Successful in 14m37s
Details
CI / End-to-end journeys (keyboard) (keyboard) (pull_request) Successful in 18m6s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 37m36s
Details
c3ca689688 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1204
No description provided.