fix(webapp): small things from the 4.5.1-rc1 render check (#1175) #1176

Merged

claude-bot merged 3 commits from fix/1175-render-check-findings into main 2026-10-13 18:29:35 +00:00

Conversation 0 Commits 3 Files changed 13 +120 -20

claude-bot commented 2026-10-13 17:50:46 +00:00

Collaborator

Copy link

Closes #1175.

1. The roster count is about players and says so. On the session page: "N of M players have answered"; "No players have answered yet." when the reader has answered and no player has; no count and no "nobody" line in a campaign with no players. Frontend only (pages/session/confirmed.js, AreYouIn.jsx). This week's inline count is unchanged: it counts everybody and matches its rows.
2. Map at phone width. The map-level breadcrumb buttons and the marker panel's Close button get a 24 px minimum target (Map.css), with no change at desktop. See "Not confirmed" below.
3. /favicon.ico serves the icon, not the app's HTML (nginx.conf, an exact-match location onto /favicon.png).
4. The remind button's refusals say what is true. A bot that does not list the nudge feature: 409 "The bot is an older version and cannot post this yet. Ask whoever runs Quest Board to update it." A bot whose features are unknown because it is not answering: 503 "The bot is not answering. Try again in a minute." Before, both read "The bot needs updating…". With backend and bot at the same release the first cannot show (BOT_FEATURES lists rsvp_nudge).

No bot API contract change, no migration.

Verified

On docker-test: vitest for src/components/session, src/pages/session, src/pages/wiki/Map* (561 passed); test_rsvp_nudge.py and test_nginx_upload_limit.py (41); ruff; frontend lint; changelog check. A frontend-prod build served /favicon.ico as image/png, the same bytes as /favicon.png, with the CSP and the other security headers.

Not confirmed

Item 2. The a11y journey for the wiki pages, which includes the map, passed on the phone project before the fix, and there is no baseline allowance for it. The violation was seen once, in the render check, on a map whose test markers had been placed on top of one another at one corner; overlapping targets fail target-size by themselves, so it may never have been a defect in the page. The two CSS changes are the controls that measured under 24 px on reading the code, and are harmless either way. Not re-run after the fix.

This PR touches no journey, so it is also the first real run of the desktop-only path from #1174.

🤖 Generated with Claude Code

Closes #1175. 1. **The roster count is about players and says so.** On the session page: "N of M players have answered"; "No players have answered yet." when the reader has answered and no player has; no count and no "nobody" line in a campaign with no players. Frontend only (`pages/session/confirmed.js`, `AreYouIn.jsx`). This week's inline count is unchanged: it counts everybody and matches its rows. 2. **Map at phone width.** The map-level breadcrumb buttons and the marker panel's Close button get a 24 px minimum target (`Map.css`), with no change at desktop. See "Not confirmed" below. 3. **`/favicon.ico` serves the icon**, not the app's HTML (`nginx.conf`, an exact-match location onto `/favicon.png`). 4. **The remind button's refusals say what is true.** A bot that does not list the nudge feature: 409 "The bot is an older version and cannot post this yet. Ask whoever runs Quest Board to update it." A bot whose features are unknown because it is not answering: 503 "The bot is not answering. Try again in a minute." Before, both read "The bot needs updating…". With backend and bot at the same release the first cannot show (`BOT_FEATURES` lists `rsvp_nudge`). No bot API contract change, no migration. ## Verified On `docker-test`: vitest for `src/components/session`, `src/pages/session`, `src/pages/wiki/Map*` (561 passed); `test_rsvp_nudge.py` and `test_nginx_upload_limit.py` (41); ruff; frontend lint; changelog check. A `frontend-prod` build served `/favicon.ico` as `image/png`, the same bytes as `/favicon.png`, with the CSP and the other security headers. ## Not confirmed Item 2. The a11y journey for the wiki pages, which includes the map, passed on the phone project **before** the fix, and there is no baseline allowance for it. The violation was seen once, in the render check, on a map whose test markers had been placed on top of one another at one corner; overlapping targets fail `target-size` by themselves, so it may never have been a defect in the page. The two CSS changes are the controls that measured under 24 px on reading the code, and are harmless either way. Not re-run after the fix. This PR touches no journey, so it is also the first real run of the desktop-only path from #1174. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-10-13 17:50:46 +00:00

fix(webapp): the session page counts players in words and never contradicts the GM's row (#1175) ... 5cf7401b35

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): favicon.ico, honest bot messages on the reminder (#1175) ... 3f635d00e5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): map breadcrumb and Close targets are 24px (#1175) ... 077c1e74e0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 17:50:51 +00:00

claude-bot merged commit 0f65e817e7 into main 2026-10-13 18:29:35 +00:00

claude-bot deleted branch fix/1175-render-check-findings 2026-10-13 18:29:35 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 18:29:36 +00:00

Merge PR #1176: small things from the 4.5.1-rc1 render check (#1175)

claude-bot referenced this pull request 2026-10-13 18:31:13 +00:00

feat: nudge follow-ups: the button on This week, the setting in exports, and a reminder for people with no linked Discord (#1158) #1179

claude-bot referenced this pull request 2026-10-17 04:21:15 +00:00

This week's "2 of 3 have answered" counts the GM #1202

claude-bot referenced this pull request 2026-10-17 06:07:27 +00:00

fix(webapp): This week counts players, not the GM, in "Are you in?" (#1202) #1204

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1176

No description provided.