fix: a vote-mode switch keeps approved sessions' picks; This week counts players still deciding (4.6.0-rc2) #1218

Merged

claude-bot merged 2 commits from fix/460-rc2-server into main 2026-10-17 20:48:33 +00:00

Conversation 0 Commits 2 Files changed 6 +135 -4

claude-bot commented 2026-10-17 20:14:02 +00:00

Collaborator

Copy link

Two fixes found by the 4.6.0-rc1 render check.

• Line of the night: switching a campaign to "Voted by the table" no longer reopens voting on sessions already approved. Each approved session's vote is marked as never opened, at its approval time, so it keeps the GM's pick and shows no vote. Sessions approved after the switch vote as normal. Votes already cast are never deleted. One rare edge: switching vote → GM → vote while a session's three-day vote is still running ends that vote early, and its pick and votes are kept.
• This week's "N still deciding" counts players, not the GM, through the same playersOf rule as #1202.

There is no migration and no API change. Tests: the line-of-the-night, attention and campaign suites (198 passed), and This week vitest (63 passed). ruff and the checks are clean.

🤖 Generated with Claude Code

Two fixes found by the 4.6.0-rc1 render check. - **Line of the night: switching a campaign to "Voted by the table" no longer reopens voting on sessions already approved.** Each approved session's vote is marked as never opened, at its approval time, so it keeps the GM's pick and shows no vote. Sessions approved after the switch vote as normal. Votes already cast are never deleted. One rare edge: switching vote → GM → vote while a session's three-day vote is still running ends that vote early, and its pick and votes are kept. - **This week's "N still deciding" counts players, not the GM**, through the same `playersOf` rule as #1202. There is no migration and no API change. Tests: the line-of-the-night, attention and campaign suites (198 passed), and This week vitest (63 passed). ruff and the checks are clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-10-17 20:14:02 +00:00

fix: line-of-the-night mode switch spares approved sessions; still-deciding counts players (#1191) ... 9b428f3f12

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

style: ruff format 9496fdef4e

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 20:14:04 +00:00

claude-bot merged commit 5ffae88f56 into main 2026-10-17 20:48:33 +00:00

claude-bot referenced this pull request from a commit 2026-10-17 20:48:34 +00:00

Merge PR #1218: a vote-mode switch keeps approved picks; players still deciding

claude-bot referenced this pull request 2026-10-17 20:50:24 +00:00

chore(release): v4.6.0-rc2 #1220

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1218

No description provided.