feat(webapp): browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1300

Merged

claude-bot merged 13 commits from feat/1241-rules-library into main 2026-11-01 04:06:09 +00:00

Conversation 1 Commits 13 Files changed 27 +3188 -609

claude-bot commented 2026-10-31 19:26:28 +00:00

Collaborator

Copy link

Closes #1241. Includes the design (lane 6f, D305–D309) from #1298, which this replaces.

What it adds

• The rules library at /rules: everything the server's own packs hold, per game system, outside any campaign. Campaign packs are never included.
  • It has stage 1's kinds, filters, numbered pages and search.
  • A record opens in place.
  • Actions on a record:
    • "Use it in a campaign…" lists your campaigns that play that system and opens the entry there.
    • "Copy a link to it" copies a link that opens the library with that row open.
• Its doors (D307):
  • Home's menu → This instance → Rules library, for everyone signed in (D305);
  • Browse on each pack in Admin → Content packs;
  • "The whole library" on each campaign's Rules page.
• Admin, a pack → Browse (/admin/packs/:id/browse): that pack's records by kind, at any status. A switched-off pack says so and offers "Switch it on".
• GM-only records outside a campaign (D306): shown to admins and to GMs of a live campaign of that system.
• The open URL parameter works on the campaign Rules page too.

API

• GET /api/reference/library
• GET /api/admin/content-packs/{id}/browse/kinds, /browse/page and /browse/{entry_id} (admin)
• The existing kinds, page and entry routes, called without campaign_id, are the library and now apply D306.

No migration. The bot contract is unchanged.

Checked so far

• Backend: lint is clean, the checks pass, and 438 reference and content-pack tests pass, including 15 new ones.
• Frontend: lint has 0 errors, and the full vitest suite passed apart from one test (5,599 passed, 1 failed). That test was a date-format expectation, which was then fixed, and the affected folders re-ran green (373 passed).
• Not yet: the render check, and the full suites, which CI runs.

The new wording goes on the Wording Review page before this merges.

🤖 Generated with Claude Code

Closes #1241. Includes the design (lane 6f, D305–D309) from #1298, which this replaces. **What it adds** - **The rules library at `/rules`:** everything the server's own packs hold, per game system, outside any campaign. Campaign packs are never included. - It has stage 1's kinds, filters, numbered pages and search. - A record opens in place. - Actions on a record: - **"Use it in a campaign…"** lists your campaigns that play that system and opens the entry there. - **"Copy a link to it"** copies a link that opens the library with that row open. - **Its doors (D307):** - Home's menu → This instance → Rules library, for everyone signed in (D305); - Browse on each pack in Admin → Content packs; - "The whole library" on each campaign's Rules page. - **Admin, a pack → Browse** (`/admin/packs/:id/browse`): that pack's records by kind, at any status. A switched-off pack says so and offers "Switch it on". - **GM-only records outside a campaign (D306):** shown to admins and to GMs of a live campaign of that system. - The `open` URL parameter works on the campaign Rules page too. **API** - `GET /api/reference/library` - `GET /api/admin/content-packs/{id}/browse/kinds`, `/browse/page` and `/browse/{entry_id}` (admin) - The existing kinds, page and entry routes, called without `campaign_id`, are the library and now apply D306. No migration. The bot contract is unchanged. **Checked so far** - Backend: lint is clean, the checks pass, and 438 reference and content-pack tests pass, including 15 new ones. - Frontend: lint has 0 errors, and the full vitest suite passed apart from one test (5,599 passed, 1 failed). That test was a date-format expectation, which was then fixed, and the affected folders re-ran green (373 passed). - **Not yet:** the render check, and the full suites, which CI runs. The new wording goes on the Wording Review page before this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 11 commits 2026-10-31 19:26:29 +00:00

design: browse the rules, stage 2 -- the rules library and Browse on a pack (#1241) ... 5c81f1a416

Lane 6f: the server's rules library outside any campaign, Browse on each
pack in Admin, a switched-off pack, a phone, and nothing loaded, with four
questions for the owner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

design: lane 6f, a record opened in the rules library (#1241) ... 701b7bbf60

A creature's stat block and a spell's text open in place, as on a
campaign's Rules page, with Use it in a campaign and Copy a link to it;
a phone view; a fifth question, on links to a record.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

design: rules library decided, D305-D309 (#1241) ... 47e33d8ba7

The owner's answers to Q194-Q198: anyone signed in; GM-only entries for
admins and the system's GMs; three doors, adding The whole library on a
campaign's Rules page; Use it in a campaign; Copy a link to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): rules library backend: GM records outside a campaign, library listing, admin pack browse (#1241) ... 3001e12e0d

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

WIP(webapp): shared rules browsing, rules library, pack browse (#1241) 79915b6ad6

style: ruff format (#1241) ... 6d087f5f44

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

WIP(webapp): rules library tests and lint fixes (#1241) 27bc76478f

WIP: test fix 244cb578c1

feat(webapp): the rules library, Browse on a pack, open row in the URL (#1241) 3f296ce088

test(webapp): pack browse date reads as the app's other dates (#1241) 41a54e2037

Merge branch 'feat/1241-frontend' into feat/1241-rules-library ddfb8694d9

claude-bot referenced this pull request 2026-10-31 19:26:36 +00:00

design: browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1298

rbrooks added 1 commit 2026-10-31 19:52:42 +00:00

fix(webapp): the library's chosen game system shows pressed (#1241) ... 2494ac3877

The render check showed both system buttons alike; they share the pack
filter's pressed style now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-31 19:52:50 +00:00

Admin → Content packs: "ancestrys", "vpf2e-8.6.1", and two axe findings (already on main) #1302

claude-bot commented 2026-10-31 19:52:56 +00:00

Author

Collaborator

Copy link

Render check (journeys stack, both starters loaded)

The run: 88 shots, signed in as Dana (admin) and Priya (player), at 1280×800 and 390×844, in light and dark.

Results

• Every page returned HTTP 200, with 0 console errors and no horizontal overflow on a phone.
• These all render:
  • the library's kinds grid, a kind opened, and a creature's stat block and a spell opened;
  • the "Use it in a campaign…" dialog (Priya: "The Blackfen Warrant · You play");
  • Home's "This instance → Rules library" for both people;
  • "The whole library ›" on a campaign's Rules page;
  • Browse on each pack, and the pack page, including switched off with its banner and "Switch it on";
  • a deep link with open=, which loads with that row open.
• Axe found nothing new on these pages. It's clean on the library and the campaign Rules page at desktop width.

Fixed here: the chosen game system's button didn't look pressed. Both systems looked alike. Fixed in 2494ac38, which gives them the pack filter's pressed style.

Found, but already on main, so filed separately:

• #1301: an opened entry shows its markdown literally (**bold**, ---). This comes from stage 1, and the fix covers both pages.
• #1302: on Admin → Content packs, "ancestrys", the version showing as "vpf2e-8.6.1", the licence link marked by colour only, and on a phone the app bar's name not matching its visible text.

Not seen: "Link copied". The check ran over plain http, where the browser has no clipboard, so the fallback field showed, which is correct there. Dev and prod are https.

## Render check (journeys stack, both starters loaded) The run: 88 shots, signed in as Dana (admin) and Priya (player), at 1280×800 and 390×844, in light and dark. **Results** - Every page returned HTTP 200, with 0 console errors and no horizontal overflow on a phone. - These all render: - the library's kinds grid, a kind opened, and a creature's stat block and a spell opened; - the "Use it in a campaign…" dialog (Priya: "The Blackfen Warrant · You play"); - Home's "This instance → Rules library" for both people; - "The whole library ›" on a campaign's Rules page; - Browse on each pack, and the pack page, including switched off with its banner and "Switch it on"; - a deep link with `open=`, which loads with that row open. - Axe found nothing new on these pages. It's clean on the library and the campaign Rules page at desktop width. **Fixed here:** the chosen game system's button didn't look pressed. Both systems looked alike. Fixed in 2494ac38, which gives them the pack filter's pressed style. **Found, but already on main, so filed separately:** - #1301: an opened entry shows its markdown literally (`**bold**`, `---`). This comes from stage 1, and the fix covers both pages. - #1302: on Admin → Content packs, "ancestrys", the version showing as "vpf2e-8.6.1", the licence link marked by colour only, and on a phone the app bar's name not matching its visible text. **Not seen:** "Link copied". The check ran over plain http, where the browser has no clipboard, so the fallback field showed, which is correct there. Dev and prod are https.

rbrooks added 1 commit 2026-10-31 20:06:10 +00:00

fix(webapp): a rules entry's text is drawn from its markdown (#1301) ... 80f26b9e5a

Opened entries showed pack markup literally (**bold**, ---). RuleText
draws it with react-markdown: no raw HTML, no pictures (alt text, so no
fetch from a pack's address, as D297), headings brought down to bold.

Closes #1301

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-31 20:06:14 +00:00

Rules: an opened entry shows its text's markdown literally (**bold**, ---) #1301

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-11-01 04:05:30 +00:00

claude-bot merged commit d9d22d1afb into main 2026-11-01 04:06:09 +00:00

claude-bot referenced this pull request from a commit 2026-11-01 04:06:10 +00:00

Merge pull request 'feat(webapp): browse the rules, stage 2 — the rules library and Browse on a pack (#1241)' (#1300) from feat/1241-rules-library into main

claude-bot referenced this pull request 2026-11-01 04:06:22 +00:00

Browse the rules, stage 2: a rules library per game system, outside any campaign #1241

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1300

No description provided.