Admin → Content packs: "ancestrys", "vpf2e-8.6.1", and two axe findings (already on main) #1302

New issue

Closed

opened 2026-10-31 19:52:49 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-10-31 19:52:49 +00:00

Collaborator

Found in the #1241 render check (31 Oct, journeys stack with both starters loaded). None of it comes from #1300.

Plural: a pack's summary says "9 ancestrys" and "16 ancestrys". The kind is pluralised by adding an "s"; use the kind labels from app/reference/browse.py (Ancestries) instead.
Version: the version shows as "vpf2e-8.6.1" and "vv2026-10-17". A "v" is put in front of a version string that already carries its own prefix. Show the version as given, or add a "v" only before a bare number.
axe link-in-text-block (serious, 2 nodes): the licence link in a pack row (.pk__lic > a) is distinguished from the text around it by colour only. Underline it, as .textlink does.
axe label-content-name-mismatch (serious, phone only): .appbar__brand. Its accessible name doesn't contain its visible text ("QB"). This affects every page on a phone, not just Admin.

Small. For 4.7.0, as fixes.

Found in the #1241 render check (31 Oct, journeys stack with both starters loaded). None of it comes from #1300. 1. **Plural:** a pack's summary says "9 ancestrys" and "16 ancestrys". The kind is pluralised by adding an "s"; use the kind labels from `app/reference/browse.py` (Ancestries) instead. 2. **Version:** the version shows as "vpf2e-8.6.1" and "vv2026-10-17". A "v" is put in front of a version string that already carries its own prefix. Show the version as given, or add a "v" only before a bare number. 3. **axe `link-in-text-block`** (serious, 2 nodes): the licence link in a pack row (`.pk__lic > a`) is distinguished from the text around it by colour only. Underline it, as `.textlink` does. 4. **axe `label-content-name-mismatch`** (serious, phone only): `.appbar__brand`. Its accessible name doesn't contain its visible text ("QB"). This affects every page on a phone, not just Admin. Small. For 4.7.0, as fixes.

claude-bot referenced this issue

2026-10-31 19:52:56 +00:00

feat(webapp): browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1300

claude-bot referenced this issue

2026-11-01 04:06:22 +00:00

Browse the rules, stage 2: a rules library per game system, outside any campaign #1241

rbrooks referenced this issue from a commit

2026-11-02 03:34:17 +00:00

fix(webapp): pack labels and two accessibility findings (#1302)

rbrooks referenced this issue from a commit

2026-11-02 03:34:17 +00:00

docs: changelog fragment for #1302

rbrooks referenced this issue from a commit

2026-11-02 03:34:17 +00:00

test: the wordmark link's name, without its aria-label (#1302)

claude-bot referenced this issue from a pull request that will close it,

2026-11-02 03:34:24 +00:00

fix(webapp): pack labels and two accessibility findings (#1302) #1306

claude-bot commented

2026-11-02 03:34:31 +00:00

Author

Collaborator

All four are fixed in #1306:

"ancestries" (plural() handles consonant + y);
a "v" only before a bare version number;
the terms link is underlined;
the app bar's home link is named by its own text plus a hidden ", home", so on a phone its name contains the "QB" it shows.

Checked on docker-test: lint has 0 errors, and vitest passes, 418 tests in 29 files. It merges on the owner's say.

All four are fixed in #1306: - "ancestries" (`plural()` handles consonant + y); - a "v" only before a bare version number; - the terms link is underlined; - the app bar's home link is named by its own text plus a hidden ", home", so on a phone its name contains the "QB" it shows. Checked on docker-test: lint has 0 errors, and vitest passes, 418 tests in 29 files. It merges on the owner's say.

claude-bot closed this issue

2026-11-02 05:40:59 +00:00

claude-bot referenced this issue from a commit

2026-11-02 05:41:00 +00:00

Merge pull request 'fix(webapp): pack labels and two accessibility findings (#1302)' (#1306) from fix/1302-packs-polish into main