rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

fix(webapp): pack labels and two accessibility findings (#1302) #1306

Merged
claude-bot merged 3 commits from fix/1302-packs-polish into main 2026-11-02 05:40:59 +00:00
Conversation 0 Commits 3 Files changed 6 +47 -7
claude-bot commented 2026-11-02 03:34:24 +00:00
Collaborator
Copy link

Closes #1302. These came from the #1241 render check and were already on main.

  • "9 ancestries", not "ancestrys": plural() now handles consonant + y. "day" stays "days".
  • A pack's version gets a "v" only when it's a bare number. "pf2e-8.6.1" no longer reads "vpf2e-8.6.1".
  • The licence's terms link is underlined (.textlink), instead of being told apart by colour alone (axe link-in-text-block).
  • The app bar's home link is named by its own text plus a hidden ", home", instead of aria-label="Quest Board, home". On a phone it shows "QB", and its name ("QB, home") now contains that (axe label-content-name-mismatch, WCAG 2.5.3). On a desktop it's still "Quest Board, home". jsdom drops the space inside "uest ", so the three tests that find the link by name accept both spellings, and a comment says why.
  • A changelog fragment.

Checked on docker-test:

  • frontend lint: 0 errors;
  • vitest over src/pages/admin, src/ui/AppBar, src/shell, the new contentPacksShared.test.jsx and the two other plural() callers: 29 files, 418 passed, 1 skipped;
  • the changelog check passes.

No new wording. Every visible string is either a correction of an existing one or unchanged.

🤖 Generated with Claude Code

Closes #1302. These came from the #1241 render check and were already on main. - **"9 ancestries", not "ancestrys":** `plural()` now handles consonant + y. "day" stays "days". - **A pack's version** gets a "v" only when it's a bare number. "pf2e-8.6.1" no longer reads "vpf2e-8.6.1". - **The licence's terms link** is underlined (`.textlink`), instead of being told apart by colour alone (axe `link-in-text-block`). - **The app bar's home link** is named by its own text plus a hidden ", home", instead of `aria-label="Quest Board, home"`. On a phone it shows "QB", and its name ("QB, home") now contains that (axe `label-content-name-mismatch`, WCAG 2.5.3). On a desktop it's still "Quest Board, home". jsdom drops the space inside "uest ", so the three tests that find the link by name accept both spellings, and a comment says why. - A changelog fragment. **Checked on docker-test:** - frontend lint: 0 errors; - vitest over `src/pages/admin`, `src/ui/AppBar`, `src/shell`, the new `contentPacksShared.test.jsx` and the two other `plural()` callers: 29 files, 418 passed, 1 skipped; - the changelog check passes. No new wording. Every visible string is either a correction of an existing one or unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
- "9 ancestries", not "ancestrys": plural() handles consonant + y.
- A pack's version gets a v only when it is a bare number, so
  "pf2e-8.6.1" no longer reads "vpf2e-8.6.1".
- The licence's terms link is underlined (axe link-in-text-block).
- The app bar's home link is named by its own text plus a hidden
  ", home", so on a phone its name contains the "QB" it shows
  (axe label-content-name-mismatch, WCAG 2.5.3).

Closes #1302

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test: the wordmark link's name, without its aria-label (#1302)
All checks were successful
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 55s
Details
CI / Bot/backend version sync (pull_request) Successful in 28s
Details
CI / Backend lint (ruff) (pull_request) Successful in 31s
Details
CI / Feedback site tests (pull_request) Successful in 50s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 22s
Details
CI / Which journeys does this change need? (pull_request) Successful in 22s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Bot tests and audit (pull_request) Successful in 2m9s
Details
CI / Docker image build (pull_request) Successful in 3m10s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 8m54s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 10m26s
Details
CI / End-to-end journeys (desktop) (pull_request) Successful in 14m17s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 33m30s
Details
dd4be5aa49 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot scheduled this pull request to auto merge when all checks succeed 2026-11-02 05:35:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1306
No description provided.