rbrooks/Quest-Board

Watch

Fork 0

Browse the rules, stage 2: a rules library per game system, outside any campaign #1241

New issue

Closed

opened 2026-10-26 23:37:12 +00:00 by claude-bot · 3 comments

claude-bot commented

2026-10-26 23:37:12 +00:00

Collaborator

Why

Owner, 26 Oct 2026, stage 2 of 4, after #1240. Today loaded content can only be reached from inside a campaign that uses that game system. Nobody can see what a pack actually loaded without making or opening such a campaign, and nothing can be looked up between campaigns.

What (to draw first)

A rules library for each game system that has packs loaded. It reuses #1240's kinds, list, filters and entry view, scoped to the instance's packs rather than a campaign's.
A Browse view on each pack in Admin → Content packs: that pack's records only, by kind. This checks an import ("did the feats come through?") and sits beside the import warnings.
To decide in the drawing:
- Who may open the per-system library: admins only, or any signed-in user of the server? Campaign packs are never included; GM-only records follow the same rule as today.
- Where its door is. D64 keeps loaded packs off every public page, so this is never public.
- Whether "Make it ours" and "Add to a sheet" appear here. They need a campaign, so probably "Open in a campaign…" or nothing.

Server

The search service scoped to the instance only (campaign_id absent) plus an optional pack_id, with the visibility rule written down.
Counts by kind per pack. counts on the pack row may already carry these; check.

Process

Draw, owner sign-off, build, a CATALOGUE row (ADMIN-11, and a new surface for the library). Tests: no campaign pack ever shows; a disabled pack is listed as disabled with its records out of the library; admin and non-admin access follows whatever the drawing settles.

## Why Owner, 26 Oct 2026, stage 2 of 4, after #1240. Today loaded content can only be reached from inside a campaign that uses that game system. Nobody can see what a pack actually loaded without making or opening such a campaign, and nothing can be looked up between campaigns. ## What (to draw first) - **A rules library for each game system** that has packs loaded. It reuses #1240's kinds, list, filters and entry view, scoped to the instance's packs rather than a campaign's. - **A Browse view on each pack** in Admin → Content packs: that pack's records only, by kind. This checks an import ("did the feats come through?") and sits beside the import warnings. - **To decide in the drawing:** - Who may open the per-system library: admins only, or any signed-in user of the server? Campaign packs are never included; GM-only records follow the same rule as today. - Where its door is. D64 keeps loaded packs off every public page, so this is never public. - Whether "Make it ours" and "Add to a sheet" appear here. They need a campaign, so probably "Open in a campaign…" or nothing. ## Server - The search service scoped to the instance only (`campaign_id` absent) plus an optional `pack_id`, with the visibility rule written down. - Counts by kind per pack. `counts` on the pack row may already carry these; check. ## Process Draw, owner sign-off, build, a CATALOGUE row (ADMIN-11, and a new surface for the library). Tests: no campaign pack ever shows; a disabled pack is listed as disabled with its records out of the library; admin and non-admin access follows whatever the drawing settles.

claude-bot referenced this issue

2026-10-26 23:37:38 +00:00

Browse the rules, stage 1: Rules & bestiary lists what is loaded, by kind, without a search #1240

claude-bot added a new dependency

2026-10-26 23:37:41 +00:00

#1240 Browse the rules, stage 1: Rules & bestiary lists what is loaded, by kind, without a search

claude-bot added a new dependency

2026-10-26 23:37:42 +00:00

#1242 Browse the rules, stage 3: filters for each game system (spell tradition and rank, creature traits and size, item price and bulk…)

claude-bot added this to the v4.7.0 - Browse the Rules milestone

2026-10-27 17:53:30 +00:00

rbrooks referenced this issue from a commit

2026-10-31 17:50:11 +00:00

design: browse the rules, stage 2 -- the rules library and Browse on a pack (#1241)

claude-bot referenced this issue

2026-10-31 17:50:44 +00:00

design: browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1298

claude-bot commented

2026-10-31 17:50:46 +00:00

Author

Collaborator

Drawn as lane 6f: https://questboard-dev.rhoving.com/feedback/prototype/lane6f (branch design/1241-rules-library).

The page has the library (LIB-1), Browse on a pack in Admin (ADMIN-11b) including a switched-off pack, a phone view, and the nothing-loaded state. Four questions for the owner are at the bottom:

Who may open the library? Drawn for any signed-in user.
Who sees GM-only entries outside a campaign? Drawn for admins and anyone who runs a campaign of that system.
Where are its doors? Drawn as Home's menu → This server, plus Browse on each pack.
What can you do with an entry outside a campaign? Drawn as "Use it in a campaign…", the alternative being nothing.

Building waits for sign-off.

Drawn as lane 6f: https://questboard-dev.rhoving.com/feedback/prototype/lane6f (branch `design/1241-rules-library`). The page has the library (LIB-1), Browse on a pack in Admin (ADMIN-11b) including a switched-off pack, a phone view, and the nothing-loaded state. Four questions for the owner are at the bottom: 1. Who may open the library? Drawn for any signed-in user. 2. Who sees GM-only entries outside a campaign? Drawn for admins and anyone who runs a campaign of that system. 3. Where are its doors? Drawn as Home's menu → This server, plus Browse on each pack. 4. What can you do with an entry outside a campaign? Drawn as "Use it in a campaign…", the alternative being nothing. Building waits for sign-off.

rbrooks referenced this issue from a commit

2026-10-31 17:58:43 +00:00

design: lane 6f, a record opened in the rules library (#1241)

rbrooks referenced this issue from a commit

2026-10-31 18:11:56 +00:00

design: rules library decided, D305-D309 (#1241)

claude-bot commented

2026-10-31 18:13:13 +00:00

Author

Collaborator

The owner answered Q194–Q198 on 31 Oct. Recorded as D305–D309 (commit on design/1241-rules-library, PR #1298):

D305: anyone signed in may open the library. It is on no public page.
D306: GM-only entries are shown to admins, and to anyone who runs a campaign of that game system.
D307: three doors:
- Home's menu → This server → Rules library;
- Browse on each pack in Admin;
- and "The whole library" on each campaign's Rules page (option b). The drawing now shows this one too.
D308: an entry offers "Use it in a campaign…".
D309: "Copy a link to it" opens the library with that entry open.

Building next.

The owner answered Q194–Q198 on 31 Oct. Recorded as D305–D309 (commit on `design/1241-rules-library`, PR #1298): - **D305:** anyone signed in may open the library. It is on no public page. - **D306:** GM-only entries are shown to admins, and to anyone who runs a campaign of that game system. - **D307:** three doors: - Home's menu → This server → Rules library; - Browse on each pack in Admin; - **and** "The whole library" on each campaign's Rules page (option b). The drawing now shows this one too. - **D308:** an entry offers "Use it in a campaign…". - **D309:** "Copy a link to it" opens the library with that entry open. Building next.

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

feat(webapp): rules library backend: GM records outside a campaign, library listing, admin pack browse (#1241)

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

WIP(webapp): shared rules browsing, rules library, pack browse (#1241)

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

style: ruff format (#1241)

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

WIP(webapp): rules library tests and lint fixes (#1241)

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

feat(webapp): the rules library, Browse on a pack, open row in the URL (#1241)

rbrooks referenced this issue from a commit

2026-10-31 19:26:18 +00:00

test(webapp): pack browse date reads as the app's other dates (#1241)

claude-bot referenced this issue from a pull request that will close it,

2026-10-31 19:26:28 +00:00

feat(webapp): browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1300

claude-bot referenced this issue

2026-10-31 19:26:36 +00:00

design: browse the rules, stage 2 — the rules library and Browse on a pack (#1241) #1298

claude-bot referenced this issue

2026-10-31 19:52:40 +00:00

Rules: an opened entry shows its text's markdown literally (**bold**, ---) #1301

rbrooks referenced this issue from a commit

2026-10-31 19:52:42 +00:00

fix(webapp): the library's chosen game system shows pressed (#1241)

claude-bot referenced this issue

2026-10-31 19:52:50 +00:00

Admin → Content packs: "ancestrys", "vpf2e-8.6.1", and two axe findings (already on main) #1302

claude-bot closed this issue

2026-11-01 04:06:09 +00:00

claude-bot referenced this issue from a commit

2026-11-01 04:06:10 +00:00

Merge pull request 'feat(webapp): browse the rules, stage 2 — the rules library and Browse on a pack (#1241)' (#1300) from feat/1241-rules-library into main

claude-bot commented

2026-11-01 04:06:22 +00:00

Author

Collaborator

Done: #1300 merged on 1 Nov, after CI went green and the owner approved all 16 pieces of wording (Wording Review part l).

What shipped:

the rules library at /rules, with one button per game system, the kinds, filters and numbered pages, and search;
records open in place, with "Use it in a campaign…" and "Copy a link to it";
open= deep links, on the campaign Rules page too;
the three doors: Home's menu → This instance → Rules library, Browse on each pack in Admin, and "The whole library" on a campaign's Rules page;
the admin pack page, at any status, with the switched-off banner;
GM-only records outside a campaign follow D306.

Also fixed in the same PR: #1301 (a record's markdown is drawn, not shown raw) and the pressed state on the system buttons.

The render check found more things that were already on main; they're filed as #1302.

Follow-up from the design: no import-warnings link on the pack page, because the server doesn't keep a pack's warnings after the import.

Done: #1300 merged on 1 Nov, after CI went green and the owner approved all 16 pieces of wording (Wording Review part l). What shipped: - the rules library at `/rules`, with one button per game system, the kinds, filters and numbered pages, and search; - records open in place, with "Use it in a campaign…" and "Copy a link to it"; - `open=` deep links, on the campaign Rules page too; - the three doors: Home's menu → This instance → Rules library, Browse on each pack in Admin, and "The whole library" on a campaign's Rules page; - the admin pack page, at any status, with the switched-off banner; - GM-only records outside a campaign follow D306. Also fixed in the same PR: #1301 (a record's markdown is drawn, not shown raw) and the pressed state on the system buttons. The render check found more things that were already on main; they're filed as #1302. Follow-up from the design: no import-warnings link on the pack page, because the server doesn't keep a pack's warnings after the import.

claude-bot referenced this issue

2026-11-02 03:34:24 +00:00

fix(webapp): pack labels and two accessibility findings (#1302) #1306