rbrooks/Quest-Board

Watch

Fork 0

Emails open with the news, not a second "Quest Board"; the D171 record-start comment (#945 follow-ups) #949

Merged

claude-bot merged 2 commits from fix/945-leftovers into main

2026-09-30 06:39:04 +00:00

claude-bot commented

2026-09-30 05:07:23 +00:00

Collaborator

These are the three things #945 noticed but didn't change (#736):

The email's <h2> repeated "Quest Board" under the brand line. EX-040 draws the brand and then the body, with no heading. render() now takes heading=None and leaves the <h2> out, and notification emails pass it. Recaps keep their "Session Recap: …" heading.
The stale comment in session_record_start said the bot refuses when it can't announce. Since D171 it records anyway and returns announced_in: null. This is a comment-only change.
The answer-buttons email has no link to the session page. I left it as drawn: EX-040's answer email carries only the three buttons. The answer page those buttons open now links to the session instead (#901, in its own PR).

Tests:

test_email_templates.py gains two: a notification email has no <h2> and its text starts with the line; render(heading=None) leaves the heading out. Both fail on main.
The four modules that touch these symbols pass: test_email_templates, test_email_routes, test_table_live and wiki/test_body_readers (99 tests).
ruff check and format are clean over app/, tests/, scripts/ and e2e/.
changelog.py check passes.

Changelog: changelog.d/945-email-heading.changed.md.

🤖 Generated with Claude Code

These are the three things #945 noticed but didn't change (#736): 1. **The email's `<h2>` repeated "Quest Board"** under the brand line. EX-040 draws the brand and then the body, with no heading. `render()` now takes `heading=None` and leaves the `<h2>` out, and notification emails pass it. Recaps keep their "Session Recap: …" heading. 2. **The stale comment in `session_record_start`** said the bot refuses when it can't announce. Since D171 it records anyway and returns `announced_in: null`. This is a comment-only change. 3. **The answer-buttons email has no link to the session page.** I left it as drawn: EX-040's answer email carries only the three buttons. The answer page those buttons open now links to the session instead (#901, in its own PR). **Tests:** - `test_email_templates.py` gains two: a notification email has no `<h2>` and its text starts with the line; `render(heading=None)` leaves the heading out. Both fail on main. - The four modules that touch these symbols pass: `test_email_templates`, `test_email_routes`, `test_table_live` and `wiki/test_body_readers` (99 tests). - ruff check and format are clean over `app/`, `tests/`, `scripts/` and `e2e/`. - `changelog.py check` passes. Changelog: `changelog.d/945-email-heading.changed.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit

2026-09-30 05:07:24 +00:00

fix(email): no "Quest Board" heading under the brand line; D171 comment (#945 follow-ups)

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 56s

Details

CI / Docker image build (pull_request) Successful in 22s

Details

CI / Does this change touch the recording path? (pull_request) Successful in 27s

Details

CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped

Details

CI / Bot tests and audit (pull_request) Successful in 1m55s

Details

CI / Bot/backend version sync (pull_request) Successful in 1m12s

Details

CI / Backend lint (ruff) (pull_request) Successful in 1m23s

Details

CI / Feedback site tests (pull_request) Successful in 2m4s

Details

CI / Frontend (shard 2/2) (pull_request) Failing after 5m19s

Details

CI / Frontend (shard 1/2) (pull_request) Successful in 7m1s

Details

CI / End-to-end journeys (desktop) (pull_request) Successful in 6m52s

Details

CI / End-to-end journeys (phone) (pull_request) Successful in 7m18s

Details

CI / Backend migration, tests, and audit (pull_request) Successful in 15m1s

Details

CI / End-to-end journeys (keyboard) (pull_request) Successful in 15m53s

Details

e5f9b7130f

- Notification emails open with the news itself, as EX-040 draws them;
  render() takes heading=None to leave the <h2> out. Recaps keep theirs.
- session_record_start's comment said the bot refuses when it can't
  announce; since D171 it records anyway and returns announced_in: null.
- The answer-buttons email stays without a session link, as drawn; the
  answer page it opens links the session (#901).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit

2026-09-30 06:21:00 +00:00

Merge remote-tracking branch 'origin/main' into fix/945-leftovers

CI / Backend lint (ruff) (pull_request) Successful in 34s

Details

CI / Feedback site tests (pull_request) Successful in 43s

Details

CI / Bot/backend version sync (pull_request) Successful in 35s

Details

CI / Docker image build (pull_request) Successful in 16s

Details

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 59s