Test fix: PrepSheet's Shelf test looks its section up inside the wait (#955) #956

Merged

claude-bot merged 1 commit from fix/prepsheet-shelf-flake into main 2026-09-30 07:25:12 +00:00

Conversation 0 Commits 1 Files changed 1 +6 -1

claude-bot commented 2026-09-30 06:39:17 +00:00

Collaborator

Copy link

Closes #955. It's flaked twice in one night:

• #949's run 1669;
• #953's run 1674.

Both were "Frontend (shard 2/2)", both at PrepSheet.test.jsx:519, and both were Expected container to be an Element … but got null.

The cause: the test captured shelf = heading.closest("section") once, before its waitFor. Under load the heading can be found in a render where it isn't in its <section> yet, so shelf stayed null, and the waitFor spun on it until it timed out (5 s).

The fix: find the heading first as before, then look the section up inside the waitFor and assert it's there, so the wait covers the heading landing in its section too. It's test-only.

Checks: eslint shows 0 errors, and PrepSheet.test.jsx passed 5 runs in a row (25/25 each).

🤖 Generated with Claude Code

Closes #955. **It's flaked twice in one night:** - #949's run 1669; - #953's run 1674. Both were "Frontend (shard 2/2)", both at `PrepSheet.test.jsx:519`, and both were `Expected container to be an Element … but got null`. **The cause:** the test captured `shelf = heading.closest("section")` once, before its `waitFor`. Under load the heading can be found in a render where it isn't in its `<section>` yet, so `shelf` stayed `null`, and the `waitFor` spun on it until it timed out (5 s). **The fix:** find the heading first as before, then look the section up **inside** the `waitFor` and assert it's there, so the wait covers the heading landing in its section too. It's test-only. **Checks:** eslint shows 0 errors, and `PrepSheet.test.jsx` passed **5 runs in a row** (25/25 each). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-09-30 06:39:19 +00:00

test(prep): look the Shelf section up inside the wait, not before it (#955) ... 867c131271

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit 735990ceeb into main 2026-09-30 07:25:12 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 07:25:15 +00:00

Merge PR #956: PrepSheet's Shelf test looks its section up inside the wait (#955)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!956

No description provided.