The Preview scroll test waits for the call it asserts (#1039) #1041

Merged

claude-bot merged 1 commit from fix/1039-preview-scroll-test-waits into main 2026-10-02 22:19:03 +00:00

Conversation 0 Commits 1 Files changed 2 +8 -2

claude-bot commented 2026-10-02 21:37:09 +00:00

Collaborator

Copy link

Closes #1039.

Summary

Preview.jsx brings the panel into view from a passive effect. The test asserted the second scrollIntoView call on the line after findByText resolved, which is at commit and so can be before that effect has run on a busy runner. The test now waits for the call itself. Test only; the component is unchanged.

It turned PR #1038 (no frontend change) red once and PR #1034 (backend only) red once.

Changelog

• Fragment added: changelog.d/1039-preview-scroll-test-waits.fixed.md (scripts/changelog.py check passes)

Test plan

• CI on this PR. The vitest file was not run locally in this session; the change is one await waitFor(...) around an existing assertion.

🤖 Generated with Claude Code

Closes #1039. ## Summary `Preview.jsx` brings the panel into view from a passive effect. The test asserted the second `scrollIntoView` call on the line after `findByText` resolved, which is at commit and so can be before that effect has run on a busy runner. The test now waits for the call itself. Test only; the component is unchanged. It turned PR #1038 (no frontend change) red once and PR #1034 (backend only) red once. ## Changelog - [x] Fragment added: `changelog.d/1039-preview-scroll-test-waits.fixed.md` (`scripts/changelog.py check` passes) ## Test plan - [ ] CI on this PR. The vitest file was not run locally in this session; the change is one `await waitFor(...)` around an existing assertion. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-02 21:37:09 +00:00

The Preview scroll test waits for the call it asserts (#1039) ... 7e7280792e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-02 22:18:54 +00:00

The Claude Code setup becomes a thin layer over the shared user-level set (#1037) #1038

claude-bot merged commit 12676ebd21 into main 2026-10-02 22:19:03 +00:00

claude-bot deleted branch fix/1039-preview-scroll-test-waits 2026-10-02 22:19:05 +00:00

claude-bot referenced this pull request from a commit 2026-10-02 22:19:05 +00:00

Merge PR #1041: the Preview scroll test waits for the call it asserts (#1039)

claude-bot referenced this pull request 2026-10-02 22:19:36 +00:00

Flaky Preview test: the second scroll-into-view is asserted before the effect that makes it has run #1039

claude-bot referenced this pull request 2026-10-02 22:46:20 +00:00

Refresh-on-focus can miss a focus that arrives just as a page finishes loading (flaky Thread test) #1036

claude-bot referenced this pull request 2026-10-02 23:11:15 +00:00

[Backend] A character's name is not checked against other characters' existing heard-as aliases #634

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1041

No description provided.