feat: remind the people who haven't answered "Are you in?" (#1158) #1168

Merged

claude-bot merged 28 commits from feat/1158-nudge-unanswered into main 2026-10-13 05:48:44 +00:00

Conversation 0 Commits 28 Files changed 34 +1985 -9

claude-bot commented 2026-10-13 03:43:16 +00:00

Collaborator

Copy link

Closes #1158 (D302, D303). Backend, bot and frontend in one change.

• The nudge. One plain Discord line that pings the linked players with no answer, takes ✅ ❌ ❔ as answers, and carries no person-written text: mentions, fixed words, the session number, the time in the campaign's zone with each reader's own time in brackets, and a validated link.
  <@…> Are you in for Session 14, Tuesday 13 October at 8:00 pm CDT (<t:…:t> your time)? React ✅ if you are in, ❌ if you are not, ❔ if you might. Answer here: <url>
• Two triggers. A GM button on the session page ("Remind who hasn't answered", POST /sessions/{id}/remind-unanswered, audited, at most once in 12 hours), and an automatic nudge rsvp_nudge_minutes before a confirmed session (campaign setting, default 2880, can be turned off; once per confirmed time).
• Who. Players with no answer who have not muted the campaign. Never for a vote, a pencilled, cancelled, started or played session, or an archived campaign. A campaign with no Discord gets an in-app session_reminder with the answer buttons; a webhook-only campaign gets a 409 from the button.
• Send once. A conditional UPDATE claims the send and commits before anything goes out; a failed send restores the previous values.
• Bot. New event session_rsvp_nudge, offered only to a bot whose /identity lists the feature; an older bot ignores it. Additive: no BOT_CONTRACT_VERSION bump. faces.py gains only the nudge; _handle_vote_reminder's allowed_mentions is tightened from users=True to the exact ids.
• Migration e1158a1b2c3d (after e1159a1b2c3d): two columns on sessions, one on campaigns; real downgrade.

Not in the nudge: people with no linked Discord (naming them is person-written text; see #1166).

Verified

On docker-test: bot suite (709 passed); test_rsvp_nudge.py and the title-reader guard (39); an earlier wider backend run of 19 modules (578 passed, before the last payload change, not re-run since); alembic upgrade, downgrade -1, upgrade (before the re-point onto e1159a1b2c3d); ruff; version and changelog checks; frontend lint; the touched vitest files alone.

Not run: the full frontend suite (timed out under host load), the full backend suite, journeys, build; nothing after merging main (two doc conflicts resolved by hand). Not checkable on dev: the dev bot has no Discord token. No render check yet of the button and the setting.

🤖 Generated with Claude Code

Closes #1158 (D302, D303). Backend, bot and frontend in one change. - **The nudge.** One plain Discord line that pings the linked players with no answer, takes ✅ ❌ ❔ as answers, and carries no person-written text: mentions, fixed words, the session number, the time in the campaign's zone with each reader's own time in brackets, and a validated link. `<@…> Are you in for Session 14, Tuesday 13 October at 8:00 pm CDT (<t:…:t> your time)? React ✅ if you are in, ❌ if you are not, ❔ if you might. Answer here: <url>` - **Two triggers.** A GM button on the session page ("Remind who hasn't answered", `POST /sessions/{id}/remind-unanswered`, audited, at most once in 12 hours), and an automatic nudge `rsvp_nudge_minutes` before a confirmed session (campaign setting, default 2880, can be turned off; once per confirmed time). - **Who.** Players with no answer who have not muted the campaign. Never for a vote, a pencilled, cancelled, started or played session, or an archived campaign. A campaign with no Discord gets an in-app `session_reminder` with the answer buttons; a webhook-only campaign gets a 409 from the button. - **Send once.** A conditional `UPDATE` claims the send and commits before anything goes out; a failed send restores the previous values. - **Bot.** New event `session_rsvp_nudge`, offered only to a bot whose `/identity` lists the feature; an older bot ignores it. Additive: no `BOT_CONTRACT_VERSION` bump. `faces.py` gains only the nudge; `_handle_vote_reminder`'s `allowed_mentions` is tightened from `users=True` to the exact ids. - **Migration** `e1158a1b2c3d` (after `e1159a1b2c3d`): two columns on `sessions`, one on `campaigns`; real downgrade. Not in the nudge: people with no linked Discord (naming them is person-written text; see #1166). ## Verified On `docker-test`: bot suite (709 passed); `test_rsvp_nudge.py` and the title-reader guard (39); an earlier wider backend run of 19 modules (578 passed, before the last payload change, not re-run since); alembic upgrade, downgrade -1, upgrade (before the re-point onto `e1159a1b2c3d`); ruff; version and changelog checks; frontend lint; the touched vitest files alone. Not run: the full frontend suite (timed out under host load), the full backend suite, journeys, `build`; nothing after merging main (two doc conflicts resolved by hand). Not checkable on dev: the dev bot has no Discord token. No render check yet of the button and the setting. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 27 commits 2026-10-13 03:43:17 +00:00

wip(#1158): rsvp nudge backend service, poller, route, bot event ... 1f10c45424

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip(#1158): bot and backend tests ... 831032ccf6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(bot): nudges cannot ping or inject markup; exact allowed mentions (#1158) ... 89dde069b4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(bot): defuse link syntax in nudge text (#1158) ... 305088dcf4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): nudge claim keeps the session row current (#1158) ... 2c7fec9e43

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(bot): nudge text is one capped line; links checked, host-bound and wrapped (#1158) ... 6b403c4fd2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(bot): nudge encoding tests follow the wrapped link 8542d4925a

wip(#1158): pinging line carries no typed text; title and names ride in an embed 8894cdcf2a

fix(bot): nudge pinging line carries no person-written text; title, campaign and names ride in an embed (#1158) ... dcfc42e1a5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: allow-list the nudge service's title read dd7d394f41

style: ruff format the nudge files b23e3af4b4

feat(webapp): remind-unanswered button and the nudge setting (#1158) ... d919d16b29

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(#1158): D302 and D303, catalogue rows, changelog fragments, integrations table ... 37d09ecd90

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(webapp): remind button tests fbdd72a769

feat(webapp): remind button uses the kit's busy and why 62db031c7f

test(webapp): refusal test rejects with a plain object 4295952fe8

fix(bot): embed descriptions and field values cannot carry live links; link address kept from closing its markup (#1158) ... 8a6f2ebac2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(bot): embed link guard tests 84880495aa

test(bot): face() guard test d10c1be58b

fix(bot): the nudge is one plain line with no typed text; existing faces and the vote reminder back to main (#1158) ... 57cf1ccb6e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(bot): nudge tests for the plain line b51763b6c5

test(bot): fix nudge link test 4cdce563d6

fix(bot): the vote reminder pings only the ids it mentions (#1158) ... 166a6f4b55

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(bot): the nudge's time names the campaign's zone, with local time beside it (#1158) ... 8f899d735c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): the nudge event carries the campaign's zone and no typed text (#1158) ... 248ac08247

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(#1158): record the zone-aware line and no typed text; changelog ... dc4ebdb3e7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into feat/1158: the nudge migration follows the end-time repair ... bd24d9bf09

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-13 04:57:21 +00:00

Merge main into feat/1158: the nudge migration follows the series skips ... 3bc7de37a2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 04:57:24 +00:00

claude-bot merged commit 9ab3834552 into main 2026-10-13 05:48:44 +00:00

claude-bot deleted branch feat/1158-nudge-unanswered 2026-10-13 05:48:44 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 05:48:45 +00:00

Merge PR #1168: remind the people who haven't answered "Are you in?" (#1158)

claude-bot referenced this pull request 2026-10-13 18:31:13 +00:00

feat: nudge follow-ups: the button on This week, the setting in exports, and a reminder for people with no linked Discord (#1158) #1179

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1168

No description provided.